Make experimental a runtime flag

Signed-off-by: Kenfe-Mickael Laventure <mickael.laventure@gmail.com>
Upstream-commit: 7781a1bf0fef748877326632b88e92fbf3c90daa
Component: engine

components/engine/api/server/middleware/experimental.go

@@ -0,0 +1,29 @@
+package middleware
+
+import (
+	"net/http"
+
+	"golang.org/x/net/context"
+)
+
+// ExperimentalMiddleware is a the middleware in charge of adding the
+// 'Docker-Experimental' header to every outgoing request
+type ExperimentalMiddleware struct {
+	experimental string
+}
+
+// NewExperimentalMiddleware creates a new ExperimentalMiddleware
+func NewExperimentalMiddleware(experimentalEnabled bool) ExperimentalMiddleware {
+	if experimentalEnabled {
+		return ExperimentalMiddleware{"true"}
+	}
+	return ExperimentalMiddleware{"false"}
+}
+
+// WrapHandler returns a new handler function wrapping the previous one in the request chain.
+func (e ExperimentalMiddleware) WrapHandler(handler func(ctx context.Context, w http.ResponseWriter, r *http.Request, vars map[string]string) error) func(ctx context.Context, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
+	return func(ctx context.Context, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
+		w.Header().Set("Docker-Experimental", e.experimental)
+		return handler(ctx, w, r, vars)
+	}
+}

components/engine/api/server/router/checkpoint/backend.go

@@ -1,5 +1,3 @@
-// +build experimental
-
 package checkpoint
 
 import "github.com/docker/docker/api/types"

components/engine/api/server/router/checkpoint/checkpoint.go

@@ -26,3 +26,11 @@ func NewRouter(b Backend, decoder httputils.ContainerDecoder) router.Router {
 func (r *checkpointRouter) Routes() []router.Route {
 	return r.routes
 }
+
+func (r *checkpointRouter) initRoutes() {
+	r.routes = []router.Route{
+		router.NewGetRoute("/containers/{name:.*}/checkpoints", r.getContainerCheckpoints),
+		router.NewPostRoute("/containers/{name:.*}/checkpoints", r.postContainerCheckpoint),
+		router.NewDeleteRoute("/containers/{name}/checkpoints/{checkpoint}", r.deleteContainerCheckpoint),
+	}
+}

components/engine/api/server/router/checkpoint/checkpoint_experimental.go

@@ -1,15 +0,0 @@
-// +build experimental
-
-package checkpoint
-
-import (
-	"github.com/docker/docker/api/server/router"
-)
-
-func (r *checkpointRouter) initRoutes() {
-	r.routes = []router.Route{
-		router.NewGetRoute("/containers/{name:.*}/checkpoints", r.getContainerCheckpoints),
-		router.NewPostRoute("/containers/{name:.*}/checkpoints", r.postContainerCheckpoint),
-		router.NewDeleteRoute("/containers/{name}/checkpoints/{checkpoint}", r.deleteContainerCheckpoint),
-	}
-}

components/engine/api/server/router/checkpoint/checkpoint_regular.go

@@ -1,8 +0,0 @@
-// +build !experimental
-
-package checkpoint
-
-func (r *checkpointRouter) initRoutes() {}
-
-// Backend is empty so that the package can compile in non-experimental
-type Backend interface{}

components/engine/api/server/router/checkpoint/checkpoint_routes.go

@@ -1,5 +1,3 @@
-// +build experimental
-
 package checkpoint
 
 import (

components/engine/api/server/router/plugin/backend.go

@@ -1,5 +1,3 @@
-// +build experimental
-
 package plugin
 
 import (

components/engine/api/server/router/plugin/plugin.go

@@ -21,3 +21,16 @@ func NewRouter(b Backend) router.Router {
 func (r *pluginRouter) Routes() []router.Route {
 	return r.routes
 }
+
+func (r *pluginRouter) initRoutes() {
+	r.routes = []router.Route{
+		router.NewGetRoute("/plugins", r.listPlugins),
+		router.NewGetRoute("/plugins/{name:.*}", r.inspectPlugin),
+		router.NewDeleteRoute("/plugins/{name:.*}", r.removePlugin),
+		router.NewPostRoute("/plugins/{name:.*}/enable", r.enablePlugin), // PATCH?
+		router.NewPostRoute("/plugins/{name:.*}/disable", r.disablePlugin),
+		router.NewPostRoute("/plugins/pull", r.pullPlugin),
+		router.NewPostRoute("/plugins/{name:.*}/push", r.pushPlugin),
+		router.NewPostRoute("/plugins/{name:.*}/set", r.setPlugin),
+	}
+}

components/engine/api/server/router/plugin/plugin_experimental.go

@@ -1,20 +0,0 @@
-// +build experimental
-
-package plugin
-
-import (
-	"github.com/docker/docker/api/server/router"
-)
-
-func (r *pluginRouter) initRoutes() {
-	r.routes = []router.Route{
-		router.NewGetRoute("/plugins", r.listPlugins),
-		router.NewGetRoute("/plugins/{name:.*}", r.inspectPlugin),
-		router.NewDeleteRoute("/plugins/{name:.*}", r.removePlugin),
-		router.NewPostRoute("/plugins/{name:.*}/enable", r.enablePlugin), // PATCH?
-		router.NewPostRoute("/plugins/{name:.*}/disable", r.disablePlugin),
-		router.NewPostRoute("/plugins/pull", r.pullPlugin),
-		router.NewPostRoute("/plugins/{name:.*}/push", r.pushPlugin),
-		router.NewPostRoute("/plugins/{name:.*}/set", r.setPlugin),
-	}
-}

components/engine/api/server/router/plugin/plugin_regular.go

@@ -1,9 +0,0 @@
-// +build !experimental
-
-package plugin
-
-func (r *pluginRouter) initRoutes() {}
-
-// Backend is empty so that the package can compile in non-experimental
-// (Needed by volume driver)
-type Backend interface{}

components/engine/api/server/router/plugin/plugin_routes.go

@@ -1,5 +1,3 @@
-// +build experimental
-
 package plugin
 
 import (