diff --git a/cli-plugins/manager/error.go b/cli-plugins/manager/error.go index 7091491511..aaedae14fa 100644 --- a/cli-plugins/manager/error.go +++ b/cli-plugins/manager/error.go @@ -36,9 +36,6 @@ func (e *pluginError) MarshalText() (text []byte, err error) { // wrapAsPluginError wraps an error in a pluginError with an // additional message. func wrapAsPluginError(err error, msg string) error { - if err == nil { - return nil - } return &pluginError{cause: fmt.Errorf("%s: %w", msg, err)} } diff --git a/cli-plugins/manager/error_test.go b/cli-plugins/manager/error_test.go index 682860daad..2e92001c20 100644 --- a/cli-plugins/manager/error_test.go +++ b/cli-plugins/manager/error_test.go @@ -21,4 +21,7 @@ func TestPluginError(t *testing.T) { actual, err := json.Marshal(err) assert.Check(t, err) assert.Check(t, is.Equal(`"wrapping: testing"`, string(actual))) + + err = wrapAsPluginError(nil, "wrapping") + assert.Check(t, is.Error(err, "wrapping: %!w()")) }