From 416ca0615920ed86d1598b7afd5f1f7e07a9144b Mon Sep 17 00:00:00 2001 From: John Howard Date: Tue, 18 Jul 2017 14:23:23 -0700 Subject: [PATCH] Windows: Disable TestAttachTTYWithoutStdin Signed-off-by: John Howard Upstream-commit: e4ec9195fed2f3653ec6d0a2b1c9ca6b0e2b9c37 Component: engine --- .../engine/integration-cli/docker_cli_attach_test.go | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/components/engine/integration-cli/docker_cli_attach_test.go b/components/engine/integration-cli/docker_cli_attach_test.go index 33ecb44b61..ff319c0d8c 100644 --- a/components/engine/integration-cli/docker_cli_attach_test.go +++ b/components/engine/integration-cli/docker_cli_attach_test.go @@ -88,6 +88,14 @@ func (s *DockerSuite) TestAttachMultipleAndRestart(c *check.C) { } func (s *DockerSuite) TestAttachTTYWithoutStdin(c *check.C) { + // TODO @jhowardmsft. Figure out how to get this running again reliable on Windows. + // It works by accident at the moment. Sometimes. I've gone back to v1.13.0 and see the same. + // On Windows, docker run -d -ti busybox causes the container to exit immediately. + // Obviously a year back when I updated the test, that was not the case. However, + // with this, and the test racing with the tear-down which panic's, sometimes CI + // will just fail and `MISS` all the other tests. For now, disabling it. Will + // open an issue to track re-enabling this and root-causing the problem. + testRequires(c, DaemonIsLinux) out, _ := dockerCmd(c, "run", "-d", "-ti", "busybox") id := strings.TrimSpace(out)