From 06c4880d2c3c45789084188624fe7fb65e238d3a Mon Sep 17 00:00:00 2001 From: Daniel Hiltgen Date: Mon, 20 Aug 2018 10:11:53 -0700 Subject: [PATCH] Set up default product license for community engines This will report a fixed string for community engines Upstream-commit: 140dd867085cbe97947a64353fe245b858284172 Component: packaging --- components/packaging/Makefile | 2 ++ components/packaging/image/Dockerfile.engine | 12 ++++++++++-- components/packaging/image/Makefile | 9 +++++++-- components/packaging/static/Makefile | 1 + 4 files changed, 20 insertions(+), 4 deletions(-) diff --git a/components/packaging/Makefile b/components/packaging/Makefile index 3dfabe68a8..4a9d006698 100644 --- a/components/packaging/Makefile +++ b/components/packaging/Makefile @@ -6,6 +6,8 @@ DOCKER_GITCOMMIT:=abcdefg ARCH=$(shell uname -m) STATIC_VERSION=$(shell static/gen-static-ver $(ENGINE_DIR) $(VERSION)) GO_VERSION:=1.10.3 +DEFAULT_PRODUCT_LICENSE:=Community Engine +export DEFAULT_PRODUCT_LICENSE # Taken from: https://www.cmcrossroads.com/article/printing-value-makefile-variable print-% : ; @echo $($*) diff --git a/components/packaging/image/Dockerfile.engine b/components/packaging/image/Dockerfile.engine index 1da4d134e3..d393faf7f1 100644 --- a/components/packaging/image/Dockerfile.engine +++ b/components/packaging/image/Dockerfile.engine @@ -14,9 +14,17 @@ FROM builder as dockerd-builder WORKDIR /go/src/github.com/docker/docker COPY . /go/src/github.com/docker/docker ARG VERSION +ARG GITCOMMIT +ARG BUILDTIME +ARG PLATFORM +ARG PRODUCT +ARG DEFAULT_PRODUCT_LICENSE ENV VERSION ${VERSION} -ARG DOCKER_GITCOMMIT -ENV DOCKER_GITCOMMIT ${DOCKER_GITCOMMIT} +ENV GITCOMMIT ${GITCOMMIT} +ENV BUILDTIME ${BUILDTIME} +ENV PLATFORM ${PLATFORM} +ENV PRODUCT ${PRODUCT} +ENV DEFAULT_PRODUCT_LICENSE ${DEFAULT_PRODUCT_LICENSE} # TODO The way we set the version could easily be simplified not to depend on hack/... RUN bash ./hack/make/.go-autogen RUN go build -o /sbin/dockerd \ diff --git a/components/packaging/image/Makefile b/components/packaging/image/Makefile index 49fb98721a..7718ef11b6 100644 --- a/components/packaging/image/Makefile +++ b/components/packaging/image/Makefile @@ -6,6 +6,7 @@ STATIC_VERSION=$(shell ../static/gen-static-ver $(ENGINE_DIR) $(VERSION)) DOCKER_HUB_ORG?=dockereng ARCH=$(shell uname -m) ENGINE_IMAGE?=engine-community +DEFAULT_PRODUCT_LICENSE?=Community Engine .PHONY: help help: ## show make targets @@ -27,8 +28,12 @@ $(ENGINE_DIR)/Dockerfile.engine: # utilize manifests image-linux: $(ENGINE_DIR)/Dockerfile.engine docker build -t $(DOCKER_HUB_ORG)/$(ENGINE_IMAGE):$(STATIC_VERSION).$(ARCH) \ - --build-arg VERSION=$(STATIC_VERSION) \ - --build-arg DOCKER_GITCOMMIT=$$(cd $(ENGINE_DIR) && git rev-parse --short=7 HEAD) \ + --build-arg VERSION="$(STATIC_VERSION)" \ + --build-arg GITCOMMIT="$$(cd $(ENGINE_DIR) && git rev-parse --short=7 HEAD)" \ + --build-arg BUILDTIME="$(BUILDTIME)" \ + --build-arg PLATFORM="$(PLATFORM)" \ + --build-arg PRODUCT="$(PRODUCT)" \ + --build-arg DEFAULT_PRODUCT_LICENSE="$(DEFAULT_PRODUCT_LICENSE)" \ --file $< $(ENGINE_DIR) echo $(DOCKER_HUB_ORG)/$(ENGINE_IMAGE):$(STATIC_VERSION).$(ARCH) > $@ diff --git a/components/packaging/static/Makefile b/components/packaging/static/Makefile index 4c0cb32d91..dcf05e33cc 100644 --- a/components/packaging/static/Makefile +++ b/components/packaging/static/Makefile @@ -6,6 +6,7 @@ STATIC_VERSION=$(shell ./gen-static-ver $(ENGINE_DIR) $(VERSION)) CHOWN=docker run --rm -v $(CURDIR):/v -w /v alpine chown HASH_CMD=docker run -v $(CURDIR):/sum -w /sum debian:jessie bash hash_files DIR_TO_HASH:=build/linux +DEFAULT_PRODUCT_LICENSE?=Community Engine .PHONY: help help: ## show make targets