pnagy
27e8bdf32b
sort secrets and configs to ensure idempotence
...
`docker stack deploy` keeps restarting services it doesn't need to (no changes)
because the entries' order gets randomized at some previous (de)serialization.
Maybe it would be worth looking into this at a higher level and ensure
all (de)serialization happens in an ordered collection.
This quick fix sorts secrets and configs (in place, mutably) which ensures the
same order for each run.
Based on
https://github.com/moby/moby/pull/30506
Fixes
https://github.com/moby/moby/issues/34746
Signed-off-by: Peter Nagy <xificurC@gmail.com >
2017-09-08 16:09:48 +02:00
Daniel Nephin
5c5cdd0e36
Merge pull request #424 from simonferquel/update-vendoring
...
updated vendoring
2017-09-05 15:06:09 -04:00
Daniel Nephin
ec99774a85
Merge pull request #406 from ksouf/issue_37_network_list_test
...
adding network list test
2017-09-05 11:24:32 -04:00
Simon Ferquel
a0113c3a44
updated vendoring
...
Signed-off-by: Simon Ferquel <simon.ferquel@docker.com >
2017-09-01 19:41:06 -04:00
French Ben
bb8f49773c
Move output of stack rm to stdout
...
Signed-off-by: French Ben <frenchben@docker.com >
Update for the test to capture the proper removal
Signed-off-by: French Ben <frenchben@docker.com >
Satisfy lint length limit
Signed-off-by: French Ben <frenchben@docker.com >
Updated e2e test
Signed-off-by: French Ben <frenchben@docker.com >
2017-09-01 14:25:20 -07:00
Daniel Nephin
d817967647
Merge pull request #489 from dnephin/fix-container-run
...
Fix crash in container run after pulling an image
2017-08-31 18:11:26 -04:00
Daniel Nephin
5a9bf7f359
Merge pull request #484 from ripcurld0/ps_exit_1
...
When nothing found in stack exit with exit code 1
2017-08-31 17:13:00 -04:00
Daniel Nephin
a0d8d80250
Fix crash in containe run after pulling an image.
...
Signed-off-by: Daniel Nephin <dnephin@docker.com >
2017-08-31 17:08:02 -04:00
Boaz Shuster
79f9af2475
When nothing found in stack exit with exit code 1
...
To keep on a consistent behaviour such as in docker-service-ps
if docker-stack-ps didn't find a given stack, the command line
should exit with exit code 1.
Signed-off-by: Boaz Shuster <ripcurld.github@gmail.com >
2017-08-30 23:25:36 +03:00
Daniel Nephin
e636a5388c
Merge pull request #475 from AliyunContainerService/start_period
...
Support start_period for healthcheck in Docker Compose
2017-08-30 14:11:43 -04:00
Victor Vieux
8ea02f6f08
Merge pull request #477 from dnephin/some-tests-for-container-command
...
A few tests for container command
2017-08-30 09:38:38 -07:00
Li Yi
e02fcfd34e
Change the type of interval, timeout and start_period of healthcheck from string to * time.Duration
...
Signed-off-by: Li Yi <denverdino@gmail.com >
2017-08-30 23:39:12 +08:00
Daniel Nephin
e7f90b6b38
Reduce complexity in cli/command/container
...
Add tests for exec and cleanup existing tests.
Signed-off-by: Daniel Nephin <dnephin@docker.com >
2017-08-29 19:25:50 -04:00
Daniel Nephin
bdc8cf364e
Add ulimits to unsupported compose fields.
...
Signed-off-by: Daniel Nephin <dnephin@docker.com >
2017-08-29 17:05:16 -04:00
Daniel Nephin
dae1b7112c
Remove test for code not in this repo.
...
Signed-off-by: Daniel Nephin <dnephin@docker.com >
2017-08-29 13:19:28 -04:00
khaled souf
15d92a9e03
adding network list test
...
Signed-off-by: khaled souf <khaled.souf@gmail.com >
2017-08-29 16:30:37 +02:00
Li Yi
0abdad615f
Support start_period for healthcheck in Docker Compose
...
Signed-off-by: Li Yi <denverdino@gmail.com >
2017-08-29 11:19:29 +08:00
Daniel Nephin
d318c4112b
Reduce complexity of two formatters
...
Signed-off-by: Daniel Nephin <dnephin@docker.com >
2017-08-28 12:49:07 -04:00
Vincent Demeester
7e52344cd2
Merge pull request #471 from cyli/surface-autolock
...
Include whether the managers in the swarm are autolocked as part of `docker info`
2017-08-28 17:46:09 +02:00
Ying Li
3428b78e96
Include whether the managers in the swarm are autolocked as part of docker info.
...
Signed-off-by: Ying Li <ying.li@docker.com >
2017-08-25 16:33:46 -07:00
Daniel Nephin
d83752cdf2
Merge pull request #452 from dnephin/compose-allow-x-fields
...
Allow extension fields in the v3.4 version of the compose format
2017-08-25 12:37:47 -04:00
Vincent Demeester
8ebc03a71f
Merge pull request #367 from kolyshkin/ipcmode
...
Introduce/document new IPC modes
2017-08-25 09:48:00 +02:00
Tibor Vass
6c3d93bbb6
Merge pull request #445 from dnephin/add-end-to-end-suite
...
Add end to end suite
2017-08-23 16:16:09 -07:00
Daniel Nephin
05308fcec7
Merge pull request #440 from ripcurld0/search_format
...
Add --format to docker-search
2017-08-22 19:10:53 -04:00
Victor Vieux
5e1d0289f4
Merge pull request #456 from dnephin/add-tests-for-client
...
Add unit tests for initializing the client
2017-08-22 16:08:36 -07:00
Boaz Shuster
88cc47ad5c
Add --format to docker-search
...
Signed-off-by: Jeremy Chambers <jeremy@thehipbot.com >
Signed-off-by: Boaz Shuster <ripcurld.github@gmail.com >
2017-08-23 01:37:54 +03:00
Daniel Nephin
79ecfa876b
Merge pull request #463 from dnephin/remove-pkg-testutil
...
Remove docker/docker/pkg/testutil
2017-08-22 13:53:03 -04:00
Marco Mariani
3a0b967c05
support --compose-file - as stdin
...
Signed-off-by: Marco Mariani <marco.mariani@alterway.fr >
2017-08-22 17:55:59 +02:00
Daniel Nephin
2a1857e899
Allow extension fields in the v3.4 version of the compose format.
...
Signed-off-by: Daniel Nephin <dnephin@docker.com >
2017-08-22 10:42:49 -04:00
Vincent Demeester
317b735573
Merge pull request #439 from ripcurld0/fix_image_ls_digest
...
Show images digests when "{{.Digest}}" is in format
2017-08-22 16:17:43 +02:00
Daniel Nephin
846a31aa50
Use new internal testutil.ErrorContains()
...
Signed-off-by: Daniel Nephin <dnephin@docker.com >
2017-08-22 10:14:25 -04:00
Daniel Nephin
b3f843afe2
Move internal/test package out of cli.
...
Signed-off-by: Daniel Nephin <dnephin@docker.com >
2017-08-22 10:14:25 -04:00
Boaz Shuster
83112f6343
Show images digests when "{{.Digest}}" is in format
...
This patch fixes the following bug:
Running "docker image ls --digests" will add images digests
to the image table. However, when using "format" to display
images digests all of them are "<none>".
Signed-off-by: Boaz Shuster <ripcurld.github@gmail.com >
2017-08-22 16:55:10 +03:00
Vincent Demeester
8da1daeefa
Merge pull request #386 from thaJeztah/fix-image-resolve-detection
...
Fix image resolve detection
2017-08-22 15:05:39 +02:00
Christophe Vidal
037029414d
Dropped hyphen in bind mount where appropriate
...
Signed-off-by: Christophe Vidal <kriss@krizalys.com >
2017-08-19 21:14:48 +07:00
Sebastiaan van Stijn
3c7ede6a68
Merge pull request #205 from redpanda/rollback
...
Add 'docker service rollback' subcommand
2017-08-19 15:56:14 +02:00
Daniel Nephin
930f97dd09
Add unit tests for initializing the client.
...
Signed-off-by: Daniel Nephin <dnephin@docker.com >
2017-08-18 12:49:23 -04:00
Joffrey F
1667073908
Update schemas to prevent invalid properties in deploy.resources
...
Signed-off-by: Joffrey F <joffrey@docker.com >
2017-08-17 15:58:51 -07:00
Jimmy Leger
11d471d660
Add 'docker service rollback' subcommand
...
Signed-off-by: Jimmy Leger <jimmy.leger@gmail.com >
Implement runRollback to not use runUpdate
Signed-off-by: Jimmy Leger <jimmy.leger@gmail.com >
Add version tag and add flag quiet to suppress progress output
Signed-off-by: Jimmy Leger <jimmy.leger@gmail.com >
Removed flags from warnDetachDefault
Signed-off-by: Jimmy Leger <jimmy.leger@gmail.com >
Used command.Cli interface
Signed-off-by: Jimmy Leger <jimmy.leger@gmail.com >
Add detach flag on rollback command
Signed-off-by: Jimmy Leger <jimmy.leger@gmail.com >
Create a fakeClient for service commands
Signed-off-by: Jimmy Leger <jimmy.leger@gmail.com >
Added unit test for rollback command
Signed-off-by: Jimmy Leger <jimmy.leger@gmail.com >
Used command.Cli interface instead of *command.DockerCli in service commands
Signed-off-by: Jimmy Leger <jimmy.leger@gmail.com >
Revert "Removed flags from warnDetachDefault"
This reverts commit 3e4f601c8a82cc2599a755dc693409bbc47917fc.
Signed-off-by: Jimmy Leger <jimmy.leger@gmail.com >
Fixed test.NewFakeCli instanciation
Signed-off-by: Jimmy Leger <jimmy.leger@gmail.com >
Removed unused receiver
Signed-off-by: Jimmy Leger <jimmy.leger@gmail.com >
Replaced cli by dockerCli
Signed-off-by: Jimmy Leger <jimmy.leger@gmail.com >
Revert "Removed unused receiver"
This reverts commit 604ef7c13df3d019949ca81d992db501114dafce.
Signed-off-by: Jimmy Leger <jimmy.leger@gmail.com >
Fixed last typo
Signed-off-by: Jimmy Leger <jimmy.leger@gmail.com >
2017-08-16 22:18:36 +02:00
Daniel Nephin
15837afa77
Replace pkg/testutil/tempfile with gotestyourself/fs
...
Signed-off-by: Daniel Nephin <dnephin@docker.com >
2017-08-16 14:23:28 -04:00
Daniel Nephin
505a0fe45f
Update volume command tests to use the new golden
...
Signed-off-by: Daniel Nephin <dnephin@docker.com >
2017-08-16 14:23:28 -04:00
Daniel Nephin
3d68aa8416
Update swarm command tests to use the new golden
...
Signed-off-by: Daniel Nephin <dnephin@docker.com >
2017-08-16 14:23:28 -04:00
Daniel Nephin
1dd742eac8
Update stack and task command tests to new golden
...
Signed-off-by: Daniel Nephin <dnephin@docker.com >
2017-08-16 14:23:28 -04:00
Daniel Nephin
4c62d7288f
Update service and secret command tests to new golden
...
Signed-off-by: Daniel Nephin <dnephin@docker.com >
2017-08-16 14:23:28 -04:00
Daniel Nephin
0e2bf7420a
Update node command tests to the new golden
...
Also remove some superfluous tests that are now covered by a strict golden.Assert
Signed-off-by: Daniel Nephin <dnephin@docker.com >
2017-08-16 14:23:15 -04:00
Daniel Nephin
75f7bfedf8
Update image command tests to use the new golden
...
Signed-off-by: Daniel Nephin <dnephin@docker.com >
2017-08-16 14:20:36 -04:00
Daniel Nephin
f9007ad7db
Update config and checkpoint commands to use gotestyourself/golden
...
Signed-off-by: Daniel Nephin <dnephin@docker.com >
2017-08-16 14:19:00 -04:00
Daniel Nephin
b5cb5ee446
Add first e2e test
...
Signed-off-by: Daniel Nephin <dnephin@docker.com >
2017-08-16 10:46:40 -04:00
Sebastiaan van Stijn
04659b8802
Merge pull request #430 from dnephin/add-build-target-to-compose
...
Add network and target to build in v3.4
2017-08-15 19:20:49 +02:00
Daniel Nephin
3b8cf20a0c
Merge pull request #436 from thaJeztah/improve-singular-plural-message
...
Singularize / pluralize "argument(s)" in error message
2017-08-14 11:06:25 -04:00