Vincent Demeester
9faf728089
Merge pull request #1155 from adshmh/add-unit-tests-to-plugin-list
...
added unit tests to cover plugin list command
2018-06-29 15:49:30 +02:00
Sebastiaan van Stijn
7c7c299eee
Merge pull request #1152 from vdemeester/extract-converter
...
Extract StackConverter from the StackClient
2018-06-29 13:36:55 +02:00
Derek McGowan
1fd2d66df8
Fix manifest lists to always use correct size
...
Stores complete OCI descriptor instead of digest and platform
fields. This includes the size which was getting lost by not
storing the original manifest bytes.
Attempt to support existing cached files, if not output
the filename with the incorrect content.
Signed-off-by: Derek McGowan <derek@mcgstyle.net >
2018-06-28 18:17:38 -07:00
Arash Deshmeh
c26121df5c
added unit tests to cover plugin list command
...
Signed-off-by: Arash Deshmeh <adeshmeh@ca.ibm.com >
2018-06-28 16:51:54 -04:00
Arash Deshmeh
bc9b42ea9b
added unit tests covering content trust for plugin install command
...
Signed-off-by: Arash Deshmeh <adeshmeh@ca.ibm.com >
2018-06-27 22:16:19 -04:00
Vincent Demeester
f2e6ee6899
Extract StackConverter from the StackClient
...
It makes it easier to get the correct stack from a compose config
struct without requiring the client (and thus talking to k8s API)
Signed-off-by: Vincent Demeester <vincent@sbr.pm >
2018-06-27 16:41:00 +02:00
Vincent Demeester
0f9d24f78d
Refactor stack command/package
...
- Handle `bundlefile` directly in the `top-level`
command. `bundlefile` is still experimental and will be deprecated
in future version — this should make be easier to remove it.
- Validate the `stack` name in all cases (i.e. whatever the
orchestrator is used)
- Load the composefile ahead of choosing the orchestrator. This
removes some slight duplication.
- Makes `RunDeploy` easier to use from outside packages (like
`docker/app`) with a preloaded configuration.
Signed-off-by: Vincent Demeester <vincent@sbr.pm >
2018-06-26 14:07:26 +02:00
Sebastiaan van Stijn
61e53fc88a
Merge pull request #1138 from seemethere/env_experimental
...
Add env variable option for experimental
2018-06-25 14:47:16 +02:00
Eli Uriegas
e3bb62ed51
Add env variable option for experimental
...
Signed-off-by: Eli Uriegas <eli.uriegas@docker.com >
2018-06-24 21:15:02 +00:00
Arash Deshmeh
d469cbdd14
fixed output leak from TestRunCommandWithContentTrustErrors unit tests
...
Signed-off-by: Arash Deshmeh <adeshmeh@ca.ibm.com >
2018-06-23 10:27:27 -04:00
Silvin Lubecki
e8c87f7cb3
Warn if DOCKER_ORCHESTRATOR is still used but not DOCKER_STACK_ORCHESTRATOR
...
Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com >
Signed-off-by: Sebastiaan van Stijn <github@gone.nl >
2018-06-22 13:58:39 -07:00
Sebastiaan van Stijn
e02c28f40a
Remove duplicated getOrchestrator(), and rename hideFlag()
...
Signed-off-by: Sebastiaan van Stijn <github@gone.nl >
2018-06-22 13:58:14 -07:00
Sebastiaan van Stijn
f0a8598b8d
Remove shorthand -k option from docker version
...
The `-k` shorthand was alreaady removed from other
commands, so best to be consistent.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl >
2018-06-21 23:33:55 -07:00
Sebastiaan van Stijn
0f07b9ffc7
Update command usage and documentation
...
Signed-off-by: Sebastiaan van Stijn <github@gone.nl >
2018-06-21 23:16:27 -07:00
Sebastiaan van Stijn
a63252ba71
Remove "Stack Orchestrator" from "docker version"
...
The output of this information can be confusing,
so removing until we have a better design for this.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl >
2018-06-21 22:02:11 -07:00
Silvin Lubecki
71272dd203
Scope orchestration selection to stack commands only
...
* Renaming DOCKER_ORCHESTRATOR to DOCKER_STACK_ORCHESTRATOR
* Renaming config file option "orchestrator" to "stackOrchestrator"
* "--orchestrator" flag is no more global but local to stack command and subcommands
* Cleaning all global orchestrator code
* Replicating Hidden flags in help and Supported flags from root command to stack command
Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com >
2018-06-21 17:12:31 -07:00
Sebastiaan van Stijn
8de0753869
Merge pull request #1112 from n4ss/fix-trust-signer-remove
...
Fix docker trust signer removal
2018-06-15 08:18:29 -07:00
Silvin
805b34127a
Merge pull request #1124 from vdemeester/using-cli-interface-everywhere-possible
...
Use command.Cli interface instead of concrete type…
2018-06-14 16:43:15 +02:00
Vincent Demeester
88068b9dd7
Use command.Cli interface instead of concrete type…
...
… wherever it's possible. Should make it even easier to test and use
another implementation.
Signed-off-by: Vincent Demeester <vincent@sbr.pm >
2018-06-14 16:26:47 +02:00
Vincent Demeester
e43c7920ea
Export Push and Save
...
As we did for `Pull`, it will be helpful to expose the push and save
implementation.
Signed-off-by: Vincent Demeester <vincent@sbr.pm >
2018-06-14 15:48:21 +02:00
Vincent Demeester
70db8dee74
Merge pull request #479 from Tim15/init-option
...
Add --init option to `docker service create`
2018-06-14 13:58:52 +02:00
Vincent Demeester
ff13f03def
Add --init option to docker service create
...
Signed-off-by: Timothy Higinbottom <timhigins@gmail.com >
Signed-off-by: Vincent Demeester <vincent@sbr.pm >
2018-06-14 13:50:12 +02:00
Andrew Hsu
2daec78609
Merge pull request #1111 from tiborvass/experimental-buildkit
...
Support for experimental BuildKit
2018-06-13 18:21:41 -07:00
Tibor Vass
b3a5c153d5
build: address some review nits
...
Signed-off-by: Tibor Vass <tibor@docker.com >
2018-06-13 22:40:31 +00:00
Tibor Vass
5a103e1844
build: change --no-console to --console=[true|false|auto]
...
Signed-off-by: Tibor Vass <tibor@docker.com >
2018-06-13 21:07:11 +00:00
Tibor Vass
00792d1704
build: ensure temporary folder is removed in error case
...
Signed-off-by: Tibor Vass <tibor@docker.com >
2018-06-13 18:32:29 +00:00
Tibor Vass
aef42093b8
build: skip moby.buildkit.trace Aux message to be future proof
...
Signed-off-by: Tibor Vass <tibor@docker.com >
2018-06-13 18:32:28 +00:00
Tibor Vass
5919e8a30f
build: fix lint issues + refactor
...
Signed-off-by: Tibor Vass <tibor@docker.com >
2018-06-13 18:32:28 +00:00
Tibor Vass
15674d9ee9
build: simplify Close logic in WriteTempDockerfile
...
Signed-off-by: Tibor Vass <tibor@docker.com >
2018-06-13 18:32:28 +00:00
Tibor Vass
ed75f6202b
build: add experimental --no-console flag to support non-tty human-readable output with buildkit
...
Unfortunately, this is for now the only way to see the output of RUN commands when using buildkit.
It is equivalent to `DOCKER_BUILDKIT=1 docker build . 2>&1 | cat`
Signed-off-by: Tibor Vass <tibor@docker.com >
2018-06-13 18:32:28 +00:00
Tibor Vass
584d59d8f5
formatter: fix TestDiskUsageContextFormatWrite expected output
...
Signed-off-by: Tibor Vass <tibor@docker.com >
2018-06-13 18:32:28 +00:00
Tibor Vass
b2b3f9c461
build: setting DOCKER_BUILDKIT environment variable to any non-empty string enables the use of buildkit
...
Signed-off-by: Tibor Vass <tibor@docker.com >
2018-06-13 18:32:28 +00:00
Tibor Vass
640cbb8d2f
build: fix output handling with buildkit (quiet option, redirects)
...
With this patch the following become true even with buildkit enabled:
1. `docker build -q .` only outputs the created image's sha256 ID.
2. `docker build -q .` outputs as if no `-q` was specified, if error occurred
3. `docker build . &> out` outputs JSON (instead of TTY characters)
Signed-off-by: Tibor Vass <tibor@docker.com >
2018-06-13 18:32:28 +00:00
Tibor Vass
82f0e1e5d8
build: fix -f handling with buildkit
...
This commit brings a more pedantic change in the following ambiguous case:
cat Dockerfile | docker build -f otherDockerfile -
The legacy builder does not error out and prefers the Dockerfile from stdin
while the buildkit-based one errors out.
Note that this is only in the case where stdin is a Dockerfile (not an archive)
Signed-off-by: Tibor Vass <tibor@docker.com >
2018-06-13 18:32:28 +00:00
Silvin
4cb3c70f36
Merge pull request #1121 from vdemeester/gotestyourself-with-tools
...
Update gotestyourself to gotest.tools
2018-06-11 14:49:20 +02:00
Tibor Vass
89e102474c
build: error out if buildkit is on and stdin is used for both dockerfile and context
...
Signed-off-by: Tibor Vass <tibor@docker.com >
2018-06-09 20:51:34 +00:00
Tibor Vass
5314a8fc06
build: Add support for using dockerfile from stdin with buildkit
...
Signed-off-by: Tibor Vass <tibor@docker.com >
2018-06-09 20:51:34 +00:00
Tibor Vass
e0b3921a03
build: Add support for using context from stdin with buildkit
...
Signed-off-by: Tibor Vass <tibor@docker.com >
2018-06-09 20:51:34 +00:00
Tonis Tiigi
8cf213bd0c
build: use a separate upload request for early progress
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com >
2018-06-09 20:51:34 +00:00
Tonis Tiigi
b19294ee42
system: add buildcache formatting
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com >
2018-06-09 20:51:34 +00:00
Tonis Tiigi
0f97642915
build: basic buildkit progress support
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com >
2018-06-09 20:51:34 +00:00
Tonis Tiigi
656fe85c74
build: add experimental buildkit base
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com >
2018-06-09 20:51:30 +00:00
Nassim 'Nass' Eddequiouaq
92c39dd0ab
Fix removeSingleSigner description
...
Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com >
2018-06-09 08:14:34 -07:00
Vincent Demeester
2c4de4fb5e
Update tests to use gotest.tools 👼
...
Signed-off-by: Vincent Demeester <vincent@sbr.pm >
2018-06-08 18:24:26 +02:00
Nassim 'Nass' Eddequiouaq
2b3361cc1a
Move the successful removal print
...
Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com >
2018-06-08 09:21:36 -07:00
Vincent Demeester
b1065767cd
Bump moby version (and its dependencies)
...
Signed-off-by: Vincent Demeester <vincent@sbr.pm >
2018-06-08 11:26:10 +02:00
Nassim 'Nass' Eddequiouaq
5ebb7a65ab
Fix tests and nit
...
Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com >
2018-06-06 07:25:25 -07:00
Nassim 'Nass' Eddequiouaq
448082f333
Fix docker trust signer removal
...
Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com >
2018-06-05 16:04:41 -07:00
Vincent Demeester
eaa9149e29
Merge pull request #948 from simonferquel/k8s-watch-stack-status
...
K8s: more robust stack error detection on deploy
2018-06-04 10:42:42 +02:00
Vincent Demeester
d1cc8c731e
Merge pull request #1105 from vdemeester/1044-compress-stream-friend
...
Fix panics when --compress and --stream are used together
2018-06-01 23:00:01 +02:00