toolshed/docker-cli
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
11,302 Commits 3 Branches 295 Tags
e0f4bc699cbef4065df2ba8fa4a52d8b372b20f2
Commit Graph
11302 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Paweł Gronowski 1a950db5ce cli/command/image: Fix total content size calculation in image tree 
Before this patch, image total content size would only include
container images content size.

Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
 2025-04-11 13:30:20 +02:00
Sebastiaan van Stijn e2865628ae Merge pull request #5983 from thaJeztah/fix_context_non_default 
cli/command: DockerCli.Initialize: make sure context-store config is set
 2025-04-11 12:46:15 +02:00
Sebastiaan van Stijn e578f156c0 Merge pull request #5998 from thaJeztah/lazy_regexp 
use lazyregexp to compile regexes on first use
 2025-04-11 12:29:53 +02:00
Sebastiaan van Stijn b74b7b3c40 internal/prompt: TestConfirm: don't use un-keyed structs 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2025-04-11 12:23:24 +02:00
Sebastiaan van Stijn ecde8c38a5 internal/prompt: skip fmt.Printf and use writer directly 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2025-04-11 12:23:21 +02:00
Sebastiaan van Stijn b37d84fd10 cli/command: move prompt utilities to separate package 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2025-04-11 12:23:16 +02:00
Sebastiaan van Stijn af85e1e2f7 cli/command: implement ErrPromptTerminated without errdefs package 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2025-04-11 12:15:11 +02:00
Sebastiaan van Stijn 8633197105 Merge pull request #5914 from thaJeztah/use_atomicwriter 
cli/command: deprecate CopyToFile and reimplement with atomicwriter
 2025-04-11 12:10:46 +02:00
Sebastiaan van Stijn 94afbc1116 Merge pull request #5999 from thaJeztah/bump_engine 
vendor: github.com/docker/docker 511cd1c0a736 (master, v28.x-dev)
 2025-04-11 12:09:28 +02:00
Sebastiaan van Stijn 4530417f6b vendor: github.com/docker/docker 511cd1c0a736 (master, v28.x-dev) 
full diff: https://github.com/docker/docker/compare/185651d26bc6...511cd1c0a7369a47f10d4435184b8668623eadea

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2025-04-10 22:03:48 +02:00
Sebastiaan van Stijn 23d7346f75 Merge pull request #5977 from thaJeztah/deprecate_config_experimental 
cli/config/configfile: deprecate ConfigFile.Experimental field
 2025-04-10 14:36:11 +02:00
Sebastiaan van Stijn 4c820d3ac0 golangci-lint: add forbidigo rules to prevent regex.MustCompile 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2025-04-10 12:22:27 +02:00
Sebastiaan van Stijn ced66f22d6 cli/compose/template: use lazyregexp to compile regexes on first use 
This package needed an (internal) interface to abstract the lazy-regexp.
For this, I split the implementation from the exported implementation; this
also revealed that some functions are not used (at least not in our code
base), and we could consider deprecating these.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2025-04-10 12:22:26 +02:00
Sebastiaan van Stijn 0b0fc106dc cli/compose/template: rename vars that shadowed 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2025-04-10 12:22:26 +02:00
Sebastiaan van Stijn 56c2fa6c0e e2e/cli-plugins: use regexp.Compile to prevent panic in tests 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2025-04-10 12:22:26 +02:00
Sebastiaan van Stijn 1ed3859879 cli-plugins/manager: use lazyregexp to compile regexes on first use 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2025-04-10 12:22:26 +02:00
Sebastiaan van Stijn 7fde1f799f cli/context/store: use lazyregexp to compile regexes on first use 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2025-04-10 12:22:25 +02:00
Sebastiaan van Stijn d5a8cd4093 cli/command/trust: use lazyregexp to compile regexes on first use 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2025-04-10 12:22:25 +02:00
Sebastiaan van Stijn 01d8642c7e cli/command/system: use lazyregexp to compile regexes on first use 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2025-04-10 12:22:25 +02:00
Sebastiaan van Stijn a16c3a49c8 cli/command/image: use lazyregexp to compile regexes on first use 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2025-04-10 12:22:25 +02:00
Sebastiaan van Stijn d76057210a cli/command/container: use lazyregexp to compile regexes on first use 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2025-04-10 12:22:25 +02:00
Sebastiaan van Stijn 9a849ba00c opts: use lazyregexp to compile regexes on first use 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2025-04-10 12:22:24 +02:00
Sebastiaan van Stijn 481e6f1477 implement lazyregexp package 
Based on the "lazyregexp" package in golang.org/x/mod;
https://cs.opensource.google/go/x/mod/+/refs/tags/v0.19.0:internal/lazyregexp/lazyre.go;l=66-78

This package allows defining regular expressions that should not be
compiled until used, but still providing validation to prevent
invalid regular expressions from producing a panic at runtime.

This is largely a copy of the package from golang.org/x/mod,
with FindAllStringSubmatch and ReplaceAllStringFunc added

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2025-04-10 12:22:24 +02:00
Paweł Gronowski 6c2d023d87 swarm/init: Fix --external-ca ignoring cacert option 
31d6292458 mistakenly changed the `ToSpec`
function to set all certs passed via `external-ca` to empty strings.

Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
 2025-04-10 11:41:13 +02:00
Paweł Gronowski bcd9c885e3 Merge pull request #5997 from thaJeztah/fastpath_needs_serverinfo 
cli/command/system: needsServerInfo: add fast-paths
 2025-04-10 09:24:06 +00:00
Paweł Gronowski e587e8a269 Merge pull request #5996 from thaJeztah/bump_x_deps 
vendor: update golang.org/x/.. dependencies
 2025-04-10 09:23:17 +00:00
Sebastiaan van Stijn 932574363f cli/command/system: needsServerInfo: add fast-paths 
We can return early without executing the regular expression or evaluating
the template for `--format=json` or `--format='{{json .}}'`.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2025-04-10 10:50:04 +02:00
Sebastiaan van Stijn ac375caa87 Merge pull request #5918 from Benehiko/info-exit-code 
system/info: failure to connect to docker socket should propagate error
 2025-04-10 10:31:05 +02:00
Sebastiaan van Stijn 7cc6b8ebf4 cli/command: deprecate CopyToFile and reimplement with atomicwriter 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2025-04-10 09:46:06 +02:00
Sebastiaan van Stijn b8bcf6f5ad container export: implement file-write with atomicwriter 
Same functionality, but implemented with atomicwriter. There's a slight
difference in error-messages produced (but can be adjusted if we want).

Before:

    docker container export -o ./no/such/foo mycontainer
    failed to export container: invalid output path: directory "no/such" does not exist

    docker container export -o /no/permissions mycontainer
    failed to export container: stat /no/permissions: permission denied

After:

    docker container export -o ./no/such/foo mycontainer
    failed to export container: invalid file path: stat no/such: no such file or directory

    docker container export -o /no/permissions mycontainer
    failed to export container: failed to stat output path: lstat /no/permissions: permission denied

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2025-04-10 09:46:06 +02:00
Sebastiaan van Stijn d47d2338b7 image save: implement file-write with atomicwriter 
Same functionality, but implemented with atomicwriter. There's a slight
difference in error-messages produced (but can be adjusted if we want).

Before:

    docker image save -o ./no/such/foo busybox:latest
    failed to save image: invalid output path: directory "no/such" does not exist

    docker image save -o /no/permissions busybox:latest
    failed to save image: stat /no/permissions: permission denied

After:

    docker image save -o ./no/such/foo busybox:latest
    failed to save image: invalid file path: stat no/such: no such file or directory

    docker image save -o /no/permissions busybox:latest
    failed to save image: failed to stat output path: lstat /no/permissions: permission denied

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2025-04-10 09:46:05 +02:00
Sebastiaan van Stijn 410c0baadd Merge pull request #5992 from thaJeztah/migrate_archive 
migrate to use github.com/moby/go-archive
 2025-04-10 09:10:41 +02:00
Sebastiaan van Stijn d83a1b777c vendor: golang.org/x/net v0.39.0 
full diff: https://github.com/golang/net/compare/v0.36.0...v0.39.0

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2025-04-10 00:01:30 +02:00
Sebastiaan van Stijn b515831508 vendor: golang.org/x/crypto v0.37.0 
full diff: https://github.com/golang/crypto/compare/v0.35.0...v0.37.0

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2025-04-10 00:00:46 +02:00
Sebastiaan van Stijn 2d3a81642a vendor: golang.org/x/text v0.24.0 
no changes in vendored files

full diff: https://github.com/golang/text/compare/v0.22.0...v0.24.0

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2025-04-09 23:59:55 +02:00
Sebastiaan van Stijn 69d903e706 vendor: golang.org/x/sync v0.13.0 
full diff: https://github.com/golang/sync/compare/v0.11.0...v0.13.0

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2025-04-09 23:59:03 +02:00
Sebastiaan van Stijn e0fa0596a7 vendor: golang.org/x/time v0.11.0 
full diff: https://github.com/golang/time/compare/v0.6.0...v0.11.0

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2025-04-09 23:58:09 +02:00
Sebastiaan van Stijn a91d194d7f vendor: golang.org/x/sys v0.32.0 
full diff: https://github.com/golang/sys/compare/v0.31.0...v0.32.0

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2025-04-09 23:57:22 +02:00
Paweł Gronowski a0385bf042 swarm/init: Test init --external-ca with custom cert 
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
 2025-04-09 16:56:26 +02:00
Sebastiaan van Stijn 342a01a9ff migrate to use github.com/moby/go-archive 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2025-04-09 13:18:58 +02:00
Sebastiaan van Stijn 6714b50288 Merge pull request #5921 from thaJeztah/bump_engine 
vendor: github.com/docker/docker 185651d26bc6 (master, v28.0-dev)
 2025-04-09 13:12:32 +02:00
Sebastiaan van Stijn 2bf317ad5f vendor: github.com/docker/docker 185651d26bc6 (master, v28.0-dev) 
full diff: https://github.com/moby/moby/compare/v28.0.4...185651d26bc6281b199a5b7ff1942b53e4f17b96

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

vendor: moby with atomicwriter

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2025-04-07 19:20:39 +02:00
Sebastiaan van Stijn 91cbde67c5 Merge pull request #5991 from thaJeztah/bump_x_sys 
vendor: golang.org/x/sys v0.31.0
 2025-04-07 16:02:14 +02:00
Sebastiaan van Stijn 49a36daebe vendor: golang.org/x/sys v0.31.0 
no changes in vendored code

full diff: https://github.com/golang/sys/compare/v0.30.0...v0.31.0

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2025-04-07 13:57:55 +02:00
Sebastiaan van Stijn 90b48f8eb5 Merge pull request #5988 from thaJeztah/bump_sys_user_0.4.0 
vendor: github.com/moby/sys/user v0.4.0
 2025-04-07 09:37:14 +02:00
Sebastiaan van Stijn 763be9b3f8 Merge pull request #5990 from thaJeztah/bump_compress 
vendor: github.com/klauspost/compress v1.18.0
 2025-04-07 09:36:52 +02:00
Sebastiaan van Stijn 527998e6ee Merge pull request #5989 from thaJeztah/bump_go_cmp 
vendor: github.com/google/go-cmp v0.7.0
 2025-04-07 09:36:33 +02:00
Sebastiaan van Stijn 77f40b8e99 vendor: github.com/klauspost/compress v1.18.0 
full diff: https://github.com/klauspost/compress/compare/v1.17.11...v1.18.0

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2025-04-05 16:40:12 +02:00
Sebastiaan van Stijn 205241bcc6 vendor: github.com/google/go-cmp v0.7.0 
full diff: https://github.com/google/go-cmp/v0.6.0...v0.7.0

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2025-04-05 16:38:43 +02:00
Sebastiaan van Stijn edd2f7d9fb vendor: github.com/moby/sys/user v0.4.0 
full diff: https://github.com/moby/sys/compare/user/v0.3.0...user/v0.4.0

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2025-04-04 22:01:29 +02:00