aab947de8f
cli/config/types: update deprecation comment for AuthConfig.Email
...
Relates to [cli@27b2797], which forked this type from the Moby API, and
[moby@6cfff7e], which made the same change on the API side.
The Email field was originally used to create a new Docker Hub account
through the `docker login` command. The `docker login` command could be
used both to log in to an existing account (providing only username and
password), or to create a new account (providing desired username and
password, and an e-mail address to use for the new account).
This functionality was confusing, because it was implemented when Docker
Hub was the only registry, but the same functionality could not be used
for other registries. This functionality was removed in Docker 1.11 (API
version 1.23) through [moby@aee260d], which also removed the Email field
([engine-api@9a9e468]) as it was no longer used.
However, this caused issues when using a new CLI connecting with an old
daemon, as the field would no longer be serialized, and the deprecation
may not yet be picked up by custom registries, so [engine-api@167efc7]
added the field back, deprecated it, and added an "omitempty". There
was no official "deprecated" format yet at the time, so let's make sure
the deprecation follows the proper format to make sure it gets noticed.
[cli@27b2797]: https://github.com/docker/cli/commit/27b2797f7deb3ca5b7f80371d825113deb1faca1
[moby@6cfff7e]: https://github.com/moby/moby/commit/6cfff7e8803a71b4acb74768b5121e7d17a9e098
[moby@aee260d]: https://github.com/moby/moby/commit/aee260d4eb3aa0fc86ee5038010b7bbc24512ae5
[engine-api@9a9e468]: https://github.com/docker-archive-public/docker.engine-api/commit/9a9e468f503eb731d6fdc9d7f98c122e1b397c86
[engine-api@167efc7]: https://github.com/docker-archive-public/docker.engine-api/commit/167efc72bb24d7ad2bcc91760a9a5d37572e104f
Signed-off-by: Sebastiaan van Stijn <github@gone.nl >
2025-08-25 15:44:04 +02:00
5ab12e6262
Merge pull request #6365 from thaJeztah/fix_version_annotations
...
cli/command/service: fix API annotations for generic resource flags
2025-08-25 13:33:12 +02:00
104b07647f
Merge pull request #6363 from thaJeztah/image_push_cleanups
...
cli/command/image: runPush: minor cleanups and linting issues
2025-08-25 11:47:21 +02:00
27734fdf4d
Merge pull request #6349 from thaJeztah/rm_RegistryAuthenticationPrivilegedFunc
...
cli/command: remove deprecated RegistryAuthenticationPrivilegedFunc
2025-08-25 11:00:30 +02:00
dcc3d25dc2
cli/command/service: fix API annotations for generic resource flags
...
These flags were added in 20a6ff32eegithub@gone.nl >
2025-08-25 10:59:47 +02:00
c36e67d7b6
cli/command/image: runPush: minor cleanups and linting issues
...
- Remove redundant intermediate variables
- Explicitly use an early return on error instead of combining with
other checks.
- Fix unhandled errors and combine defers
- Remove outstanding TODO that unlikely will be addressed
Signed-off-by: Sebastiaan van Stijn <github@gone.nl >
2025-08-24 19:38:24 +02:00
4f944e245b
cli/command/formatter: ContainerContext.Image: explicitly strip digest
...
The `reference.TrimNamed` function strips both digests and tags; the
formatter function only wants to remove the digest, but preserve any
tags present.
Update the implementation to only trim the reference if there's a digest
present, otherwise use it as-is.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl >
2025-08-24 19:31:47 +02:00
7ac3e0e0bf
cli/command/formatter: ContainerContext.Image: use early returns
...
Signed-off-by: Sebastiaan van Stijn <github@gone.nl >
2025-08-24 19:31:47 +02:00
0e7d422e5f
cli/command/formatter: TestContainerPsContext: add test-cases
...
Signed-off-by: Sebastiaan van Stijn <github@gone.nl >
2025-08-24 19:31:46 +02:00
7cb8147e77
cli/trust: GetNotaryRepository: inline variables
...
Signed-off-by: Sebastiaan van Stijn <github@gone.nl >
2025-08-24 16:01:08 +02:00
35a41c39a4
cli/trust: check for Digested, Tagged reference instead of Canonical
...
The [Canonical] interface defines images that are both [Named] and
[Digested], but in all places where it was used, we were only interested
whether the reference contained a digest. Similarly [NamedTagged] is
a superset of [Tagged], so checking for [Tagged] is sufficient if we're
already dealing with a [Named] reference.
This patch changes those checks to check for [Digested] and [Tagged]
references, as that's what's relevant for these checks.
[Named]: https://pkg.go.dev/github.com/distribution/reference#Named
[NamedTagged]: https://pkg.go.dev/github.com/distribution/reference#NamedTagged
[Canonical]: https://pkg.go.dev/github.com/distribution/reference#Canonical
[Digested]: https://pkg.go.dev/github.com/distribution/reference#Digested
Signed-off-by: Sebastiaan van Stijn <github@gone.nl >
2025-08-24 16:00:54 +02:00
abe4aa7893
Merge pull request #6360 from hsnabszhdn/add-missing-backticks
...
docs: add missing backticks in 'run.md'
2025-08-23 14:14:58 +02:00
08f876d6e8
Merge pull request #6359 from hsnabszhdn/fix-sentence-structures-in-run-md
...
docs: fix sentence structures in 'run.md'
2025-08-23 14:14:24 +02:00
0f875ba9ad
Merge pull request #6351 from thaJeztah/avoid_shadowing
...
cli/command: rename vars for consistency and prevent shadowing
2025-08-23 02:56:49 -07:00
d9cafa759f
docs: add missing backticks in 'run.md'
...
Signed-off-by: Hossein Abbasi <16090309+hsnabszhdn@users.noreply.github.com >
2025-08-23 16:14:53 +10:00
ba2c1c94ab
docs: fix sentence structures in 'run.md'
...
Signed-off-by: Hossein Abbasi <16090309+hsnabszhdn@users.noreply.github.com >
2025-08-23 15:54:56 +10:00
7ad113ccc2
cli/command/image: deprecate AuthResolver and un-export
...
This function was exported to share it between "trust" and "image",
but was only a shallow wrapper, so split the implementations where
used.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl >
2025-08-23 03:46:14 +02:00
9216f04eb6
cli/command/image: remove exported RunPull, PullOptions
...
These were exported in 812f113685github@gone.nl >
2025-08-23 03:35:51 +02:00
9fd71c8347
cli/command: rename vars for consistency and prevent shadowing
...
Signed-off-by: Sebastiaan van Stijn <github@gone.nl >
2025-08-23 03:04:36 +02:00
045ac0b159
internal/jsonstream: remove uses of deprecated fields
...
Signed-off-by: Sebastiaan van Stijn <github@gone.nl >
2025-08-23 02:17:20 +02:00
03da6ad2d1
cli/command: remove deprecated RegistryAuthenticationPrivilegedFunc
...
This function was deprecated in 29263e865bgithub@gone.nl >
2025-08-23 00:41:07 +02:00
1df8feb2e4
Merge pull request #6345 from thaJeztah/bump_x_sync
...
vendor: golang.org/x/sync v0.16.0
2025-08-22 21:05:54 +02:00
c7cbac58b3
vendor: golang.org/x/sync v0.16.0
...
Brings in the errgroup implementation for reverted auto-recover from panics.
full diff: https://github.com/golang/sync/compare/v0.14.0...v0.16.0
Signed-off-by: Sebastiaan van Stijn <github@gone.nl >
2025-08-22 14:26:38 +02:00
e8e4588f64
Merge pull request #6344 from thaJeztah/remove_builder_newprunecommand
...
cli/command/trust: remove deprecated NewPruneCommand
2025-08-22 12:41:14 +02:00
d317bc30be
cli/command/trust: remove deprecated NewPruneCommand
...
These were deprecated in 7032f5922egithub@gone.nl >
2025-08-22 12:35:36 +02:00
832a3754e5
Merge pull request #6342 from thaJeztah/deprecate_builder_NewPruneCommand
...
cli/command/builder: deprecate NewPruneCommand
2025-08-22 12:35:08 +02:00
4d4533abaa
Merge pull request #6338 from thaJeztah/cleanup_formatters
...
cli/command: inline vars and use struct literals in formatting functions
2025-08-22 12:25:14 +02:00
7032f5922e
cli/command/builder: deprecate NewPruneCommand
...
This patch deprecates exported NewPruneCommand and moves the
implementation details to an unexported function.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl >
2025-08-22 12:18:27 +02:00
2966159873
Merge pull request #6339 from thaJeztah/rm_deprecated_formatting
...
cli/command/*: remove deprecated formatting-related functions and types
2025-08-22 12:10:26 +02:00
65e7ece518
Merge pull request #6337 from thaJeztah/pretty_io
...
cli/command/system: prettyPrintVersion: accept a plain io.Writer
2025-08-22 11:31:33 +02:00
5bb8ab4e6f
cli/command/trust: remove deprecated formatting functions
...
These were deprecated in 95c9b1b13bgithub@gone.nl >
2025-08-22 09:43:27 +02:00
8969b57500
cli/command/task: remove deprecated formatting functions
...
These were deprecated in c3ee82fdc3github@gone.nl >
2025-08-22 09:42:53 +02:00
c6f4573153
cli/command/service: remove deprecated formatting functions
...
These were deprecated in 9f453d3feagithub@gone.nl >
2025-08-22 09:42:24 +02:00
04bcae3a8c
cli/command/secret: remove deprecated formatting functions
...
These were deprecated in f3088e37a0github@gone.nl >
2025-08-22 09:41:52 +02:00
c592932f47
cli/command/registry: remove deprecated formatting functions
...
These were deprecated in 83371c2014github@gone.nl >
2025-08-22 09:41:11 +02:00
264080d2fc
cli/command/plugin: remove deprecated formatting functions
...
These were deprecated in bf47419852github@gone.nl >
2025-08-22 09:40:43 +02:00
e5a0fb09a3
cli/command/node: remove deprecated formatting functions
...
These were deprecated in 123ef81f7dgithub@gone.nl >
2025-08-22 09:40:09 +02:00
7b172fcf53
cli/command/network: remove deprecated formatting functions
...
These were deprecated in e3903a1ac8github@gone.nl >
2025-08-22 09:39:35 +02:00
d223ec3b56
cli/command/image: remove deprecated formatting functions
...
These were deprecated in 15cf4fa912github@gone.nl >
2025-08-22 09:38:56 +02:00
206a8da307
cli/command/container: remove deprecated formatting functions
...
These were deprecated in 907507e22afdc90caeeegithub@gone.nl >
2025-08-22 09:38:09 +02:00
f969adf63f
cli/command/config: remove deprecated formatting functions
...
These were deprecated in e626f778ecgithub@gone.nl >
2025-08-22 09:36:11 +02:00
e416418e70
cli/command/checkpoint: remove deprecated formatting functions
...
These were deprecated in d861b78a8agithub@gone.nl >
2025-08-22 09:34:17 +02:00
efd6e7b6e0
cli/command/system: prettyPrintVersion: accept a plain io.Writer
...
We're only writing to a single stream, so may as well just let it
take an io.writer.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl >
2025-08-22 09:22:56 +02:00
f72ec26693
cli/command/trust: inline vars and use struct literals
...
Signed-off-by: Sebastiaan van Stijn <github@gone.nl >
2025-08-22 09:19:11 +02:00
6de2cdd1af
cli/command/task: inline vars and use struct literals
...
Signed-off-by: Sebastiaan van Stijn <github@gone.nl >
2025-08-22 09:19:11 +02:00
e308036440
cli/command/service: inline vars and use struct literals
...
Signed-off-by: Sebastiaan van Stijn <github@gone.nl >
2025-08-22 09:19:11 +02:00
12d30bb50c
cli/command/secret: inline vars and use struct literals
...
Signed-off-by: Sebastiaan van Stijn <github@gone.nl >
2025-08-22 09:19:11 +02:00
863b5633f3
cli/command/registry: inline vars and use struct literals
...
Signed-off-by: Sebastiaan van Stijn <github@gone.nl >
2025-08-22 09:19:11 +02:00
aa39a7e7be
cli/command/plugin: inline vars and use struct literals
...
Signed-off-by: Sebastiaan van Stijn <github@gone.nl >
2025-08-22 09:19:10 +02:00
1a433cdbdb
cli/command/node: inline vars and use struct literals
...
Signed-off-by: Sebastiaan van Stijn <github@gone.nl >
2025-08-22 09:19:10 +02:00
Sebastiaan van Stijn
Sebastiaan van Stijn
Austin Vazquez
Hossein Abbasi