toolshed/docker-cli
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity
11,468 Commits 3 Branches 295 Tags
fcfaa8daebedcd184991606ac3209d29a3fddc70
Commit Graph

2238 Commits

Author SHA1 Message Date
Sebastiaan van Stijn f367aa9330 Fix service rollback options being cross-wired 
The "update" and "rollback" configurations were cross-wired, as a result, setting
`--rollback-*` options would override the service's update-options.

Creating a service with both update, and rollback configuration:

    docker service create \
      --name=test \
      --update-failure-action=pause \
      --update-max-failure-ratio=0.6 \
      --update-monitor=3s \
      --update-order=stop-first \
      --update-parallelism=3 \
      --rollback-failure-action=continue \
      --rollback-max-failure-ratio=0.5 \
      --rollback-monitor=4s \
      --rollback-order=start-first \
      --rollback-parallelism=2 \
      --tty \
      busybox

Before this change:

    docker service inspect --format '{{json .Spec.UpdateConfig}}' test \
    && docker service inspect --format '{{json .Spec.RollbackConfig}}' test

Produces:

    {"Parallelism":3,"FailureAction":"pause","Monitor":3000000000,"MaxFailureRatio":0.6,"Order":"stop-first"}
    {"Parallelism":3,"FailureAction":"pause","Monitor":3000000000,"MaxFailureRatio":0.6,"Order":"stop-first"}

After this change:

    {"Parallelism":3,"FailureAction":"pause","Monitor":3000000000,"MaxFailureRatio":0.6,"Order":"stop-first"}
    {"Parallelism":2,"FailureAction":"continue","Monitor":4000000000,"MaxFailureRatio":0.5,"Order":"start-first"}

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2018-05-11 11:47:05 +02:00
Simon Ferquel f766aff716 Make sure every composefiles sent to a v1beta1 endpoint are parsable 
Signed-off-by: Simon Ferquel <simon.ferquel@docker.com>
 2018-05-09 13:17:25 -07:00
Mathieu Champlon 2af66bed41 Fix stack ls behaviour with Kubernetes and variout --namespace flag values 
Signed-off-by: Mathieu Champlon <mathieu.champlon@docker.com>
 2018-05-09 17:40:25 +02:00
Silvin Lubecki f097831eb3 Add --all-namespaces to docker stack ls command on Kubernetes orchestrator, to list all stacks in all namespaces. 
Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>
 2018-05-09 17:33:16 +02:00
Silvin Lubecki 65526a201f Add namespace column for docker stack ls command while targeting Kubernetes orchestrator 
Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>
 2018-05-09 17:33:16 +02:00
Silvin Lubecki 31dccfffb5 Move stack client creation from KubeCli to client factory, where it belongs 
Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>
 2018-05-09 17:30:37 +02:00
Silvin Lubecki f0aa126b03 Fix using the namespace specified in the kubeconfig file. 
Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>
 2018-05-09 17:30:36 +02:00
Justyn Temme 7d113de085 Update prune.go 
Append a warning with which filter the elements will be pruned with if filter is set.

Signed-off-by: Justyn Temme <justyntemme@gmail.com>
 2018-05-08 09:08:26 -05:00
Mathieu Champlon 698ea75c66 Use filepath.Base instead of path.Base 
This ensures Windows paths are handled correctly as explained in the path package documentation.

Signed-off-by: Mathieu Champlon <mathieu.champlon@docker.com>
 2018-05-07 17:25:23 +02:00
Vincent Demeester e9731e9d0f Merge pull request #1006 from essamhassan/908_show_secrets_configs_srv_inspect 
908 - Adding configs/secrets to service inspect pretty
 2018-05-03 10:12:51 +02:00
Sebastiaan van Stijn 784430737b Merge pull request #1026 from dhiltgen/expose_pull 
Export pull as a public function
 2018-05-02 12:07:49 +02:00
Silvin Lubecki 13d0c9c695 Add an orchestrator column in the docker stack ls command 
Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>
 2018-04-30 12:04:02 +02:00
Silvin Lubecki 36591a2282 Print warnings on stderr for each unsupported features while parsing a compose file for deployment on Kubernetes. 
Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>
 2018-04-30 11:56:14 +02:00
Silvin Lubecki f958c66a6d Add a common interface between different Kubernetes Stack API versions and use it in kubernetes stack commands 
* Add kubernetes Stack API v1beta2 client
* Upgrade v1beta1 client to remove generated code

Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>
 2018-04-30 11:27:22 +02:00
Daniel Hiltgen 812f113685 Export pull as a public function 
It will be helpful to expose the pull implementation which supports
pulling private images for other CLI commands that rely on helper images.

Signed-off-by: Daniel Hiltgen <daniel.hiltgen@docker.com>
 2018-04-27 12:21:19 -07:00
Essam A. Hassan 8238644796 testing config/secrets are showing in pretty print 
Signed-off-by: Essam A. Hassan <es.hassan187@gmail.com>
 2018-04-25 17:22:18 +02:00
Essam A. Hassan 2b1f27ea5e add config and secret to service in inspect test 
Signed-off-by: Essam A. Hassan <es.hassan187@gmail.com>
 2018-04-25 17:22:18 +02:00
Essam A. Hassan 3ae2d4b24c adding configs/secrets to service inspect pretty 
Signed-off-by: Essam A. Hassan <es.hassan187@gmail.com>
 2018-04-25 17:21:31 +02:00
Silvin Lubecki 55c5e7aa88 Cleaning some manifest documentation typos 
Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>
 2018-04-24 15:00:39 +02:00
Vincent Demeester 740d260cd2 Remove more TODOs 
- Some of them don't make sense anymore
- Some are deprecated and removed from the engine since a few versions
  already.

Signed-off-by: Vincent Demeester <vincent@sbr.pm>
 2018-04-23 14:57:29 +02:00
Vincent Demeester ae03dd7f46 Handle some TODOs in tests 
Use more gotestyourself for `env.Patch`, and `icmd.RunCommand`

Signed-off-by: Vincent Demeester <vincent@sbr.pm>
 2018-04-23 14:13:52 +02:00
Nassim 'Nass' Eddequiouaq 3acf5d2e47 Revert unencryted storage warning prompt 
Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com>
 2018-04-16 12:48:03 -07:00
Tibor Vass 6b31ea0f0d Merge pull request #963 from thaJeztah/fix-stack-deploy-after-force 
Fix stack deploy re-deploying service after --force
 2018-04-13 13:06:40 -10:00
Silvin Lubecki 54f8ca6660 Fixed gometalinter errors on test files 
Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>
 2018-04-10 16:03:56 +02:00
Bogdan Anton 9fa6bd4174 [docs] Fix typo in manifest command docs: updated MANFEST to MANIFEST. 
Signed-off-by: Bogdan Anton <contact@bogdananton.ro>
 2018-04-01 17:40:31 +03:00
Vincent Demeester eb4a4fe9b9 Merge pull request #965 from thaJeztah/fix-version-output 
Fix docker version output alignment
 2018-03-28 09:53:34 +02:00
Tonis Tiigi a1cbaa827b vendor: update moby to ed7b6428 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2018-03-27 14:11:29 -07:00
Sebastiaan van Stijn e6e47d95b5 Merge pull request #561 from tych0/deprecate-unencrypted-storage 
Deprecate unencrypted storage
 2018-03-27 14:52:03 +02:00
Sebastiaan van Stijn 236a84759a Merge pull request #941 from dnephin/fix-compose-network-name 
Fix compose network name
 2018-03-26 23:41:44 +02:00
Daniel Nephin 0f1bb35342 Refactor build tests to re-use more code and not require root 
Signed-off-by: Daniel Nephin <dnephin@docker.com>
 2018-03-26 14:27:52 -04:00
Sebastiaan van Stijn 48eb7a082d Fix docker version output alignment 
Use tabwriter to print the version output

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2018-03-26 17:59:20 +02:00
Vincent Demeester 4290df3958 print a big warning about cleartext passwords 
Signed-off-by: Tycho Andersen <tycho@docker.com>
 2018-03-26 16:18:32 +02:00
Sebastiaan van Stijn 76439457d2 Fix stack deploy re-deploying service after --force 
When updating a service with the `--force` option, the `ForceUpdate`
property of the taskspec is incremented.

Stack deploy did not take this into account, and reset this
field to its default value (0), causing the service to be
re-deployed.

This patch copies the existing value before updating the service.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2018-03-26 15:24:28 +02:00
Sebastiaan van Stijn 27f66e39f4 Merge pull request #943 from silvin-lubecki/fix-kubernetes-published-service 
Fix docker stack services command Port output
 2018-03-26 12:50:07 +01:00
Silvin Lubecki 54bb5ffeca Fix Kubernetes duplication in version command when the server already exposes one Kubernetes component 
Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>
 2018-03-23 15:52:25 +01:00
Sebastiaan van Stijn c0ffb9491c Merge pull request #924 from vdemeester/trust-suite-tests 
Add some content trust tests
 2018-03-19 11:24:00 +01:00
Vincent Demeester 8b00c5cfd8 Add more content trust tests 
Importing from moby's DockerTrustSuite tests.

Signed-off-by: Vincent Demeester <vincent@sbr.pm>
 2018-03-19 10:02:40 +01:00
Daniel Nephin db857b5d9c Post migration assertion fixes 
Signed-off-by: Daniel Nephin <dnephin@docker.com>
 2018-03-16 11:03:46 -04:00
Daniel Nephin 242f176825 Automated migration using 
gty-migrate-from-testify --ignore-build-tags

Signed-off-by: Daniel Nephin <dnephin@docker.com>
 2018-03-16 11:03:43 -04:00
Vincent Demeester 63ebcae382 Small content trust enhancement 
- `replaceDockerfileForContentTrust` is only used when content trust is
  enabled, so remove the boolean.
- rename `isContentTrustEnabled` to `contentTrustEnabled`

Signed-off-by: Vincent Demeester <vincent@sbr.pm>
 2018-03-14 17:55:19 +01:00
Silvin Lubecki b816bde6cc Fix docker stack services command on Port output when kubernetes service is a LoadBalancer or a NodePort 
* added tests on Kubernetes service conversion to swarm service

Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>
 2018-03-14 11:33:42 +01:00
Victor Vieux 176aa4865c Merge pull request #935 from n4ss/trust-out-of-experimental2 
Move Docker Trust out of experimental
 2018-03-13 16:59:50 -07:00
Daniel Nephin b4c108a385 Fix named network in compose file 
Signed-off-by: Daniel Nephin <dnephin@docker.com>
 2018-03-12 15:15:27 -04:00
Nassim 'Nass' Eddequiouaq ac35e851e8 Move Docker Trust out of experimental 
Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com>
 2018-03-09 13:29:14 -08:00
Nassim 'Nass' Eddequiouaq 8c3d0b93d6 Fix comment and misc code issues 
Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com>
 2018-03-09 20:46:37 +01:00
Nassim 'Nass' Eddequiouaq c5554f811b Refactor trust view command into a --pretty flag on trust inspect 
Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com>
 2018-03-09 19:12:11 +01:00
Daniel Nephin feae0e9756 Only read trust setting from options 
Rename IsTrusted to ContentTrustEnabled

Signed-off-by: Daniel Nephin <dnephin@docker.com>
 2018-03-08 16:46:30 -05:00
Vincent Demeester 6e21829af4 Refactor content_trust cli/flags handling 
Remove the global variable used. Allows easier unit testing.

Signed-off-by: Vincent Demeester <vincent@sbr.pm>
 2018-03-08 15:00:43 -05:00
Sebastiaan van Stijn 82f325ed81 Merge pull request #925 from dnephin/add-build-test-symlink 
Add a build unit test for symlinked context
 2018-03-08 18:52:43 +01:00
Daniel Nephin 00b803b2d8 Add a build unit test for symlinked context 
Signed-off-by: Daniel Nephin <dnephin@docker.com>
 2018-03-07 13:04:33 -05:00