c60b360c33
Improve the output for these validation errors:
- Removes the short command description from the output. This information
does not provide much useful help, and distracts from the error message.
- Reduces punctuation, and
- Prefixes the error message with the binary / root-command name
(usually `docker:`) to be consistent with other similar errors.
- Adds an empty line between the error-message and the "call to action"
(`Run 'docker volume --help'...` in the example below). This helps
separating the error message and "usage" from the call-to-action.
Before this patch:
$ docker volume ls one two three
"docker volume ls" accepts no arguments.
See 'docker volume ls --help'.
Usage: docker volume ls [OPTIONS]
List volumes
$ docker volume create one two three
"docker volume create" requires at most 1 argument.
See 'docker volume create --help'.
Usage: docker volume create [OPTIONS] [VOLUME]
Create a volume
With this patch:
$ docker volume ls one two three
docker: 'docker volume ls' accepts no arguments
Usage: docker volume ls [OPTIONS]
Run 'docker volume ls --help' for more information
$ docker voludocker volume create one two three
docker: 'docker volume create' requires at most 1 argument
Usage: docker volume create [OPTIONS] [VOLUME]
SRun 'docker volume create --help' for more information
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
71 lines
1.7 KiB
Go
71 lines
1.7 KiB
Go
package manifest
|
|
|
|
import (
|
|
"context"
|
|
"io"
|
|
"testing"
|
|
|
|
"github.com/distribution/reference"
|
|
"github.com/docker/cli/cli/manifest/store"
|
|
manifesttypes "github.com/docker/cli/cli/manifest/types"
|
|
"github.com/docker/cli/internal/test"
|
|
"github.com/pkg/errors"
|
|
"gotest.tools/v3/assert"
|
|
)
|
|
|
|
func newFakeRegistryClient() *fakeRegistryClient {
|
|
return &fakeRegistryClient{
|
|
getManifestFunc: func(_ context.Context, _ reference.Named) (manifesttypes.ImageManifest, error) {
|
|
return manifesttypes.ImageManifest{}, errors.New("")
|
|
},
|
|
getManifestListFunc: func(_ context.Context, _ reference.Named) ([]manifesttypes.ImageManifest, error) {
|
|
return nil, errors.Errorf("")
|
|
},
|
|
}
|
|
}
|
|
|
|
func TestManifestPushErrors(t *testing.T) {
|
|
testCases := []struct {
|
|
args []string
|
|
expectedError string
|
|
}{
|
|
{
|
|
args: []string{"one-arg", "extra-arg"},
|
|
expectedError: "requires 1 argument",
|
|
},
|
|
{
|
|
args: []string{"th!si'sa/fa!ke/li$t/-name"},
|
|
expectedError: "invalid reference format",
|
|
},
|
|
}
|
|
|
|
for _, tc := range testCases {
|
|
cli := test.NewFakeCli(nil)
|
|
cmd := newPushListCommand(cli)
|
|
cmd.SetArgs(tc.args)
|
|
cmd.SetOut(io.Discard)
|
|
cmd.SetErr(io.Discard)
|
|
assert.ErrorContains(t, cmd.Execute(), tc.expectedError)
|
|
}
|
|
}
|
|
|
|
func TestManifestPush(t *testing.T) {
|
|
manifestStore := store.NewStore(t.TempDir())
|
|
|
|
registry := newFakeRegistryClient()
|
|
|
|
cli := test.NewFakeCli(nil)
|
|
cli.SetManifestStore(manifestStore)
|
|
cli.SetRegistryClient(registry)
|
|
|
|
namedRef := ref(t, "alpine:3.0")
|
|
imageManifest := fullImageManifest(t, namedRef)
|
|
err := manifestStore.Save(ref(t, "list:v1"), namedRef, imageManifest)
|
|
assert.NilError(t, err)
|
|
|
|
cmd := newPushListCommand(cli)
|
|
cmd.SetArgs([]string{"example.com/list:v1"})
|
|
err = cmd.Execute()
|
|
assert.NilError(t, err)
|
|
}
|