if docker exec failed to start, the fifo for exec will left on system. ``` [root@centos-220 bcc8bc6a080eb859ecd193dc32ea4e1cd0080b070afb2a0259b3ed004aae155e]# docker exec -ti bcc8bc6a080e bash rpc error: code = 2 desc = oci runtime error: exec failed: container_linux.go:247: starting container process caused "exec: \"bash\": executable file not found in $PATH" [root@centos-220 bcc8bc6a080eb859ecd193dc32ea4e1cd0080b070afb2a0259b3ed004aae155e]# ls -l total 4 prwx------. 1 root root 0 Apr 10 11:29 46889b0713827f708949af4f6b30315181e1d96e75ce179c949935ab02db2bd1-stdin prwx------. 1 root root 0 Apr 10 11:29 46889b0713827f708949af4f6b30315181e1d96e75ce179c949935ab02db2bd1-stdout prwx------. 1 root root 0 Apr 6 13:15 4dfc9806a2aef53f72a5d2854ff235714b5f064d10e29b5e59ff67d48a924462-stdin prwx------. 1 root root 0 Apr 6 13:15 4dfc9806a2aef53f72a5d2854ff235714b5f064d10e29b5e59ff67d48a924462-stdout prwx------. 1 root root 0 Apr 6 13:15 cc3af6845394cc60007b49242acd990b28988ef4ddaaa217a26caba1075ab343-stdin prwx------. 1 root root 0 Apr 6 13:15 cc3af6845394cc60007b49242acd990b28988ef4ddaaa217a26caba1075ab343-stdout -rw-r--r--. 1 root root 3353 Apr 6 13:12 config.json prwx------. 1 root root 0 Apr 6 13:14 d35e637104991052261e3afeba96a86b3cc6392dae6bd2226812407c0b92a20c-stdin prwx------. 1 root root 0 Apr 6 13:14 d35e637104991052261e3afeba96a86b3cc6392dae6bd2226812407c0b92a20c-stdout prwx------. 1 root root 0 Apr 6 13:12 init-stdin prwx------. 1 root root 0 Apr 6 13:12 init-stdout ``` Signed-off-by: Lei Jitang <leijitang@huawei.com> (cherry picked from commit 997ec06298081bf616177bf6fb102dc737b321ce) Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
119 lines
2.6 KiB
Go
119 lines
2.6 KiB
Go
// +build linux solaris
|
|
|
|
package libcontainerd
|
|
|
|
import (
|
|
"io"
|
|
"io/ioutil"
|
|
"os"
|
|
"path/filepath"
|
|
goruntime "runtime"
|
|
"strings"
|
|
"syscall"
|
|
|
|
containerd "github.com/containerd/containerd/api/grpc/types"
|
|
"github.com/sirupsen/logrus"
|
|
"github.com/tonistiigi/fifo"
|
|
"golang.org/x/net/context"
|
|
"golang.org/x/sys/unix"
|
|
)
|
|
|
|
var fdNames = map[int]string{
|
|
unix.Stdin: "stdin",
|
|
unix.Stdout: "stdout",
|
|
unix.Stderr: "stderr",
|
|
}
|
|
|
|
// process keeps the state for both main container process and exec process.
|
|
type process struct {
|
|
processCommon
|
|
|
|
// Platform specific fields are below here.
|
|
dir string
|
|
}
|
|
|
|
func (p *process) openFifos(ctx context.Context, terminal bool) (pipe *IOPipe, err error) {
|
|
if err := os.MkdirAll(p.dir, 0700); err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
io := &IOPipe{}
|
|
|
|
io.Stdin, err = fifo.OpenFifo(ctx, p.fifo(unix.Stdin), unix.O_WRONLY|unix.O_CREAT|unix.O_NONBLOCK, 0700)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
defer func() {
|
|
if err != nil {
|
|
io.Stdin.Close()
|
|
}
|
|
}()
|
|
|
|
io.Stdout, err = fifo.OpenFifo(ctx, p.fifo(unix.Stdout), unix.O_RDONLY|unix.O_CREAT|unix.O_NONBLOCK, 0700)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
defer func() {
|
|
if err != nil {
|
|
io.Stdout.Close()
|
|
}
|
|
}()
|
|
|
|
if goruntime.GOOS == "solaris" || !terminal {
|
|
// For Solaris terminal handling is done exclusively by the runtime therefore we make no distinction
|
|
// in the processing for terminal and !terminal cases.
|
|
io.Stderr, err = fifo.OpenFifo(ctx, p.fifo(unix.Stderr), unix.O_RDONLY|unix.O_CREAT|unix.O_NONBLOCK, 0700)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
defer func() {
|
|
if err != nil {
|
|
io.Stderr.Close()
|
|
}
|
|
}()
|
|
} else {
|
|
io.Stderr = ioutil.NopCloser(emptyReader{})
|
|
}
|
|
|
|
return io, nil
|
|
}
|
|
|
|
func (p *process) sendCloseStdin() error {
|
|
_, err := p.client.remote.apiClient.UpdateProcess(context.Background(), &containerd.UpdateProcessRequest{
|
|
Id: p.containerID,
|
|
Pid: p.friendlyName,
|
|
CloseStdin: true,
|
|
})
|
|
if err != nil && (strings.Contains(err.Error(), "container not found") || strings.Contains(err.Error(), "process not found")) {
|
|
return nil
|
|
}
|
|
return err
|
|
}
|
|
|
|
func (p *process) closeFifos(io *IOPipe) {
|
|
io.Stdin.Close()
|
|
io.Stdout.Close()
|
|
io.Stderr.Close()
|
|
}
|
|
|
|
type emptyReader struct{}
|
|
|
|
func (r emptyReader) Read(b []byte) (int, error) {
|
|
return 0, io.EOF
|
|
}
|
|
|
|
func (p *process) fifo(index int) string {
|
|
return filepath.Join(p.dir, p.friendlyName+"-"+fdNames[index])
|
|
}
|
|
|
|
func (p *process) cleanFifos(id string) {
|
|
for _, i := range []int{syscall.Stdin, syscall.Stdout, syscall.Stderr} {
|
|
if err := os.Remove(p.fifo(i)); err != nil && !os.IsNotExist(err) {
|
|
logrus.Warnf("failed to remove %v for process %v: %v", p.fifo(i), id, err)
|
|
}
|
|
}
|
|
|
|
}
|