Files
docker-cli/cli/command
Alano Terblanche 26da5bf025 fix: ctx should cancel image pull on run
This patch fixes the context cancellation
behaviour for the `runContainer` function,
specifically the `createContainer` function
introduced in this commit 991b1303da.

It delays stripping the `cancel` from the context
passed into the `runContainer` function so that
the `createContainer` function can be cancelled
gracefully by a SIGTERM/SIGINT.

This is especially true when the requested image
does not exist and `docker run` needs to `pull`
the image before creating the container.

Although this patch does gracefully cancel
the `runContainer` function it does not address
the root cause. Some functions in the call path
are not context aware, such as `pullImage`.

Future work would still be necessary to ensure
a consistent behaviour in the CLI.

Signed-off-by: Alano Terblanche <18033717+Benehiko@users.noreply.github.com>
(cherry picked from commit 30a73ff19c)
Signed-off-by: Alano Terblanche <18033717+Benehiko@users.noreply.github.com>
2024-11-29 14:27:24 +01:00
..
2024-07-19 13:37:27 +02:00
2024-07-19 13:37:27 +02:00
2024-11-15 11:10:35 +01:00
2024-11-15 11:10:35 +01:00
2024-11-15 11:10:35 +01:00
2024-11-15 11:10:35 +01:00
2024-11-15 11:10:35 +01:00
2024-11-15 11:10:35 +01:00
2024-07-19 13:37:27 +02:00
2024-11-15 11:10:35 +01:00
2024-11-15 11:10:35 +01:00
2024-11-15 11:10:35 +01:00
2024-11-15 11:10:35 +01:00
2024-11-15 11:10:35 +01:00
2024-06-11 17:59:48 +02:00
2024-11-15 11:10:35 +01:00