toolshed/docker-cli
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
51025e12e5e936d62db2de2d3d92db98bbfc3726
docker-cli/cli/command
T
History
Sebastiaan van Stijn 50da0ad9df cli/command/container: remove use of ExecOptions.Detach as intermediate 
This field was added in [moby@5130fe5d38837302e], which
added it for use as intermediate struct when parsing CLI flags (through
`runconfig.ParseExec`) in [moby@c786a8ee5e9db8f5f].

Commit [moby@9d9dff3d0d9e92adf] rewrote the CLI to use
Cobra, and as part of this introduced a separate `execOptions` type in
`api/client/container`, however the ExecOptions.Detach field was still
used as intermediate field to store the flag's value.

Given that the client doesn't use this field, let's remove its use to
prevent giving the impression that it's used anywhere.

[moby@5130fe5d38837302e]: https://github.com/docker/docker/commit/5130fe5d38837302e72bdc5e4bd1f5fa1df72c7f
[moby@c786a8ee5e9db8f5f]: https://github.com/docker/docker/commit/c786a8ee5e9db8f5f609cf8721bd1e1513fb0043
[moby@9d9dff3d0d9e92adf]: https://github.com/docker/docker/commit/9d9dff3d0d9e92adf7c2e59f94c63766659d1d47

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2025-06-17 12:53:44 +02:00
..
builder
cli/command/builder: remove errdefs uses
2025-05-16 20:30:00 +02:00
checkpoint
TestCheckpointCreateWithOptions check both "keep-running=true/false"
2025-02-03 13:05:23 +01:00
commands
add top-level "docker bake" command as alias for "docker buildx bake"
2025-04-11 16:28:47 +02:00
completion
cli/command/completion: use ContainerState consts in tests
2025-05-16 01:13:14 +02:00
config
vendor: github.com/docker/docker 7937f0846c13 (master, v28.x dev)
2025-05-19 14:07:50 +02:00
container
cli/command/container: remove use of ExecOptions.Detach as intermediate
2025-06-17 12:53:44 +02:00
context
cli/command/context: use stdlib errors, remove errdefs uses
2025-05-16 20:18:41 +02:00
formatter
Merge pull request #6086 from thaJeztah/golangci_tweaks
2025-05-22 07:57:53 +02:00
idresolver
vendor: github.com/docker/docker 8601b22f5db5 (v28.2-dev)
2025-05-19 22:47:14 +02:00
image
image rm: add --platform option
2025-05-27 10:58:11 +02:00
inspect
cli/command/inspect: minor cleanup and improvements
2025-05-16 14:10:31 +02:00
manifest
cli/command: internalize constructing RegistryClient
2025-03-04 17:48:42 +01:00
network
cli/command/network: use stdlib errors, remove errdefs uses
2025-05-16 20:28:59 +02:00
node
vendor: github.com/docker/docker 8601b22f5db5 (v28.2-dev)
2025-05-19 22:47:14 +02:00
plugin
cli/command/plugin: remove errdefs uses
2025-05-16 20:30:00 +02:00
registry
search: remove deprecated "IsAutomated" placeholder
2025-05-21 17:13:59 +02:00
secret
vendor: github.com/docker/docker 7937f0846c13 (master, v28.x dev)
2025-05-19 14:07:50 +02:00
service
vendor: github.com/docker/docker 8601b22f5db5 (v28.2-dev)
2025-05-19 22:47:14 +02:00
stack
vendor: github.com/docker/docker 8601b22f5db5 (v28.2-dev)
2025-05-19 22:47:14 +02:00
swarm
Merge pull request #6086 from thaJeztah/golangci_tweaks
2025-05-22 07:57:53 +02:00
system
vendor: github.com/docker/docker 8601b22f5db5 (v28.2-dev)
2025-05-19 22:47:14 +02:00
task
vendor: github.com/docker/docker 8601b22f5db5 (v28.2-dev)
2025-05-19 22:47:14 +02:00
testdata
Dynamically register kubernetes context store endpoint type.
2019-05-20 13:28:11 +01:00
trust
cli/command/trust: remove errdefs uses
2025-05-16 20:29:50 +02:00
volume
cli/command/volume: use stdlib errors, remove errdefs uses
2025-05-16 20:29:39 +02:00
cli_options_test.go
golangci-lint: enable thelper linter
2023-11-20 16:02:17 +01:00
cli_options.go
cli/command: make WithInitializeClient a wrapper for WithAPIClient
2025-05-16 23:31:53 +02:00
cli_test.go
cli/command: use stdlib for temp-dirs
2025-04-02 16:45:05 +02:00
cli.go
vendor: github.com/docker/docker 7937f0846c13 (master, v28.x dev)
2025-05-19 14:07:50 +02:00
context_test.go
update go:build tags to go1.23 to align with vendor.mod
2025-04-17 10:43:47 +02:00
context.go
update go:build tags to go1.23 to align with vendor.mod
2025-04-17 10:43:47 +02:00
defaultcontextstore_test.go
switch to github.com/containerd/errdefs for error-matching
2025-05-16 15:27:43 +02:00
defaultcontextstore.go
cli/command: remove errdefs uses
2025-05-16 20:30:00 +02:00
registry_test.go
cli/command: add unit-test for RetrieveAuthTokenFromImage
2025-03-26 14:25:50 +01:00
registry.go
cli/command: RegistryAuthenticationPrivilegedFunc: fix hints for login
2025-06-16 12:14:53 +02:00
telemetry_docker_test.go
command: change drive to lowercase for wsl path
2024-09-18 10:59:08 +01:00
telemetry_docker.go
update go:build tags to go1.23 to align with vendor.mod
2025-04-17 10:43:47 +02:00
telemetry_options.go
cli: make initializing the global meter- and tracing providers optional
2024-06-24 15:44:20 +02:00
telemetry_utils_test.go
cli/command: remove redundant capturing of loop vars in tests (copyloopvar)
2024-11-05 10:14:30 +01:00
telemetry_utils.go
telemetry: pass otel errors to the otel handler for shutdown and force flush
2024-09-17 10:47:04 -05:00
telemetry.go
cli/command: un-export ResourceAttributesEnvvar, DockerCliAttributePrefix
2025-03-03 14:21:45 +01:00
trust.go
Refactor content_trust cli/flags handling
2018-03-08 15:00:43 -05:00
utils_test.go
cli/command: move prompt utilities to separate package
2025-04-11 12:23:16 +02:00
utils.go
cli/command: remove errdefs uses
2025-05-16 20:30:00 +02:00