83d9648a45
This fix tries to address the issue raised in 29999 where it was not possible to mask these items (like important non-removable stuff) from `docker system prune`. This fix adds `label` and `label!` field for `--filter` in `system prune`, so that it is possible to selectively prune items like: ``` $ docker container prune --filter label=foo $ docker container prune --filter label!=bar ``` Additional unit tests and integration tests have been added. This fix fixes 29999. Signed-off-by: Yong Tang <yong.tang.github@outlook.com> Upstream-commit: 702524732427ce028277f99f215e1fab297e6001 Component: engine
291 lines
11 KiB
Go
291 lines
11 KiB
Go
// +build !windows
|
|
|
|
package main
|
|
|
|
import (
|
|
"io/ioutil"
|
|
"os"
|
|
"path/filepath"
|
|
"strconv"
|
|
"strings"
|
|
"time"
|
|
|
|
"github.com/docker/docker/integration-cli/checker"
|
|
"github.com/docker/docker/integration-cli/daemon"
|
|
"github.com/go-check/check"
|
|
)
|
|
|
|
func pruneNetworkAndVerify(c *check.C, d *daemon.Swarm, kept, pruned []string) {
|
|
_, err := d.Cmd("network", "prune", "--force")
|
|
c.Assert(err, checker.IsNil)
|
|
out, err := d.Cmd("network", "ls", "--format", "{{.Name}}")
|
|
c.Assert(err, checker.IsNil)
|
|
for _, s := range kept {
|
|
c.Assert(out, checker.Contains, s)
|
|
}
|
|
for _, s := range pruned {
|
|
c.Assert(out, checker.Not(checker.Contains), s)
|
|
}
|
|
}
|
|
|
|
func (s *DockerSwarmSuite) TestPruneNetwork(c *check.C) {
|
|
d := s.AddDaemon(c, true, true)
|
|
_, err := d.Cmd("network", "create", "n1") // used by container (testprune)
|
|
c.Assert(err, checker.IsNil)
|
|
_, err = d.Cmd("network", "create", "n2")
|
|
c.Assert(err, checker.IsNil)
|
|
_, err = d.Cmd("network", "create", "n3", "--driver", "overlay") // used by service (testprunesvc)
|
|
c.Assert(err, checker.IsNil)
|
|
_, err = d.Cmd("network", "create", "n4", "--driver", "overlay")
|
|
c.Assert(err, checker.IsNil)
|
|
|
|
cName := "testprune"
|
|
_, err = d.Cmd("run", "-d", "--name", cName, "--net", "n1", "busybox", "top")
|
|
c.Assert(err, checker.IsNil)
|
|
|
|
serviceName := "testprunesvc"
|
|
replicas := 1
|
|
out, err := d.Cmd("service", "create", "--name", serviceName,
|
|
"--replicas", strconv.Itoa(replicas),
|
|
"--network", "n3",
|
|
"busybox", "top")
|
|
c.Assert(err, checker.IsNil)
|
|
c.Assert(strings.TrimSpace(out), checker.Not(checker.Equals), "")
|
|
waitAndAssert(c, defaultReconciliationTimeout, d.CheckActiveContainerCount, checker.Equals, replicas+1)
|
|
|
|
// prune and verify
|
|
pruneNetworkAndVerify(c, d, []string{"n1", "n3"}, []string{"n2", "n4"})
|
|
|
|
// remove containers, then prune and verify again
|
|
_, err = d.Cmd("rm", "-f", cName)
|
|
c.Assert(err, checker.IsNil)
|
|
_, err = d.Cmd("service", "rm", serviceName)
|
|
c.Assert(err, checker.IsNil)
|
|
waitAndAssert(c, defaultReconciliationTimeout, d.CheckActiveContainerCount, checker.Equals, 0)
|
|
pruneNetworkAndVerify(c, d, []string{}, []string{"n1", "n3"})
|
|
}
|
|
|
|
func (s *DockerDaemonSuite) TestPruneImageDangling(c *check.C) {
|
|
s.d.StartWithBusybox(c)
|
|
|
|
out, _, err := s.d.BuildImageWithOut("test",
|
|
`FROM busybox
|
|
LABEL foo=bar`, true, "-q")
|
|
c.Assert(err, checker.IsNil)
|
|
id := strings.TrimSpace(out)
|
|
|
|
out, err = s.d.Cmd("images", "-q", "--no-trunc")
|
|
c.Assert(err, checker.IsNil)
|
|
c.Assert(strings.TrimSpace(out), checker.Contains, id)
|
|
|
|
out, err = s.d.Cmd("image", "prune", "--force")
|
|
c.Assert(err, checker.IsNil)
|
|
c.Assert(strings.TrimSpace(out), checker.Not(checker.Contains), id)
|
|
|
|
out, err = s.d.Cmd("images", "-q", "--no-trunc")
|
|
c.Assert(err, checker.IsNil)
|
|
c.Assert(strings.TrimSpace(out), checker.Contains, id)
|
|
|
|
out, err = s.d.Cmd("image", "prune", "--force", "--all")
|
|
c.Assert(err, checker.IsNil)
|
|
c.Assert(strings.TrimSpace(out), checker.Contains, id)
|
|
|
|
out, err = s.d.Cmd("images", "-q", "--no-trunc")
|
|
c.Assert(err, checker.IsNil)
|
|
c.Assert(strings.TrimSpace(out), checker.Not(checker.Contains), id)
|
|
}
|
|
|
|
func (s *DockerSuite) TestPruneContainerUntil(c *check.C) {
|
|
out, _ := dockerCmd(c, "run", "-d", "busybox")
|
|
id1 := strings.TrimSpace(out)
|
|
c.Assert(waitExited(id1, 5*time.Second), checker.IsNil)
|
|
|
|
until := daemonUnixTime(c)
|
|
|
|
out, _ = dockerCmd(c, "run", "-d", "busybox")
|
|
id2 := strings.TrimSpace(out)
|
|
c.Assert(waitExited(id2, 5*time.Second), checker.IsNil)
|
|
|
|
out, _ = dockerCmd(c, "container", "prune", "--force", "--filter", "until="+until)
|
|
c.Assert(strings.TrimSpace(out), checker.Contains, id1)
|
|
c.Assert(strings.TrimSpace(out), checker.Not(checker.Contains), id2)
|
|
|
|
out, _ = dockerCmd(c, "ps", "-a", "-q", "--no-trunc")
|
|
c.Assert(strings.TrimSpace(out), checker.Not(checker.Contains), id1)
|
|
c.Assert(strings.TrimSpace(out), checker.Contains, id2)
|
|
}
|
|
|
|
func (s *DockerSuite) TestPruneContainerLabel(c *check.C) {
|
|
out, _ := dockerCmd(c, "run", "-d", "--label", "foo", "busybox")
|
|
id1 := strings.TrimSpace(out)
|
|
c.Assert(waitExited(id1, 5*time.Second), checker.IsNil)
|
|
|
|
out, _ = dockerCmd(c, "run", "-d", "--label", "bar", "busybox")
|
|
id2 := strings.TrimSpace(out)
|
|
c.Assert(waitExited(id2, 5*time.Second), checker.IsNil)
|
|
|
|
out, _ = dockerCmd(c, "run", "-d", "busybox")
|
|
id3 := strings.TrimSpace(out)
|
|
c.Assert(waitExited(id3, 5*time.Second), checker.IsNil)
|
|
|
|
out, _ = dockerCmd(c, "run", "-d", "--label", "foobar", "busybox")
|
|
id4 := strings.TrimSpace(out)
|
|
c.Assert(waitExited(id4, 5*time.Second), checker.IsNil)
|
|
|
|
// Add a config file of label=foobar, that will have no impact if cli is label!=foobar
|
|
config := `{"pruneFilters": ["label=foobar"]}`
|
|
d, err := ioutil.TempDir("", "integration-cli-")
|
|
c.Assert(err, checker.IsNil)
|
|
defer os.RemoveAll(d)
|
|
err = ioutil.WriteFile(filepath.Join(d, "config.json"), []byte(config), 0644)
|
|
c.Assert(err, checker.IsNil)
|
|
|
|
// With config.json only, prune based on label=foobar
|
|
out, _ = dockerCmd(c, "--config", d, "container", "prune", "--force")
|
|
c.Assert(strings.TrimSpace(out), checker.Not(checker.Contains), id1)
|
|
c.Assert(strings.TrimSpace(out), checker.Not(checker.Contains), id2)
|
|
c.Assert(strings.TrimSpace(out), checker.Not(checker.Contains), id3)
|
|
c.Assert(strings.TrimSpace(out), checker.Contains, id4)
|
|
|
|
out, _ = dockerCmd(c, "container", "prune", "--force", "--filter", "label=foo")
|
|
c.Assert(strings.TrimSpace(out), checker.Contains, id1)
|
|
c.Assert(strings.TrimSpace(out), checker.Not(checker.Contains), id2)
|
|
c.Assert(strings.TrimSpace(out), checker.Not(checker.Contains), id3)
|
|
|
|
out, _ = dockerCmd(c, "ps", "-a", "-q", "--no-trunc")
|
|
c.Assert(strings.TrimSpace(out), checker.Not(checker.Contains), id1)
|
|
c.Assert(strings.TrimSpace(out), checker.Contains, id2)
|
|
c.Assert(strings.TrimSpace(out), checker.Contains, id3)
|
|
|
|
out, _ = dockerCmd(c, "container", "prune", "--force", "--filter", "label!=bar")
|
|
c.Assert(strings.TrimSpace(out), checker.Not(checker.Contains), id2)
|
|
c.Assert(strings.TrimSpace(out), checker.Contains, id3)
|
|
|
|
out, _ = dockerCmd(c, "ps", "-a", "-q", "--no-trunc")
|
|
c.Assert(strings.TrimSpace(out), checker.Contains, id2)
|
|
c.Assert(strings.TrimSpace(out), checker.Not(checker.Contains), id3)
|
|
|
|
// With config.json label=foobar and CLI label!=foobar, CLI label!=foobar supersede
|
|
out, _ = dockerCmd(c, "--config", d, "container", "prune", "--force", "--filter", "label!=foobar")
|
|
c.Assert(strings.TrimSpace(out), checker.Contains, id2)
|
|
|
|
out, _ = dockerCmd(c, "ps", "-a", "-q", "--no-trunc")
|
|
c.Assert(strings.TrimSpace(out), checker.Not(checker.Contains), id2)
|
|
}
|
|
|
|
func (s *DockerSuite) TestPruneVolumeLabel(c *check.C) {
|
|
out, _ := dockerCmd(c, "volume", "create", "--label", "foo")
|
|
id1 := strings.TrimSpace(out)
|
|
c.Assert(id1, checker.Not(checker.Equals), "")
|
|
|
|
out, _ = dockerCmd(c, "volume", "create", "--label", "bar")
|
|
id2 := strings.TrimSpace(out)
|
|
c.Assert(id2, checker.Not(checker.Equals), "")
|
|
|
|
out, _ = dockerCmd(c, "volume", "create")
|
|
id3 := strings.TrimSpace(out)
|
|
c.Assert(id3, checker.Not(checker.Equals), "")
|
|
|
|
out, _ = dockerCmd(c, "volume", "create", "--label", "foobar")
|
|
id4 := strings.TrimSpace(out)
|
|
c.Assert(id4, checker.Not(checker.Equals), "")
|
|
|
|
// Add a config file of label=foobar, that will have no impact if cli is label!=foobar
|
|
config := `{"pruneFilters": ["label=foobar"]}`
|
|
d, err := ioutil.TempDir("", "integration-cli-")
|
|
c.Assert(err, checker.IsNil)
|
|
defer os.RemoveAll(d)
|
|
err = ioutil.WriteFile(filepath.Join(d, "config.json"), []byte(config), 0644)
|
|
c.Assert(err, checker.IsNil)
|
|
|
|
// With config.json only, prune based on label=foobar
|
|
out, _ = dockerCmd(c, "--config", d, "volume", "prune", "--force")
|
|
c.Assert(strings.TrimSpace(out), checker.Not(checker.Contains), id1)
|
|
c.Assert(strings.TrimSpace(out), checker.Not(checker.Contains), id2)
|
|
c.Assert(strings.TrimSpace(out), checker.Not(checker.Contains), id3)
|
|
c.Assert(strings.TrimSpace(out), checker.Contains, id4)
|
|
|
|
out, _ = dockerCmd(c, "volume", "prune", "--force", "--filter", "label=foo")
|
|
c.Assert(strings.TrimSpace(out), checker.Contains, id1)
|
|
c.Assert(strings.TrimSpace(out), checker.Not(checker.Contains), id2)
|
|
c.Assert(strings.TrimSpace(out), checker.Not(checker.Contains), id3)
|
|
|
|
out, _ = dockerCmd(c, "volume", "ls", "--format", "{{.Name}}")
|
|
c.Assert(strings.TrimSpace(out), checker.Not(checker.Contains), id1)
|
|
c.Assert(strings.TrimSpace(out), checker.Contains, id2)
|
|
c.Assert(strings.TrimSpace(out), checker.Contains, id3)
|
|
|
|
out, _ = dockerCmd(c, "volume", "prune", "--force", "--filter", "label!=bar")
|
|
c.Assert(strings.TrimSpace(out), checker.Not(checker.Contains), id2)
|
|
c.Assert(strings.TrimSpace(out), checker.Contains, id3)
|
|
|
|
out, _ = dockerCmd(c, "volume", "ls", "--format", "{{.Name}}")
|
|
c.Assert(strings.TrimSpace(out), checker.Contains, id2)
|
|
c.Assert(strings.TrimSpace(out), checker.Not(checker.Contains), id3)
|
|
|
|
// With config.json label=foobar and CLI label!=foobar, CLI label!=foobar supersede
|
|
out, _ = dockerCmd(c, "--config", d, "volume", "prune", "--force", "--filter", "label!=foobar")
|
|
c.Assert(strings.TrimSpace(out), checker.Contains, id2)
|
|
|
|
out, _ = dockerCmd(c, "volume", "ls", "--format", "{{.Name}}")
|
|
c.Assert(strings.TrimSpace(out), checker.Not(checker.Contains), id2)
|
|
}
|
|
|
|
func (s *DockerSuite) TestPruneNetworkLabel(c *check.C) {
|
|
dockerCmd(c, "network", "create", "--label", "foo", "n1")
|
|
dockerCmd(c, "network", "create", "--label", "bar", "n2")
|
|
dockerCmd(c, "network", "create", "n3")
|
|
|
|
out, _ := dockerCmd(c, "network", "prune", "--force", "--filter", "label=foo")
|
|
c.Assert(strings.TrimSpace(out), checker.Contains, "n1")
|
|
c.Assert(strings.TrimSpace(out), checker.Not(checker.Contains), "n2")
|
|
c.Assert(strings.TrimSpace(out), checker.Not(checker.Contains), "n3")
|
|
|
|
out, _ = dockerCmd(c, "network", "prune", "--force", "--filter", "label!=bar")
|
|
c.Assert(strings.TrimSpace(out), checker.Not(checker.Contains), "n1")
|
|
c.Assert(strings.TrimSpace(out), checker.Not(checker.Contains), "n2")
|
|
c.Assert(strings.TrimSpace(out), checker.Contains, "n3")
|
|
|
|
out, _ = dockerCmd(c, "network", "prune", "--force")
|
|
c.Assert(strings.TrimSpace(out), checker.Not(checker.Contains), "n1")
|
|
c.Assert(strings.TrimSpace(out), checker.Contains, "n2")
|
|
c.Assert(strings.TrimSpace(out), checker.Not(checker.Contains), "n3")
|
|
}
|
|
|
|
func (s *DockerDaemonSuite) TestPruneImageLabel(c *check.C) {
|
|
s.d.StartWithBusybox(c)
|
|
|
|
out, _, err := s.d.BuildImageWithOut("test1",
|
|
`FROM busybox
|
|
LABEL foo=bar`, true, "-q")
|
|
c.Assert(err, checker.IsNil)
|
|
id1 := strings.TrimSpace(out)
|
|
out, err = s.d.Cmd("images", "-q", "--no-trunc")
|
|
c.Assert(err, checker.IsNil)
|
|
c.Assert(strings.TrimSpace(out), checker.Contains, id1)
|
|
|
|
out, _, err = s.d.BuildImageWithOut("test2",
|
|
`FROM busybox
|
|
LABEL bar=foo`, true, "-q")
|
|
c.Assert(err, checker.IsNil)
|
|
id2 := strings.TrimSpace(out)
|
|
out, err = s.d.Cmd("images", "-q", "--no-trunc")
|
|
c.Assert(err, checker.IsNil)
|
|
c.Assert(strings.TrimSpace(out), checker.Contains, id2)
|
|
|
|
out, err = s.d.Cmd("image", "prune", "--force", "--all", "--filter", "label=foo=bar")
|
|
c.Assert(err, checker.IsNil)
|
|
c.Assert(strings.TrimSpace(out), checker.Contains, id1)
|
|
c.Assert(strings.TrimSpace(out), checker.Not(checker.Contains), id2)
|
|
|
|
out, err = s.d.Cmd("image", "prune", "--force", "--all", "--filter", "label!=bar=foo")
|
|
c.Assert(err, checker.IsNil)
|
|
c.Assert(strings.TrimSpace(out), checker.Not(checker.Contains), id1)
|
|
c.Assert(strings.TrimSpace(out), checker.Not(checker.Contains), id2)
|
|
|
|
out, err = s.d.Cmd("image", "prune", "--force", "--all", "--filter", "label=bar=foo")
|
|
c.Assert(err, checker.IsNil)
|
|
c.Assert(strings.TrimSpace(out), checker.Not(checker.Contains), id1)
|
|
c.Assert(strings.TrimSpace(out), checker.Contains, id2)
|
|
}
|