toolshed/docker-cli
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
d59bd66e1b6657aa6574d8f10da369d70a418e9b
docker-cli/components/engine/daemon
History
Kir Kolyshkin d59bd66e1b daemon.cleanupContainer: nullify container RWLayer upon release 
ReleaseRWLayer can and should only be called once (unless it returns
an error), but might be called twice in case of a failure from
`system.EnsureRemoveAll(container.Root)`. This results in the
following error:

> Error response from daemon: driver "XXX" failed to remove root filesystem for YYY: layer not retained

The obvious fix is to set container.RWLayer to nil as soon as
ReleaseRWLayer() succeeds.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Upstream-commit: e9b9e4ace294230c6b8eb010eda564a2541c4564
Component: engine
2018-01-30 18:50:59 -08:00
..
caps
Copy Inslice() to those parts that use it
2017-11-10 13:42:38 +08:00
cluster
Fix issue where network inspect does not show Created time in swarm scope
2018-01-23 18:26:51 +00:00
config
Log active configuration when reloading
2018-01-21 00:56:02 +01:00
discovery
Add ineffassign linter
2017-09-08 18:23:21 -04:00
events
Update TestLogEvents to not use deprecated Status field
2017-12-20 12:49:51 +01:00
exec
Remove libcontainerd.IOPipe
2018-01-09 12:00:28 -05:00
graphdriver
Merge pull request #36114 from Microsoft/jjh/fixdeadlock-lcowdriver-hotremove
2018-01-29 09:57:43 -08:00
initlayer
Remove redundant build-tags
2017-12-18 17:41:53 +01:00
links
…
listeners
Remove Solaris files
2017-12-18 17:22:25 +01:00
logger
Merge pull request #36078 from mixja/multiline-max-event-processing
2018-01-24 12:06:49 -08:00
names
Move names to a more appropriate package.
2017-09-06 12:05:16 -04:00
network
Typo fixed and simple code.
2017-10-18 10:26:58 +08:00
stats
Remove redundant build-tags
2017-12-18 17:41:53 +01:00
testdata
Remove libtrust dep from api
2017-09-06 12:05:19 -04:00
apparmor_default_unsupported.go
…
apparmor_default.go
apparmor: make pkg/aaparser work on read-only root
2017-05-18 00:05:13 +10:00
archive_tarcopyoptions_unix.go
Fix vfs unit test and port VFS to the new IDMappings
2017-06-07 11:44:34 -04:00
archive_tarcopyoptions_windows.go
Remove redundant build-tags
2017-12-18 17:41:53 +01:00
archive_tarcopyoptions.go
Partial refactor of UID/GID usage to use a unified struct.
2017-06-07 11:44:33 -04:00
archive_unix.go
LCOW: API change JSON header to string POST parameter
2017-10-06 15:26:48 -07:00
archive_windows.go
Remove CopyOnBuild from the daemon.
2017-06-08 15:06:54 -04:00
archive.go
Move api/errdefs to errdefs
2018-01-11 21:21:43 -05:00
attach.go
Move api/errdefs to errdefs
2018-01-11 21:21:43 -05:00
auth.go
…
bindmount_unix.go
…
build.go
Address feedback from Tonis
2018-01-18 12:30:39 -08:00
cache.go
LCOW: Re-coalesce stores
2018-01-18 08:29:19 -08:00
changes.go
…
checkpoint.go
Don't append the container id to custom directory checkpoints. Fixes #34601.
2017-12-04 14:24:35 -05:00
cluster.go
Fix race condition between swarm and libnetwork
2017-05-10 21:16:52 -07:00
commit.go
Address feedback from Tonis
2018-01-18 12:30:39 -08:00
configs_linux.go
Remove redundant build-tags
2017-12-18 17:41:53 +01:00
configs_unsupported.go
Add Windows configs support
2017-05-16 14:25:32 -07:00
configs_windows.go
Remove redundant build-tags
2017-12-18 17:41:53 +01:00
configs.go
Update logrus to v1.0.1
2017-07-31 13:16:46 -07:00
container_linux.go
Move api/errdefs to errdefs
2018-01-11 21:21:43 -05:00
container_operations_unix.go
Fix secret and config mode issue
2018-01-28 16:21:41 +00:00
container_operations_windows.go
Make container resource mounts unbindable
2018-01-16 15:09:05 -05:00
container_operations.go
Fix network alias issue
2018-01-23 01:04:33 +00:00
container_windows.go
Remove redundant build-tags
2017-12-18 17:41:53 +01:00
container.go
Move api/errdefs to errdefs
2018-01-11 21:21:43 -05:00
create_test.go
Verify NetworkingConfig to make sure EndpointSettings is not nil
2018-01-22 16:31:10 +00:00
create_unix.go
LCOW: API: Add platform to /images/create and /build
2017-10-06 11:44:18 -07:00
create_windows.go
LCOW: API: Add platform to /images/create and /build
2017-10-06 11:44:18 -07:00
create.go
Verify NetworkingConfig to make sure EndpointSettings is not nil
2018-01-22 16:31:10 +00:00
daemon_linux_test.go
Added validation of isolation settings on daemon.verifyContainerSettings
2017-11-20 10:34:20 +01:00
daemon_linux.go
Update logrus to v1.0.1
2017-07-31 13:16:46 -07:00
daemon_test.go
Merge pull request #36021 from yongtang/30897-follow-up
2018-01-16 09:38:16 +01:00
daemon_unix_test.go
Remove solaris build tag and `contrib/mkimage/solaris
2017-11-02 00:01:46 +00:00
daemon_unix.go
Set daemon root to use shared propagation
2018-01-23 14:17:08 -08:00
daemon_unsupported.go
Remove solaris build tag and `contrib/mkimage/solaris
2017-11-02 00:01:46 +00:00
daemon_windows_test.go
Ensure Host Network Service exists
2017-09-25 11:07:44 -07:00
daemon_windows.go
Move reload-related functions to reload.go
2018-01-21 00:55:49 +01:00
daemon.go
Simplify codes on calculating shutdown timeout
2018-01-26 09:18:07 -08:00
debugtrap_unix.go
Update logrus to v1.0.1
2017-07-31 13:16:46 -07:00
debugtrap_unsupported.go
Remove solaris build tag and `contrib/mkimage/solaris
2017-11-02 00:01:46 +00:00
debugtrap_windows.go
Fix startup logging
2017-10-19 11:09:29 -07:00
delete_test.go
Move ErrorContains to an internal package.
2017-08-25 12:04:58 -04:00
delete.go
daemon.cleanupContainer: nullify container RWLayer upon release
2018-01-30 18:50:59 -08:00
dependency.go
Add config support to executor backend
2017-05-11 10:08:21 -07:00
disk_usage.go
LCOW: Refactor to multiple layer-stores based on feedback
2018-01-18 08:31:05 -08:00
errors.go
Move api/errdefs to errdefs
2018-01-11 21:21:43 -05:00
events_test.go
LCOW: Remove CommonContainer - just Container
2017-06-20 08:55:46 -07:00
events.go
Update logrus to v1.0.1
2017-07-31 13:16:46 -07:00
exec_linux.go
Update libcontainerd to use containerd 1.0
2017-10-20 07:11:37 -07:00
exec_windows.go
Update libcontainerd to use containerd 1.0
2017-10-20 07:11:37 -07:00
exec.go
Merge pull request #35744 from ndeloof/35702
2018-01-19 15:03:50 -08:00
export.go
Address feedback from Tonis
2018-01-18 12:30:39 -08:00
getsize_unix.go
LCOW: Refactor to multiple layer-stores based on feedback
2018-01-18 08:31:05 -08:00
health_test.go
container: protect the health status with mutex
2017-11-16 15:04:01 -08:00
health.go
introduce « exec_die » event
2018-01-08 11:42:25 +01:00
image_delete.go
Address feedback from Tonis
2018-01-18 12:30:39 -08:00
image_exporter.go
LCOW: Refactor to multiple layer-stores based on feedback
2018-01-18 08:31:05 -08:00
image_history.go
LCOW: Refactor to multiple layer-stores based on feedback
2018-01-18 08:31:05 -08:00
image_inspect.go
Address feedback from Tonis
2018-01-18 12:30:39 -08:00
image_pull.go
LCOW: Re-coalesce stores
2018-01-18 08:29:19 -08:00
image_push.go
LCOW: Refactor to multiple layer-stores based on feedback
2018-01-18 08:31:05 -08:00
image_tag.go
LCOW: Re-coalesce stores
2018-01-18 08:29:19 -08:00
image.go
LCOW: Refactor to multiple layer-stores based on feedback
2018-01-18 08:31:05 -08:00
images.go
Address feedback from Tonis
2018-01-18 12:30:39 -08:00
import.go
LCOW: Refactor to multiple layer-stores based on feedback
2018-01-18 08:31:05 -08:00
info_unix_test.go
Refactor "init" version parsing, and add unit-test
2017-04-08 11:28:37 +02:00
info_unix.go
Use containerd API to get version
2017-11-03 01:46:58 +01:00
info_windows.go
…
info.go
LCOW: Refactor to multiple layer-stores based on feedback
2018-01-18 08:31:05 -08:00
inspect_linux.go
Remove Solaris files
2017-12-18 17:22:25 +01:00
inspect_windows.go
Move platform specific mount data to Container
2017-06-23 07:22:47 -07:00
inspect.go
Move api/errdefs to errdefs
2018-01-11 21:21:43 -05:00
keys_unsupported.go
…
keys.go
…
kill.go
Move api/errdefs to errdefs
2018-01-11 21:21:43 -05:00
links.go
Remove links when remove container
2017-07-18 12:09:26 +08:00
list_unix.go
Remove solaris build tag and `contrib/mkimage/solaris
2017-11-02 00:01:46 +00:00
list_windows.go
stop grabbing container locks during ps
2017-06-23 07:52:31 -07:00
list.go
Merge pull request #35938 from yongtang/35931-filter-before-since
2018-01-24 12:06:19 -08:00
logdrivers_linux.go
…
logdrivers_windows.go
Add gelf log driver plugin to Windows build
2017-10-03 12:42:54 -07:00
logs_test.go
…
logs.go
Move api/errdefs to errdefs
2018-01-11 21:21:43 -05:00
metrics_unix.go
Update logrus to v1.0.1
2017-07-31 13:16:46 -07:00
metrics_unsupported.go
Add support for metrics plugins
2017-05-12 00:30:09 -04:00
metrics.go
daemon.cleanupMetricsPlugins(): fix
2018-01-16 15:15:11 -08:00
monitor_linux.go
Update libcontainerd to use containerd 1.0
2017-10-20 07:11:37 -07:00
monitor_windows.go
Update libcontainerd to use containerd 1.0
2017-10-20 07:11:37 -07:00
monitor.go
introduce « exec_die » event
2018-01-08 11:42:25 +01:00
mounts.go
Fix issue backporting mount spec to pre-1.13 obj
2017-05-11 12:31:53 -04:00
names.go
Move api/errdefs to errdefs
2018-01-11 21:21:43 -05:00
network.go
Merge pull request #36021 from yongtang/30897-follow-up
2018-01-16 09:38:16 +01:00
oci_linux_test.go
Fix "duplicate mount point" when --tmpfs /dev/shm is used
2017-11-20 18:48:27 -08:00
oci_linux.go
Use proc/exe for reexec
2018-01-26 14:13:43 -05:00
oci_windows.go
Merge pull request #35830 from cpuguy83/unbindable_shm
2018-01-19 17:43:30 -08:00
pause.go
Golint: remove redundant ifs
2018-01-15 00:42:25 +01:00
prune.go
LCOW: Refactor to multiple layer-stores based on feedback
2018-01-18 08:31:05 -08:00
reload_test.go
Add option to enable networkDB debug
2017-12-06 13:19:47 -08:00
reload_unix.go
Move reload-related functions to reload.go
2018-01-21 00:55:49 +01:00
reload_windows.go
Move reload-related functions to reload.go
2018-01-21 00:55:49 +01:00
reload.go
Log active configuration when reloading
2018-01-21 00:56:02 +01:00
rename.go
Move api/errdefs to errdefs
2018-01-11 21:21:43 -05:00
resize.go
Update libcontainerd to use containerd 1.0
2017-10-20 07:11:37 -07:00
restart.go
Update logrus to v1.0.1
2017-07-31 13:16:46 -07:00
search_test.go
…
search.go
Replace uses of filters.ToParam(), FromParam() with filters.ToJSON(), FromJSON()
2017-09-26 13:59:45 +02:00
seccomp_disabled.go
…
seccomp_linux.go
Update logrus to v1.0.1
2017-07-31 13:16:46 -07:00
seccomp_unsupported.go
…
secrets_linux.go
Remove redundant build-tags
2017-12-18 17:41:53 +01:00
secrets_unsupported.go
Add Windows secrets support
2017-05-16 11:30:06 -07:00
secrets_windows.go
Remove redundant build-tags
2017-12-18 17:41:53 +01:00
secrets.go
Update logrus to v1.0.1
2017-07-31 13:16:46 -07:00
selinux_linux.go
Remove redundant build-tags
2017-12-18 17:41:53 +01:00
selinux_unsupported.go
…
start_unix.go
Move api/errdefs to errdefs
2018-01-11 21:21:43 -05:00
start_windows.go
Update libcontainerd to use containerd 1.0
2017-10-20 07:11:37 -07:00
start.go
Merge pull request #35830 from cpuguy83/unbindable_shm
2018-01-19 17:43:30 -08:00
stats_collector.go
…
stats_unix.go
Remove string checking in API error handling
2017-08-15 16:01:11 -04:00
stats_windows.go
…
stats.go
Remove solaris files
2017-10-24 15:39:34 -04:00
stop.go
Move api/errdefs to errdefs
2018-01-11 21:21:43 -05:00
top_unix_test.go
Update libcontainerd to use containerd 1.0
2017-10-20 07:11:37 -07:00
top_unix.go
Update libcontainerd to use containerd 1.0
2017-10-20 07:11:37 -07:00
top_windows.go
Update libcontainerd to use containerd 1.0
2017-10-20 07:11:37 -07:00
trustkey_test.go
Remove libtrust dep from api
2017-09-06 12:05:19 -04:00
trustkey.go
Remove libtrust dep from api
2017-09-06 12:05:19 -04:00
unpause.go
Golint: remove redundant ifs
2018-01-15 00:42:25 +01:00
update_linux.go
Ensure CPU quota/period updates are sent to runc
2018-01-16 11:50:14 -05:00
update_windows.go
Remove Solaris files
2017-12-18 17:22:25 +01:00
update.go
Move api/errdefs to errdefs
2018-01-11 21:21:43 -05:00
volumes_unit_test.go
Volume refactoring for LCOW
2017-09-14 12:33:31 -07:00
volumes_unix_test.go
Spelling fixes
2017-07-03 13:13:09 -07:00
volumes_unix.go
Merge pull request #34224 from estesp/no-chown-nwfiles-outside-metadata
2017-11-02 15:00:42 -07:00
volumes_windows.go
Remove redundant build-tags
2017-12-18 17:41:53 +01:00
volumes.go
Move api/errdefs to errdefs
2018-01-11 21:21:43 -05:00
wait.go
Update ContainerWait API
2017-05-16 15:11:39 -07:00
workdir.go
Remove error return from RootPair
2017-06-07 11:45:33 -04:00