1c3f4cf12c
In some circumstances we were not properly releasing plugin references, leading to failures in removing a plugin with no way to recover other than restarting the daemon. 1. If volume create fails (in the driver) 2. If a driver validation fails (should be rare) 3. If trying to get a plugin that does not match the passed in capability Ideally the test for 1 and 2 would just be a unit test, however the plugin interfaces are too complicated as `plugingetter` relies on github.com/pkg/plugin/Client (a concrete type), which will require spinning up services from within the unit test... it just wouldn't be a unit test at this point. I attempted to refactor this a bit, but since both libnetwork and swarmkit are reliant on `plugingetter` as well, this would not work. This really requires a re-write of the lower-level plugin management to decouple these pieces. Signed-off-by: Brian Goff <cpuguy83@gmail.com> Upstream-commit: 3816b514387efd24394f0b8e61d55502aa6ac9ac Component: engine
38 lines
869 B
Go
38 lines
869 B
Go
package plugingetter
|
|
|
|
import (
|
|
"github.com/docker/docker/pkg/plugins"
|
|
)
|
|
|
|
const (
|
|
// Lookup doesn't update RefCount
|
|
Lookup = 0
|
|
// Acquire increments RefCount
|
|
Acquire = 1
|
|
// Release decrements RefCount
|
|
Release = -1
|
|
)
|
|
|
|
// CompatPlugin is an abstraction to handle both v2(new) and v1(legacy) plugins.
|
|
type CompatPlugin interface {
|
|
Client() *plugins.Client
|
|
Name() string
|
|
BasePath() string
|
|
IsV1() bool
|
|
}
|
|
|
|
// CountedPlugin is a plugin which is reference counted.
|
|
type CountedPlugin interface {
|
|
Acquire()
|
|
Release()
|
|
CompatPlugin
|
|
}
|
|
|
|
// PluginGetter is the interface implemented by Store
|
|
type PluginGetter interface {
|
|
Get(name, capability string, mode int) (CompatPlugin, error)
|
|
GetAllByCap(capability string) ([]CompatPlugin, error)
|
|
GetAllManagedPluginsByCap(capability string) []CompatPlugin
|
|
Handle(capability string, callback func(string, *plugins.Client))
|
|
}
|