upgrade --patch/--minor/--major #172

New Issue

decentral1se · 2021-09-17T05:44:50Z

decentral1se commented

2021-09-17 05:44:50 +00:00

Describe the problem to be solved

upgrade can only be manually ran.

Describe the solution you would like

Add flags to support non-interactive automation.

## Describe the problem to be solved `upgrade` can only be manually ran. ## Describe the solution you would like Add flags to support non-interactive automation.

decentral1se added this to the (deleted) milestone 2021-09-17 05:44:50 +00:00

decentral1se added the

enhancement

abra

labels 2021-09-17 05:44:50 +00:00

decentral1se added this to the Beta release (software) project 2021-09-17 05:44:50 +00:00

knoflook self-assigned this 2021-09-24 08:54:03 +00:00

knoflook removed their assignment 2021-09-27 09:27:10 +00:00

knoflook commented

2021-10-01 18:01:24 +00:00

Design question:
current version: 1.4.1
newest avail. version: 1.5.0

abra recipe upgrade --major thisapp

should it upgrade to 1.5.0? I'd say yes but I'd love some input on that.

Design question: current version: 1.4.1 newest avail. version: 1.5.0 `abra recipe upgrade --major thisapp` should it upgrade to 1.5.0? I'd say yes but I'd love some input on that.

knoflook self-assigned this 2021-10-01 18:01:37 +00:00

knoflook commented

2021-10-01 18:34:48 +00:00

once coop-cloud/tagcmp#3 gets merged I'll open a PR to close this issue! In the meantime you can check it out here: https://git.coopcloud.tech/coop-cloud/abra/compare/main...knoflook:recipe-upgrade

once https://git.coopcloud.tech/coop-cloud/tagcmp/pulls/3 gets merged I'll open a PR to close this issue! In the meantime you can check it out here: https://git.coopcloud.tech/coop-cloud/abra/compare/main...knoflook:recipe-upgrade

decentral1se commented

2021-10-02 21:11:24 +00:00

should it upgrade to 1.5.0? I'd say yes but I'd love some input on that.

I would say rather bail out? In this case, there is no major version available (it should be 2.0.0 if you pass --major, right?) and the automation should rather try to run --minor. If I'm reading this right...

once coop-cloud/tagcmp#3 gets merged

will review now 💯

> should it upgrade to 1.5.0? I'd say yes but I'd love some input on that. I would say rather bail out? In this case, there is no major version available (it should be `2.0.0` if you pass `--major`, right?) and the automation should rather try to run `--minor`. If I'm reading this right... > once https://git.coopcloud.tech/coop-cloud/tagcmp/pulls/3 gets merged will review now 💯

knoflook commented

2021-10-03 07:30:50 +00:00

(it should be 2.0.0 if you pass --major, right?)

this makes sense. I see two approaches to this though:

--major/minor/patch specifies the type of upgrade you want to do
--major/minor/parch specifies the most serious type of upgrade you want to do

the first is good because it makes more semantical sense, but when you're upgrading an app you might need to type the command 2 times (to correct for a lack of major upgrade in this case).
My thinking was that if you are ready to do a major version upgrade you're also ready to do a minor version upgrade, so we could just throw a warning there (that the automation can put into its logs). That way we avoid having to invoke the command 2 times manually or having to write error checking on the automation side (it's still possible for an automation script to bail out if it sees a warning, right?)

> (it should be 2.0.0 if you pass --major, right?) this makes sense. I see two approaches to this though: 1. --major/minor/patch specifies the type of upgrade you want to do 2. --major/minor/parch specifies the **most serious** type of upgrade you want to do the first is good because it makes more semantical sense, but when you're upgrading an app you might need to type the command 2 times (to correct for a lack of major upgrade in this case). My thinking was that if you are ready to do a major version upgrade you're also ready to do a minor version upgrade, so we could just throw a warning there (that the automation can put into its logs). That way we avoid having to invoke the command 2 times manually or having to write error checking on the automation side (it's still possible for an automation script to bail out if it sees a warning, right?)

knoflook referenced this issue from toolshed/abra

2021-10-03 08:19:17 +00:00

feat: upgrade an app with no user input with --minor/major/patch flag #104

decentral1se commented

2021-10-03 09:37:12 +00:00

Yep this all sounds wise 🚀