abra app cp doesn't understand - any more #200

New Issue

3wordchant · 2021-10-13T09:03:53Z

3wordchant commented

2021-10-13 09:03:53 +00:00

Steps to reproduce

➜ tar -c * | abra app cp customhtml_sophielewis_lasophielle - app:/usr/share/nginx/html

Describe the expected behavior

All files in current directory copied to /usr/share/nginx/html

Describe the current behavior

FATA[0003] '-' does not exist?

Additional information

version: dev-8448949

## Steps to reproduce `➜ tar -c * | abra app cp customhtml_sophielewis_lasophielle - app:/usr/share/nginx/html` ## Describe the expected behavior - All files in current directory copied to `/usr/share/nginx/html` ## Describe the current behavior `FATA[0003] '-' does not exist?` ## Additional information  - version: dev-8448949

3wordchant added the

bug

abra

labels 2021-10-13 09:03:53 +00:00

decentral1se commented

2021-10-13 13:55:38 +00:00

Oh yeah I remember this...I think you can just pass the directory now? It does the tar'ing internally. I had no idea how to make the - input work at the time but could look into it again. Can you play around with the path argument and see if it works out 🙏

Oh yeah I remember this...I think you can just pass the directory now? It does the tar'ing internally. I had no idea how to make the `-` input work at the time but could look into it again. Can you play around with the path argument and see if it works out 🙏

3wordchant added the

enhancement

label 2021-10-13 23:07:34 +00:00

3wordchant commented

2021-10-14 00:02:38 +00:00

Wow that's even better @decentral1se, another huge win for gobra :met

Leaving this gently open as an "enhancement" to track support for remaining long tail of madcap inter-server one-liners:

xclip -o -selection clipboard | abra app cp customhtml_sophielewis_lasophielle - app:/usr/share/nginx/html/index.html

(paste the HTML file in the clipboard to a remote server...)

Wow that's even better @decentral1se, another huge win for gobra :met Leaving this gently open as an "enhancement" to track support for remaining long tail of madcap inter-server one-liners: ``` xclip -o -selection clipboard | abra app cp customhtml_sophielewis_lasophielle - app:/usr/share/nginx/html/index.html ``` (paste the HTML file in the clipboard to a remote server...)

🎉 1

decentral1se removed the

bug

label 2021-10-14 10:34:09 +00:00

roxxers commented

2021-10-20 08:21:20 +00:00

@3wordchant There is a way to make this work. urfave/cli won't mess with the solo - but we will need to check for it ourselves. Then when we find the - we can make the replacement of that arg to read stdin. Make this a custom handling for this command. Do you only do the contents of the files here when using bashbra or does it know when its a path? I think we need to do that parsing manually. I could get on it if you can describe how bashbra would react to that in different ways.

@3wordchant There is a way to make this work. urfave/cli won't mess with the solo `-` but we will need to check for it ourselves. Then when we find the `-` we can make the replacement of that arg to read stdin. Make this a custom handling for this command. Do you only do the contents of the files here when using bashbra or does it know when its a path? I think we need to do that parsing manually. I could get on it if you can describe how bashbra would react to that in different ways.

3wordchant commented

2021-10-20 10:21:55 +00:00

@roxxers awesome 🤘

Do you only do the contents of the files here when using bashbra or does it know when its a path?

Not sure I understand this bit, could you expand any?

Do you only do the contents of the files here when using bashbra or does it know when its a path?

I think all the --handling comes from the underlying docker cp command, all bashbra does is translate service names to container IDs before throwing the args at it.

Some examples:

babra app foobar cp - app:/usr/share/nginx/html/index.html → copies the stream from STDIN to index.html
babra app foobar cp app:/usr/share/nginx/html/index.html - → streams index.html to STDOUT (although this is less critical cos it could be implemented with an abra app run foobar cat ...)

@roxxers awesome 🤘 > Do you only do the contents of the files here when using bashbra or does it know when its a path? Not sure I understand this bit, could you expand any? > Do you only do the contents of the files here when using bashbra or does it know when its a path? I think all the `-`-handling comes from the underlying `docker cp` command, all bashbra does is translate service names to container IDs before throwing the args at it. Some examples: `babra app foobar cp - app:/usr/share/nginx/html/index.html` → copies the stream from STDIN to `index.html` `babra app foobar cp app:/usr/share/nginx/html/index.html -` → streams `index.html` to STDOUT (although this is less critical cos it could be implemented with an `abra app run foobar cat ...`)

decentral1se referenced this issue

2021-11-13 22:19:30 +00:00

Make `abra cp` support multiple source files #125

3wordchant referenced this issue

2023-11-11 21:04:19 +00:00

allow rename during `abra app cp` (and general `app cp` improvements) #534

decentral1se commented

2024-12-31 16:51:18 +00:00

Still doesn't work out of the box (different error messages 😭) but there is some hope: https://github.com/spf13/cobra/issues/1749 It would be nice to have this back now that we're rid of that borked CLI lib 👀

Sign in to join this conversation.

3 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: toolshed/organising#200

abra app cp doesn't understand - any more #200

Steps to reproduce

Describe the expected behavior

Describe the current behavior

Additional information

`abra app cp` doesn't understand `-` any more #200