If missing ~/.ssh/known_hosts entry for host, abra app ls explodes #234

New Issue

decentral1se · 2021-11-05T09:05:09Z

decentral1se commented

2021-11-05 09:05:09 +00:00

Describe the current behavior

abra app ls -S explodes with 15 ssh host key checks.

Steps to reproduce

rm ~/.ssh/known_hosts && abra app ls -S

Describe the expected behavior

It works. Servers get listed.

Any idea how this might be fixed?

I think we need to teach abra itself how to do host key checks or potentially more unstable, pass no host key check option when making SSH connections and warn folks that this is the case.

## Describe the current behavior `abra app ls -S` explodes with 15 ssh host key checks. ## Steps to reproduce `rm ~/.ssh/known_hosts && abra app ls -S` ## Describe the expected behavior It works. Servers get listed. ## Any idea how this might be fixed? I think we need to teach `abra` itself how to do host key checks or potentially more unstable, pass no host key check option when making SSH connections and warn folks that this is the case.

decentral1se added this to the (deleted) milestone 2021-11-05 09:05:09 +00:00

decentral1se added the

bug

abra

labels 2021-11-05 09:05:09 +00:00

decentral1se added this to the Beta release (software) project 2021-11-05 09:05:09 +00:00

decentral1se commented

2021-11-05 09:24:11 +00:00

Also related: coop-cloud/organising#142

Also related: https://git.coopcloud.tech/coop-cloud/organising/issues/142

decentral1se referenced this issue

2021-11-05 09:24:20 +00:00

Run ssh-keygen on new hosts to avoid gnarly SSH warnings/errors #142

decentral1se commented

2021-11-05 10:06:23 +00:00

This does make it all Just Work ™️

This would be easiest for us....

Will investigate making abra manage host key checking itself also.

diff --git a/pkg/upstream/commandconn/connection.go b/pkg/upstream/commandconn/connection.go
index 46dfc83..ecbc5d6 100644
--- a/pkg/upstream/commandconn/connection.go
+++ b/pkg/upstream/commandconn/connection.go
@@ -19,7 +19,7 @@ import (
 //
 // ssh://<user>@<host> URL requires Docker 18.09 or later on the remote host.
 func GetConnectionHelper(daemonURL string) (*connhelper.ConnectionHelper, error) {
-       return getConnectionHelper(daemonURL, []string{"-o ConnectTimeout=5"})
+       return getConnectionHelper(daemonURL, []string{"-o ConnectTimeout=5", "-o StrictHostKeyChecking=no"})
 }
 
 func getConnectionHelper(daemonURL string, sshFlags []string) (*connhelper.ConnectionHelper, error) {

This does make it all Just Work ™️ This would be easiest for us.... Will investigate making `abra` manage host key checking itself also. ```diff diff --git a/pkg/upstream/commandconn/connection.go b/pkg/upstream/commandconn/connection.go index 46dfc83..ecbc5d6 100644 --- a/pkg/upstream/commandconn/connection.go +++ b/pkg/upstream/commandconn/connection.go @@ -19,7 +19,7 @@ import ( // // ssh://<user>@<host> URL requires Docker 18.09 or later on the remote host. func GetConnectionHelper(daemonURL string) (*connhelper.ConnectionHelper, error) { - return getConnectionHelper(daemonURL, []string{"-o ConnectTimeout=5"}) + return getConnectionHelper(daemonURL, []string{"-o ConnectTimeout=5", "-o StrictHostKeyChecking=no"}) } func getConnectionHelper(daemonURL string, sshFlags []string) (*connhelper.ConnectionHelper, error) { ```

decentral1se commented

2021-11-05 10:40:57 +00:00