publishing recipe version failed #290

New Issue

trav · 2022-01-14T14:26:20Z

trav commented

2022-01-14 14:26:20 +00:00

Describe the current behavior

made the tag but didn't commit the label change

Steps to reproduce

try running abra recipe sync and then abra recipe release. We did it with Loomio.

Describe the expected behavior

Any idea how this might be fixed?

Additional information

abra version 0.3.0-alpha-de7054f

publish new release? Yes
FATA[0002] already up-to-date                            caller="/drone/src/cli/recipe/release.go:204 createReleaseFromTag" stack="/drone/src/cli/
recipe/release.go:204                       createReleaseFromTag\n/drone/src/cli/recipe/release.go:114                       glob..func5\n/go/pkg$
mod/github.com/urfave/cli/v2@v2.3.0/command.go:163 (*Command).Run\n/go/pkg/mod/github.com/urfave/cli/v2@v2.3.0/app.go:434     (*App).RunAsSubcomm$
nd\n/go/pkg/mod/github.com/urfave/cli/v2@v2.3.0/command.go:278 (*Command).startApp\n/go/pkg/mod/github.com/urfave/cli/v2@v2.3.0/command.go:94  (*$
ommand).Run\n/go/pkg/mod/github.com/urfave/cli/v2@v2.3.0/app.go:313     (*App).RunContext\n/go/pkg/mod/github.com/urfave/cli/v2@v2.3.0/app.go:224 
    RunApp\n/drone/src/cli/cli.go:215                                  RunApp\n/drone/src/cmd/abra/main.go:22                             main\n/$
sr/local/go/src/runtime/proc.go:255                      main\n/usr/local/go/src/runtime/asm_amd64.s:1581                 goexit"
t:~/.abra/apps/loomio$ git diff
diff --git a/compose.yml b/compose.yml
index 30eeb35..a3fca49 100644
--- a/compose.yml
+++ b/compose.yml
@@ -56,7 +56,7 @@ services:
         - "traefik.http.routers.${STACK_NAME}.rule=Host(`${DOMAIN}`${EXTRA_DOMAINS})"
         - "traefik.http.routers.${STACK_NAME}.entrypoints=web-secure"
         - "traefik.http.routers.${STACK_NAME}.tls.certresolver=${LETS_ENCRYPT_ENV}"
-        - coop-cloud.${STACK_NAME}.app.version=v2.7.9-8007a47b
+        - coop-cloud.${STACK_NAME}.version=0.1.0+v2.7.10
   worker:
     image: loomio/loomio:v2.7.10
     networks:

## Describe the current behavior made the tag but didn't commit the label change ## Steps to reproduce try running `abra recipe sync` and then `abra recipe release`. We did it with Loomio. ## Describe the expected behavior ## Any idea how this might be fixed? ## Additional information  abra version 0.3.0-alpha-de7054f ``` publish new release? Yes FATA[0002] already up-to-date caller="/drone/src/cli/recipe/release.go:204 createReleaseFromTag" stack="/drone/src/cli/ recipe/release.go:204 createReleaseFromTag\n/drone/src/cli/recipe/release.go:114 glob..func5\n/go/pkg$ mod/github.com/urfave/cli/v2@v2.3.0/command.go:163 (*Command).Run\n/go/pkg/mod/github.com/urfave/cli/v2@v2.3.0/app.go:434 (*App).RunAsSubcomm$ nd\n/go/pkg/mod/github.com/urfave/cli/v2@v2.3.0/command.go:278 (*Command).startApp\n/go/pkg/mod/github.com/urfave/cli/v2@v2.3.0/command.go:94 (*$ ommand).Run\n/go/pkg/mod/github.com/urfave/cli/v2@v2.3.0/app.go:313 (*App).RunContext\n/go/pkg/mod/github.com/urfave/cli/v2@v2.3.0/app.go:224 RunApp\n/drone/src/cli/cli.go:215 RunApp\n/drone/src/cmd/abra/main.go:22 main\n/$ sr/local/go/src/runtime/proc.go:255 main\n/usr/local/go/src/runtime/asm_amd64.s:1581 goexit" t:~/.abra/apps/loomio$ git diff diff --git a/compose.yml b/compose.yml index 30eeb35..a3fca49 100644 --- a/compose.yml +++ b/compose.yml @@ -56,7 +56,7 @@ services: - "traefik.http.routers.${STACK_NAME}.rule=Host(`${DOMAIN}`${EXTRA_DOMAINS})" - "traefik.http.routers.${STACK_NAME}.entrypoints=web-secure" - "traefik.http.routers.${STACK_NAME}.tls.certresolver=${LETS_ENCRYPT_ENV}" - - coop-cloud.${STACK_NAME}.app.version=v2.7.9-8007a47b + - coop-cloud.${STACK_NAME}.version=0.1.0+v2.7.10 worker: image: loomio/loomio:v2.7.10 networks: ```

trav added the

bug

abra

labels 2022-01-14 14:26:20 +00:00

3wordchant commented

2022-01-16 22:54:59 +00:00

Just ran into this on Nextcloud.

recipe sync didn't result in any file changes.

On recipe release, initially I got this:

➜ abra recipe release nextcloud
WARN[0000] discovered 1.20.0-ea4560b8 as currently synced recipe label 
WARN[0000] no tag specified and no previous tag available for nextcloud, assuming this is the initial release 
FATA[0000] no changes discovered in /home/u/.abra/apps/nextcloud, nothing to publish?

and then after making some changes to tidy up labels, to give it some uncommitted changes:

➜ abra recipe release nextcloud
WARN[0001] discovered 22.1.0-fpm-d1c56487 as currently synced recipe label 
WARN[0001] no tag specified and no previous tag available for nextcloud, assuming this is the initial release 
? publish new release? Yes
FATA[0004] already up-to-date

Just ran into this on Nextcloud. `recipe sync` didn't result in any file changes. On `recipe release`, initially I got this: ``` ➜ abra recipe release nextcloud WARN[0000] discovered 1.20.0-ea4560b8 as currently synced recipe label WARN[0000] no tag specified and no previous tag available for nextcloud, assuming this is the initial release FATA[0000] no changes discovered in /home/u/.abra/apps/nextcloud, nothing to publish? ``` and then after making some changes to tidy up labels, to give it some uncommitted changes: ``` ➜ abra recipe release nextcloud WARN[0001] discovered 22.1.0-fpm-d1c56487 as currently synced recipe label WARN[0001] no tag specified and no previous tag available for nextcloud, assuming this is the initial release ? publish new release? Yes FATA[0004] already up-to-date ```

decentral1se commented

2022-01-18 09:16:11 +00:00

hey @trav @3wordchant both recipes are using the old recipe labelling scheme and I think abra 0.3.x was a bit borked for this logic.

for nextcloud, i pushed 262d61cd0e, now when I run abra recipe sync nextcloud, the correct label is applied.

for loomio, i pushed 0b65d69636, sync now works also.

i'm using the latest RC (abra upgrade --rc).

if you wanna publish your recipe, you can pass --publish on the recipe release command. Perhaps try without first and inspect the changes in ~/.abra/catalogue git repository to see if things are correct.

then you can run abra catalogue generate -p <recipe> to publish to https://git.coopcloud.tech/coop-cloud/recipes so that abra can read it.

hey @trav @3wordchant both recipes are using the old recipe labelling scheme and I think abra 0.3.x was a bit borked for this logic. for nextcloud, i pushed https://git.coopcloud.tech/coop-cloud/nextcloud/commit/262d61cd0e5a28d8e616ef2ef692a9835b863c9d, now when I run `abra recipe sync nextcloud`, the correct label is applied. for loomio, i pushed https://git.coopcloud.tech/coop-cloud/loomio/commit/0b65d69636879889f4c85fd1d7f4491a6483c1ff, sync now works also. i'm using the latest RC (`abra upgrade --rc`). if you wanna publish your recipe, you can pass `--publish` on the `recipe release` command. Perhaps try without first and inspect the changes in `~/.abra/catalogue` git repository to see if things are correct. then you can run `abra catalogue generate -p <recipe>` to publish to https://git.coopcloud.tech/coop-cloud/recipes so that `abra` can read it.

decentral1se commented

2022-01-18 09:17:09 +00:00

also just hmu if you wanna do this together. we can also write documentation soon.

decentral1se added

awaiting-feedback

and removed

bug

labels 2022-01-18 09:17:30 +00:00

decentral1se closed this issue

2022-02-09 17:44:10 +00:00

Sign in to join this conversation.