toolshed/organising
7
1
Fork 0
Code Issues 100 Pull Requests Releases Activity

"foo + unstaged changes" written to .env file #651

New Issue
Closed
opened 2024-12-02 00:31:29 +00:00 by decentral1se · 5 comments
decentral1se commented 2024-12-02 00:31:29 +00:00
Owner
Copy Link

Ran into this with @knoflook, don't have a reproduction now. But we've seen that a chaos version ala foo + unstaged changes gets commited to the .env as-is, so you have RECIPE=foo + unstaged changes written in the file and this obviously explodes instantly 😂

Ran into this with @knoflook, don't have a reproduction now. But we've seen that a chaos version ala `foo + unstaged changes` gets commited to the `.env` as-is, so you have `RECIPE=foo + unstaged changes` written in the file and this obviously explodes instantly 😂
decentral1se added the
bug
abra
 labels 2024-12-02 00:31:29 +00:00
p4u1 commented 2024-12-02 13:39:29 +00:00
Member
Copy Link

I can have a look at this. Will try to make it to the kite flying hour this week

I can have a look at this. Will try to make it to the kite flying hour this week
🚀 1
p4u1 commented 2024-12-28 13:07:38 +00:00
Member
Copy Link

I'm not totally sure what to do here. When writing foo + unstaged changes it indicates that a chaos version is currently deployed. Which would be important for coworkers. But maybe this is an information we should store on the server with a label instead?

I'm not totally sure what to do here. When writing `foo + unstaged changes` it indicates that a chaos version is currently deployed. Which would be important for coworkers. But maybe this is an information we should store on the server with a label instead?
decentral1se commented 2024-12-28 14:48:09 +00:00
Author
Owner
Copy Link

@p4u1 in coop-cloud/abra#454 I'm re-working + unstaged changes to be +U so this can be shown more compactly in overviews (re: decentral1se/cctuip#1 / #447).

In general, I think it would be nice to show this fact in the label, that there are unstaged changes deployed (beyond just a regular chaos commit) and you'd better check out with your coworkers what is going on before touching the app (you will not know who tho until we coop-cloud/organising#467).

recipe.ChaosVersion() does handle the inclusion of this marker for all code paths AFAICT.

The problem is that when you try to deploy again and it reads the value from the .env, then it explodes because <hash>+U is not something you can git checkout. We need to parse that part off when doing git ops?

I'm gonna merge coop-cloud/abra#454 and run the integration test suite. I think after merging, this one can be picked up properly.

@p4u1 in https://git.coopcloud.tech/coop-cloud/abra/pulls/454 I'm re-working `+ unstaged changes` to be `+U` so this can be shown more compactly in overviews (re: https://git.coopcloud.tech/decentral1se/cctuip/issues/1 / https://git.coopcloud.tech/toolshed/organising/issues/447). In general, I think it would be nice to show this fact in the label, that there are unstaged changes deployed (beyond just a regular chaos commit) and you'd better check out with your coworkers what is going on before touching the app (you will not know who tho until we https://git.coopcloud.tech/coop-cloud/organising/issues/467). `recipe.ChaosVersion()` does handle the inclusion of this marker for all code paths AFAICT. The problem is that when you try to deploy again and it reads the value from the `.env`, then it explodes because `<hash>+U` is not something you can `git checkout`. We need to parse that part off when doing git ops? I'm gonna merge https://git.coopcloud.tech/coop-cloud/abra/pulls/454 and run the integration test suite. I think after merging, this one can be picked up properly.
decentral1se commented 2024-12-29 18:18:53 +00:00
Author
Owner
Copy Link

@p4u1 lemme know if you can pick this one up this week, otherwise, I can take a stab at it. Just this and #467 left to close off 🧨

@p4u1 lemme know if you can pick this one up this week, otherwise, I can take a stab at it. Just this and https://git.coopcloud.tech/toolshed/organising/issues/467 left to close off 🧨
decentral1se commented 2024-12-30 19:22:13 +00:00
Author
Owner
Copy Link

Related: #662

Related: https://git.coopcloud.tech/toolshed/organising/issues/662
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
abra
Everything to do with abra
abra-gandi
Abra Gandi plugin
awaiting-feedback
Ping/pong on comms
backups
bug
Something is not working
build
Go build related issues
ci/cd
Getting the robots into the mix
community organising
Opening this thing up
contributing
Contributors stuff
coopcloud.tech
Our main website
democracy
Democratic decision making
design
Design thinking required
documentation
Let's write things together
duplicate
This issue or pull request already exists
enhancement
New feature
finance
Money things
funding
Anything related to grant funding
good first issue
Easy start with development
help wanted
Need some help
installer
Installation related issues
kadabra
performance
Performance related
proposal
Large change which requires feedback & decisin making
question
More information is needed
recipes.coopcloud.tech
Our recipes catalogue
security
Securing our shit
test
Unit or integration test suite
wontfix
This won't be fixed
No Label
abra
bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
3wordchant aadil abra-bot ammaratef45 Apfelwurm carla cas coopcloud cyrnel decentral1se fauno iexos jade jmakdah2 joe-irving kawaiipunk knoflook kolaente lambdabundesverband linnealovespie moritz notplants p4u1 pharaohgraphy renovate-bot ripclap simon sixsmith trav val yksflip
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: toolshed/organising#651
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?