"foo + unstaged changes" written to .env file #651

New Issue

2024-12-02T00:31:29Z

decentral1se commented

2024-12-02 00:31:29 +00:00

Ran into this with @knoflook, don't have a reproduction now. But we've seen that a chaos version ala foo + unstaged changes gets commited to the .env as-is, so you have RECIPE=foo + unstaged changes written in the file and this obviously explodes instantly 😂

Ran into this with @knoflook, don't have a reproduction now. But we've seen that a chaos version ala `foo + unstaged changes` gets commited to the `.env` as-is, so you have `RECIPE=foo + unstaged changes` written in the file and this obviously explodes instantly 😂

decentral1se added the bug abra labels 2024-12-02 00:31:29 +00:00

p4u1 commented

2024-12-02 13:39:29 +00:00

I can have a look at this. Will try to make it to the kite flying hour this week

🚀 1

~~decentral1se referenced this issue 2024-12-21 19:28:13 +00:00~~

`abra` v0.10.x-beta release planning #583

p4u1 commented

2024-12-28 13:07:38 +00:00

I'm not totally sure what to do here. When writing foo + unstaged changes it indicates that a chaos version is currently deployed. Which would be important for coworkers. But maybe this is an information we should store on the server with a label instead?

I'm not totally sure what to do here. When writing `foo + unstaged changes` it indicates that a chaos version is currently deployed. Which would be important for coworkers. But maybe this is an information we should store on the server with a label instead?

decentral1se commented

2024-12-28 14:48:09 +00:00

@p4u1 in coop-cloud/abra#454 I'm re-working + unstaged changes to be +U so this can be shown more compactly in overviews (re: decentral1se/cctuip#1 / #447).

In general, I think it would be nice to show this fact in the label, that there are unstaged changes deployed (beyond just a regular chaos commit) and you'd better check out with your coworkers what is going on before touching the app (you will not know who tho until we coop-cloud/organising#467).

recipe.ChaosVersion() does handle the inclusion of this marker for all code paths AFAICT.

The problem is that when you try to deploy again and it reads the value from the .env, then it explodes because <hash>+U is not something you can git checkout. We need to parse that part off when doing git ops?

I'm gonna merge coop-cloud/abra#454 and run the integration test suite. I think after merging, this one can be picked up properly.

@p4u1 in https://git.coopcloud.tech/coop-cloud/abra/pulls/454 I'm re-working `+ unstaged changes` to be `+U` so this can be shown more compactly in overviews (re: https://git.coopcloud.tech/decentral1se/cctuip/issues/1 / https://git.coopcloud.tech/toolshed/organising/issues/447). In general, I think it would be nice to show this fact in the label, that there are unstaged changes deployed (beyond just a regular chaos commit) and you'd better check out with your coworkers what is going on before touching the app (you will not know who tho until we https://git.coopcloud.tech/coop-cloud/organising/issues/467). `recipe.ChaosVersion()` does handle the inclusion of this marker for all code paths AFAICT. The problem is that when you try to deploy again and it reads the value from the `.env`, then it explodes because `<hash>+U` is not something you can `git checkout`. We need to parse that part off when doing git ops? I'm gonna merge https://git.coopcloud.tech/coop-cloud/abra/pulls/454 and run the integration test suite. I think after merging, this one can be picked up properly.

decentral1se commented

2024-12-29 18:18:53 +00:00

@p4u1 lemme know if you can pick this one up this week, otherwise, I can take a stab at it. Just this and #467 left to close off 🧨

@p4u1 lemme know if you can pick this one up this week, otherwise, I can take a stab at it. Just this and https://git.coopcloud.tech/toolshed/organising/issues/467 left to close off 🧨

p4u1 referenced this issue from toolshed/abra

2024-12-30 14:49:35 +00:00

fix: Throws an error when trying to deploy unstaged changes version #458

decentral1se referenced this issue

2024-12-30 17:39:17 +00:00

Chaos deploy written to .env overrides stable deploy #662

decentral1se commented

2024-12-30 19:22:13 +00:00