Improve colours for logging #659

New Issue

decentral1se · 2024-12-27T22:21:56Z

decentral1se commented

2024-12-27 22:21:56 +00:00

Currently quite intense and randomly copy/pasta'd from somewhere. They needs some tweaking... does anyone have a proposal? We'll be look at these colours a lot in the future...

4e8995cc0e/pkg/log/log.go (L38-L75)

Currently quite intense and randomly copy/pasta'd from somewhere. They needs some tweaking... does anyone have a proposal? We'll be look at these colours a lot in the future... <img width="109" alt="image" src="attachments/f1c3b972-39b7-4f58-b864-4a0b61455d66"> https://git.coopcloud.tech/coop-cloud/abra/src/commit/4e8995cc0e1fc5f8982d8af5c9f98f597d8a89b6/pkg/log/log.go#L38-L75

image.png

8.3 KiB

decentral1se added the

bug

abra

labels 2024-12-27 22:21:56 +00:00

~~decentral1se referenced this issue 2024-12-27 22:22:07 +00:00~~

`abra` v0.10.x-beta release planning #583

ammaratef45 commented

2024-12-29 06:49:18 +00:00

I think Foreground should be consistent and duplicate code should be reduced by using a new func

func style(level, background) {  
  return lipgloss.NewStyle().
			SetString(strings.ToUpper(level.String())).
			Bold(true).
			Padding(0, 1, 0, 1).
			Background(lipgloss.Color(background)).
			Foreground(lipgloss.Color("15"))
}

I think Foreground should be consistent and duplicate code should be reduced by using a new func ``` go func style(level, background) { return lipgloss.NewStyle(). SetString(strings.ToUpper(level.String())). Bold(true). Padding(0, 1, 0, 1). Background(lipgloss.Color(background)). Foreground(lipgloss.Color("15")) } ```

👍 1

decentral1se commented

2024-12-30 17:07:34 +00:00

There was an idea to go with the Co-op Cloud "brand palette" but also, another idea: charm defaults are also pretty OK. I removed the coloured background which was kinda bit too much. We can change this up in the future if any cares enough. Thanks all! 994310a4ff

There was an idea to go with the Co-op Cloud "brand palette" but also, another idea: charm defaults are also pretty OK. I removed the coloured background which was kinda bit too much. We can change this up in the future if any cares enough. Thanks all! https://git.coopcloud.tech/coop-cloud/abra/commit/994310a4ff1bcbf25efe0da56a4d35ffa5571af8

decentral1se closed this issue

2024-12-30 17:07:34 +00:00

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: toolshed/organising#659