Reports success in Drone even when the deployment failed #1

New Issue

2020-09-25T10:28:11Z

3wordchant commented

2020-09-25 10:28:11 +00:00

I guess a return code is getting lost somewhere? e.g. https://drone.autonomic.zone/compose-stacks/traefik/1/1/2:

failed to create config traefik_traefik_yml_: Error response from daemon: rpc error: code = InvalidArgument desc = invalid name, only 64 [a-zA-Z0-9-_.] characters allowed, and the start and end character must be [a-zA-Z0-9]
--- end deployment ---

I guess a return code is getting lost somewhere? e.g. https://drone.autonomic.zone/compose-stacks/traefik/1/1/2: ``` failed to create config traefik_traefik_yml_: Error response from daemon: rpc error: code = InvalidArgument desc = invalid name, only 64 [a-zA-Z0-9-_.] characters allowed, and the start and end character must be [a-zA-Z0-9] --- end deployment --- ```

3wordchant referenced this issue from toolshed/organising

2020-09-25 10:38:52 +00:00

Integration testing #8

decentral1se commented

2020-09-25 11:02:09 +00:00

Soooo, apparently https://git.autonomic.zone/autonomic-cooperative/stack-ssh-deploy/src/branch/main/plugin.sh#L3 fixes this! I've changed the target tag of stack-ssh-deploy to latest and updated configurations that used to point to 0.0.1. I will try to test that this is indeed the right fix now on the new traefik CI.

Soooo, apparently https://git.autonomic.zone/autonomic-cooperative/stack-ssh-deploy/src/branch/main/plugin.sh#L3 fixes this! I've changed the target tag of stack-ssh-deploy to `latest` and updated configurations that used to point to `0.0.1`. I will try to test that this is indeed the right fix now on the new traefik CI.

❤️ 1

decentral1se closed this issue

2020-09-25 11:27:55 +00:00

decentral1se commented

2020-09-25 11:28:30 +00:00