Teach tagcmp to handle tags with dates in them #19

New Issue

2023-04-30T00:53:30Z

3wordchant commented

2023-04-30 00:53:30 +00:00

Minio uses the fun and original tag format RELEASE.2021-04-22T15-44-28Z, with an optional -something at the end.

The tagcmp README correctly notes that this isn't currently supported in tagcmp.

Could it be?

Parsing dates can be a bit nightmarish, but I think it would be fair enough to ignore anything that's not strictly ISO 8601-compliant, if that makes it easier enough to consider implementing: we could add further wacky formats if and when needed.

Probably worth checking for these kinds of tags last, if nothing else matches, just in case we run into something like x.y.z-2021-04-22T15-44-28Z where x.y.z is a fine semver that we'd prefer to use.

Minio uses the fun and original tag format `RELEASE.2021-04-22T15-44-28Z`, with an optional `-something` at the end. The `tagcmp` README correctly notes that this isn't currently supported in `tagcmp`. Could it be? Parsing dates can be a bit nightmarish, but I think it would be fair enough to ignore anything that's not strictly [ISO 8601](https://en.wikipedia.org/wiki/ISO_8601)-compliant, if that makes it easier enough to consider implementing: we could add further wacky formats if and when needed. Probably worth checking for these kinds of tags last, if nothing else matches, just in case we run into something like `x.y.z-2021-04-22T15-44-28Z` where `x.y.z` is a fine semver that we'd prefer to use.

👍 1

decentral1se added the enhancement label 2023-09-23 05:51:12 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: toolshed/tagcmp#19