Ending a plan's delivery runs the same four steps in three places, with the pool locked at different points #180

New Issue

2026-10-06T21:25:01Z

cgalo5758 commented

2026-10-06 21:25:01 +00:00

When a plan stops delivering, the console ends its positions, resumes the grants it replaced if anything ended, restores the org-type default if the ladder is vacant, and recomputes the pool. Resumption must precede the default. The sequence is written in RevokeGrantTx and ExpireGrantTx (internal/entitlements/grant_acts.go) and in the ended branch of ReconcileSubscription (internal/fulfillment/reconcile.go). Revocation and expiry lock the pool first; the subscription path ends positions first and locks the pool only when resumption starts. A purchase source would add a fourth copy.

Done when: one entitlements act, given the pool, the ended source and an actor, locks the pool first and runs the four steps; the three callers use it; and a test ends a subscription concurrently with an operator act on the same pool. If #154 merges the default and resumption, it happens inside this act.

When a plan stops delivering, the console ends its positions, resumes the grants it replaced if anything ended, restores the org-type default if the ladder is vacant, and recomputes the pool. Resumption must precede the default. The sequence is written in `RevokeGrantTx` and `ExpireGrantTx` (`internal/entitlements/grant_acts.go`) and in the ended branch of `ReconcileSubscription` (`internal/fulfillment/reconcile.go`). Revocation and expiry lock the pool first; the subscription path ends positions first and locks the pool only when resumption starts. A purchase source would add a fourth copy. Done when: one entitlements act, given the pool, the ended source and an actor, locks the pool first and runs the four steps; the three callers use it; and a test ends a subscription concurrently with an operator act on the same pool. If #154 merges the default and resumption, it happens inside this act.

cgalo5758 added the

kind

design

area/entitlements area/billing labels 2026-10-06 21:25:01 +00:00

cgalo5758 referenced this issue

2026-10-06 21:25:45 +00:00

Locks are written out at each call site, with four key conventions and no written order #186

cgalo5758 referenced this issue from a commit

2026-10-11 00:00:51 +00:00

Characterize the subscription reconcile per status

Sign in to join this conversation.