The console connects to its database as a superuser, so the privilege revokes bind nothing #23
Closed
opened 2026-09-21 07:18:08 +00:00 by cgalo5758
·
1 comment
Labels
Clear labels
accessibility
area/billing
area/catalog
area/discourse
area/domains
area/entitlements
area/fedwiki
area/identity
area/integrations
area/licensing
area/member-ui
area/meta
area/operator-ui
area/ops
area/testing
duplicate
good-first-issue
invalid
privacy
security
upstream
wontfix
A barrier for people using assistive technology or a keyboard alone.
The Stripe mirror, checkout, subscriptions, invoices, fulfillment.
Products, prices, plan ladders, purchasability.
The Discourse integration.
The domains registry, claims, placements, the certificate ask.
Entitlement sets, rules, grants, pools, provisioning.
The Federated Wiki integration and farm sync.
Sign-in, sessions, persons, organizations, workspaces, roles.
The provider registry, outbox and webhooks in general.
Licenses, the contributor agreement, SPDX headers.
Member pages.
The repository itself, its contributing guide, CI, the tracker and the workflow.
Operator pages, forms, lists, the design system.
Deployment, configuration, migrations, workflows, instance settings.
The test stack, screens, lint, walkthroughs.
Closed because another issue already covers it.
Small, self-contained, and explained enough to be a first contribution.
Closed because it is not a ticket for this repository.
Touches what a person's data reveals.
Touches authentication, authorization, secrets or data exposure.
Waits on another repository or project before it can move.
Closed because it will not be done, with the reason in the last comment.
kind
bug
The software does something other than what it promises; closed when it again does what it promises.
kind
debt
Code, tests or tooling to clean up with nothing visible changing; closed when they are cleaner.
kind
design
A question to settle before work can be defined; closed when the decision is written down.
kind
docs
Documentation that is wrong or missing; closed when it says the right thing.
kind
enhancement
Something the software does not do yet; closed when it does.
priority
critical
Blocks the active milestone or harms members now.
priority
high
Next in line inside the active milestone.
priority
low
Inside the active milestone, when nothing else is left.
priority
medium
Inside the active milestone, after the high ones.
Milestone
No items
No Milestone
Public launch
Projects
Clear projects
No projects
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: wiki-cafe/member-console#23
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
What happens
The migrations that enclose the entitlement ledger revoke direct writes on those tables from the writer role, so that only the enclosed functions can change them, and the console's login is granted that role. The login the console actually connects with is the database container's bootstrap user, which the database creates as a superuser, and a superuser bypasses every privilege check. The revokes are therefore inert wherever the console runs, in the test stack and in a deployment created the same way.
What should happen
The console connects as an ordinary role, so a stray write to an enclosed table is refused by the database rather than by convention, and the enclosure means what the schema says it means.
Where
The migration that creates the roles and the console's login; the test stack's compose file, where the login is the bootstrap user; the deployment documentation.
Steps
Connect as the console's configured login and write a row directly into one of the enclosed tables. The write succeeds. Set the role to the writer role first and the same write is refused, which is what the existing test does.
Why it matters
The enclosure is the last defence under the ledger and the reason the enclosed functions are the only documented way in. Today it holds only inside a test that sets the role by hand. The fix is a non-superuser login for the console in both stacks, the bootstrap superuser kept for migrations and operations, and a boot-time refusal to start as a superuser outside development mode.
Migrated from status/issues.md at
b7a0e15Fixed in
028e2ef4,40ce2d3d,3cdf7bbc,f9c9b322,dd4a0e2eande722e436.The console now connects as two users.
db-dsnnames a runtime user that serves every request: it is not a superuser, owns nothing, and holds its privileges throughconsole_runtime, a group role every module's writer is granted to. The newdb-migrate-dsnnames the user that runs migrations; at start the console migrates on that connection, grantsconsole_runtimeto the runtime user (inherited, withoutSET), and closes it before serving. The revokes that enclose the entitlement ledger now bind the console itself.The console refuses to start, with no exemption, on a configuration that would reopen the bypass: one user for both strings, a runtime user that is a superuser or can become one, owns the database or any object in it or can act as their owner, can create objects in the database or its schemas, holds any role but
console_runtime, or holds a privilege an enclosure withholds. Each refusal names the statement that fixes it. The checks that read nothing the migrations create run before any migration, and every check query runs withsearch_pathpinned topg_catalog, pg_tempand qualified names, so nothing the runtime user could plant runs in the migration user's session. Withdb-migrate-dsnleft out, the console runs no migration and refuses while the schema is behind, so a host can runmigrate upas a separate step and keep the migration password out of the running process.Four more fixes came with it, each listed in the change:
ALLon their tables, which includedTRIGGER; a user holding a writer could put a trigger on an ordinary table that aSECURITY DEFINERfunction writes, and the trigger then ran as the function's owner and wrote the enclosed tables directly. The writers now hold onlySELECT,INSERT,UPDATEandDELETE, and a catalog test fails on anything more.FOR UPDATEon an enclosed table, which needsUPDATE; it now takes the same lock through a function owned bycore_owner. Monthly webhook partitions are created the same way, since creating a partition needs the parent table's owner.migrate,configandseed-demoread the-fileform of the database setting, asstartdid.A deployment changes its configuration to upgrade: the next release refuses a superuser
db-dsn.docs/production-deployment.mdhas the steps for a deployment that has connected as one login so far; the bootstrap superuser of the official image cannot loseSUPERUSER, so it stays as the migration user.