A verified custom domain offers to create a site when the console cannot read whether one is already there #230

New Issue

2026-10-16T02:59:50Z

cgalo5758 commented

2026-10-16 02:59:50 +00:00

What happens

When a member's custom-domain claim is verified, the claim's view checks whether a site already sits at the domain (Registry.PlacementAt in renderCustomDomainStatus). If that read fails, the handler logs a warning and renders the view as if nothing were placed: the domain reads as verified and ready, and the one-click Create button appears. A member whose site already uses the domain is offered to create one there.

What should happen

A failed placement read shows that the domain could not be checked, and offers no create. Only a read that finds no placement offers the create. The create form already answers its own failed domain check this way: "Couldn't check that domain right now. Try again."

Where

internal/integrations/fedwiki/web/customdomain.go:407-411 (renderCustomDomainStatus)
internal/integrations/fedwiki/templates/fedwiki_custom_domain_pending.html:31-36 and :112 (the in-use message and the Create button)
internal/integrations/fedwiki/web/site_actions.go:84 (the create form's answer)

Steps

Found by reading the code; not reproduced.

Claim a custom domain, verify it, and create a site at it.
Open the claim's view (GET /partials/fedwiki/custom-domains/{claimID}) while the placement query fails.
The view offers to create a site at the domain instead of saying the domain is in use.

Why it matters

The view tells the member the domain is ready for a site when the console does not know. The create that follows checks the name again and refuses it, so nothing is created, but the member has first been told something the console could not check. The same class is filed for operator pages in #207 and for the member's plan positions in #197.

## What happens When a member's custom-domain claim is verified, the claim's view checks whether a site already sits at the domain (`Registry.PlacementAt` in `renderCustomDomainStatus`). If that read fails, the handler logs a warning and renders the view as if nothing were placed: the domain reads as verified and ready, and the one-click Create button appears. A member whose site already uses the domain is offered to create one there. ## What should happen A failed placement read shows that the domain could not be checked, and offers no create. Only a read that finds no placement offers the create. The create form already answers its own failed domain check this way: "Couldn't check that domain right now. Try again." ## Where - `internal/integrations/fedwiki/web/customdomain.go:407-411` (`renderCustomDomainStatus`) - `internal/integrations/fedwiki/templates/fedwiki_custom_domain_pending.html:31-36` and `:112` (the in-use message and the Create button) - `internal/integrations/fedwiki/web/site_actions.go:84` (the create form's answer) ## Steps Found by reading the code; not reproduced. 1. Claim a custom domain, verify it, and create a site at it. 2. Open the claim's view (`GET /partials/fedwiki/custom-domains/{claimID}`) while the placement query fails. 3. The view offers to create a site at the domain instead of saying the domain is in use. ## Why it matters The view tells the member the domain is ready for a site when the console does not know. The create that follows checks the name again and refuses it, so nothing is created, but the member has first been told something the console could not check. The same class is filed for operator pages in #207 and for the member's plan positions in #197.

cgalo5758 added the

labels 2026-10-16 02:59:50 +00:00

cgalo5758 referenced this issue

2026-10-16 03:00:02 +00:00

FedWiki's site usage is a running total that many code paths adjust; derive it instead #165

cgalo5758 referenced this issue

2026-10-22 18:40:11 +00:00