wiki-cafe/member-console
1
1
Fork 0
Code Issues 257 Pull Requests Packages Projects 1 Releases Activity

A failed read of the sites entitlement tells the member they have reached their site limit #231

New Issue
Closed
opened 2026-10-16 02:59:51 +00:00 by cgalo5758 · 1 comment
cgalo5758 commented 2026-10-16 02:59:51 +00:00
Owner
Copy Link
Copy Source

What happens

Before a site create, the create workflow asks CheckQuotaActivity (internal/integrations/fedwiki/workflows/activities.go:581) whether the workspace may have another site. The activity reads three things: the workspace's pool, the pool's fedwiki_sites entitlement and the pool's usage. A failed read of the pool or of the usage returns an error, and the workflow then fails the request as quota_unavailable (internal/integrations/fedwiki/workflows/requests.go:319-322), which the member reads as "Couldn't check your site limit. Try again later."

A failed read of the entitlement is handled differently. Any error from GetNumericEntitlementByPoolAndResource (activities.go:602-614), not only "no row", is answered as a quota of 0 with CanCreate false, and logged at Info as "no sites entitlement found" without the error. The workflow then declines the request as site_limit_reached (requests.go:323-325), and the member reads "You have reached your site limit." (internal/integrations/fedwiki/web/requests.go:37).

What should happen

Only a pool that has no fedwiki_sites entitlement (sql.ErrNoRows) is answered as a quota of 0. Any other error from that read returns an error, as the pool and usage reads do, so the request fails as quota_unavailable and the member is told the limit could not be checked.

Where

  • internal/integrations/fedwiki/workflows/activities.go:602-614, CheckQuotaActivity
  • internal/integrations/fedwiki/workflows/requests.go:319-325, the create workflow's use of the answer

Steps

Found by reading the code; not reproduced.

  1. Start a site create while the entitlement read fails (a dropped connection, a statement timeout).
  2. The request is declined, and the site list shows "You have reached your site limit."

Why it matters

A member under their limit is told they have reached it, and the request is declined rather than failed, so nothing tells them to try again. The log line that would explain it says no entitlement was found and drops the error.

## What happens Before a site create, the create workflow asks `CheckQuotaActivity` (`internal/integrations/fedwiki/workflows/activities.go:581`) whether the workspace may have another site. The activity reads three things: the workspace's pool, the pool's `fedwiki_sites` entitlement and the pool's usage. A failed read of the pool or of the usage returns an error, and the workflow then fails the request as `quota_unavailable` (`internal/integrations/fedwiki/workflows/requests.go:319-322`), which the member reads as "Couldn't check your site limit. Try again later." A failed read of the entitlement is handled differently. Any error from `GetNumericEntitlementByPoolAndResource` (`activities.go:602-614`), not only "no row", is answered as a quota of 0 with `CanCreate` false, and logged at Info as "no sites entitlement found" without the error. The workflow then declines the request as `site_limit_reached` (`requests.go:323-325`), and the member reads "You have reached your site limit." (`internal/integrations/fedwiki/web/requests.go:37`). ## What should happen Only a pool that has no `fedwiki_sites` entitlement (`sql.ErrNoRows`) is answered as a quota of 0. Any other error from that read returns an error, as the pool and usage reads do, so the request fails as `quota_unavailable` and the member is told the limit could not be checked. ## Where - `internal/integrations/fedwiki/workflows/activities.go:602-614`, `CheckQuotaActivity` - `internal/integrations/fedwiki/workflows/requests.go:319-325`, the create workflow's use of the answer ## Steps Found by reading the code; not reproduced. 1. Start a site create while the entitlement read fails (a dropped connection, a statement timeout). 2. The request is declined, and the site list shows "You have reached your site limit." ## Why it matters A member under their limit is told they have reached it, and the request is declined rather than failed, so nothing tells them to try again. The log line that would explain it says no entitlement was found and drops the error.
cgalo5758 added the
kind
bug
area/entitlementsarea/fedwiki
priority
low
 labels 2026-10-16 02:59:52 +00:00
cgalo5758 commented 2026-10-22 18:40:28 +00:00
Author
Owner
Copy Link
Copy Source

Fixed in 9027c0b1: CheckQuotaActivity answers "no entitlement" only when the pool has no sites entitlement, and returns any other read failure, so the create ends failed with quota_unavailable and the notice " wasn't created. Couldn't check your site limit. Try again later." The slot gate and every quota read now follow the same rule through usage.Limit.

Fixed in 9027c0b1: `CheckQuotaActivity` answers "no entitlement" only when the pool has no sites entitlement, and returns any other read failure, so the create ends failed with `quota_unavailable` and the notice "<domain> wasn't created. Couldn't check your site limit. Try again later." The slot gate and every quota read now follow the same rule through `usage.Limit`.
cgalo5758 referenced this issue from a commit 2026-10-22 18:40:40 +00:00
Tick #165's landing tasks
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
A barrier for people using assistive technology or a keyboard alone.
 area/billing
The Stripe mirror, checkout, subscriptions, invoices, fulfillment.
 area/catalog
Products, prices, plan ladders, purchasability.
 area/discourse
The Discourse integration.
 area/domains
The domains registry, claims, placements, the certificate ask.
 area/entitlements
Entitlement sets, rules, grants, pools, provisioning.
 area/fedwiki
The Federated Wiki integration and farm sync.
 area/identity
Sign-in, sessions, persons, organizations, workspaces, roles.
 area/integrations
The provider registry, outbox and webhooks in general.
 area/licensing
Licenses, the contributor agreement, SPDX headers.
 area/member-ui
Member pages.
 area/meta
The repository itself, its contributing guide, CI, the tracker and the workflow.
 area/operator-ui
Operator pages, forms, lists, the design system.
 area/ops
Deployment, configuration, migrations, workflows, instance settings.
 area/testing
The test stack, screens, lint, walkthroughs.
 duplicate
Closed because another issue already covers it.
 good-first-issue
Small, self-contained, and explained enough to be a first contribution.
 invalid
Closed because it is not a ticket for this repository.
 privacy
Touches what a person's data reveals.
 security
Touches authentication, authorization, secrets or data exposure.
 upstream
Waits on another repository or project before it can move.
 wontfix
Closed because it will not be done, with the reason in the last comment.
kind
bug
The software does something other than what it promises; closed when it again does what it promises.
kind
debt
Code, tests or tooling to clean up with nothing visible changing; closed when they are cleaner.
kind
design
A question to settle before work can be defined; closed when the decision is written down.
kind
docs
Documentation that is wrong or missing; closed when it says the right thing.
kind
enhancement
Something the software does not do yet; closed when it does.
priority
critical
Blocks the active milestone or harms members now.
priority
high
Next in line inside the active milestone.
priority
low
Inside the active milestone, when nothing else is left.
priority
medium
Inside the active milestone, after the high ones.
No labels area/entitlements area/fedwiki
kind
bug
priority
low
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
3wordchant Bortseb (Robert Best) cgalo5758 (Christian Galo) renovate-bot (Comrade Renovate Bot)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: wiki-cafe/member-console#231