A FedWiki site's name can keep the wrong certificate answer after a status change #247

Closed
opened 2026-10-22 06:46:30 +00:00 by cgalo5758 · 1 comment
Owner

What happens

The certificate endpoint (/domains/ask) lets a site's name have a certificate when its placement is servable, and that flag is a second copy of the site row's status. An archive or a restore commits the row's status, then writes the flag in a separate transaction, best effort. If that write fails, or the worker stops between the two, the flag keeps its old value, and a retry finds the request finished and skips the write.

A swap writes no flag at all. Keep active refuses only a site that is already active, so a site archived after the page rendered (by the sync, for example) can be swapped in with its name still unservable.

Only the sync writes the flag again, from the row. The sync is off by default (fedwiki-sync-enabled), and boot leaves existing placements alone, so with the sync off a wrong flag stays. A restored site can be refused a certificate, and an archived one granted one.

What should happen

After any write of a site's status, its name is servable exactly when its row is active or read-only, whether the sync runs or not.

Where

internal/integrations/fedwiki/workflows/request_activities.go (RecordSiteStatusActivity), internal/integrations/fedwiki/workflows/activities.go, internal/integrations/fedwiki/workflows/swap.go (RecordSwapActivity), internal/integrations/fedwiki/workflows/sync.go, internal/integrations/fedwiki/reconcile_domains.go, internal/integrations/fedwiki/web/site_actions.go (KeepSiteActive)

Why it matters

A restored wiki can lose its certificate with nothing left that corrects the flag.

### What happens The certificate endpoint (`/domains/ask`) lets a site's name have a certificate when its placement is `servable`, and that flag is a second copy of the site row's status. An archive or a restore commits the row's status, then writes the flag in a separate transaction, best effort. If that write fails, or the worker stops between the two, the flag keeps its old value, and a retry finds the request finished and skips the write. A swap writes no flag at all. Keep active refuses only a site that is already active, so a site archived after the page rendered (by the sync, for example) can be swapped in with its name still unservable. Only the sync writes the flag again, from the row. The sync is off by default (`fedwiki-sync-enabled`), and boot leaves existing placements alone, so with the sync off a wrong flag stays. A restored site can be refused a certificate, and an archived one granted one. ### What should happen After any write of a site's status, its name is servable exactly when its row is active or read-only, whether the sync runs or not. ### Where `internal/integrations/fedwiki/workflows/request_activities.go` (`RecordSiteStatusActivity`), `internal/integrations/fedwiki/workflows/activities.go`, `internal/integrations/fedwiki/workflows/swap.go` (`RecordSwapActivity`), `internal/integrations/fedwiki/workflows/sync.go`, `internal/integrations/fedwiki/reconcile_domains.go`, `internal/integrations/fedwiki/web/site_actions.go` (`KeepSiteActive`) ### Why it matters A restored wiki can lose its certificate with nothing left that corrects the flag.
cgalo5758 added this to the Public launch milestone 2026-10-22 06:46:30 +00:00
cgalo5758 added the
kind
bug
area/domainsarea/fedwiki
labels 2026-10-22 06:46:30 +00:00
Author
Owner

Fixed in 0679966f.

The certificate endpoint still reads the stored servable flag, so a certificate lookup never calls into a provider; what changed is who keeps that flag true. A trigger on fedwiki.sites now writes the flag of the site's own placements in the same transaction as every insert, status change and delete of the site row: yes for an active or read-only site, no for an archived one, and no as soon as the row is deleted. The archive, the restore, the swap and the sync all write the site's status, so all of them now move the flag with it, whether or not the sync runs, and none of them writes the flag on its own any more. Placements of other providers, and a name reserved for a site that is still being created, keep the answer they were given.

The sync and boot, which create a placement for a site that already exists, read that site's row under a share lock just before they create it, so a status change cannot slip in between the read and the placement. A side effect closes an older gap: a deleted site's name now answers no before its placement is released, so a release that fails no longer leaves a deleted site's name authorized.

Existing placements are not rewritten; each is corrected the next time its site is written. A deployment that wants to check its flags before upgrading can compare domains.placements.servable with the status of the matching fedwiki.sites row and fix any mismatch by hand.

Fixed in 0679966f. The certificate endpoint still reads the stored `servable` flag, so a certificate lookup never calls into a provider; what changed is who keeps that flag true. A trigger on `fedwiki.sites` now writes the flag of the site's own placements in the same transaction as every insert, status change and delete of the site row: yes for an active or read-only site, no for an archived one, and no as soon as the row is deleted. The archive, the restore, the swap and the sync all write the site's status, so all of them now move the flag with it, whether or not the sync runs, and none of them writes the flag on its own any more. Placements of other providers, and a name reserved for a site that is still being created, keep the answer they were given. The sync and boot, which create a placement for a site that already exists, read that site's row under a share lock just before they create it, so a status change cannot slip in between the read and the placement. A side effect closes an older gap: a deleted site's name now answers no before its placement is released, so a release that fails no longer leaves a deleted site's name authorized. Existing placements are not rewritten; each is corrected the next time its site is written. A deployment that wants to check its flags before upgrading can compare `domains.placements.servable` with the status of the matching `fedwiki.sites` row and fix any mismatch by hand.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: wiki-cafe/member-console#247