While a grant holds a ladder that a subscription still pays for, the Products page sells a tier above the grant through Checkout, so the ladder carries two subscriptions #277
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: wiki-cafe/member-console#277
Reference in New Issue
Block a user
What happens
Some terms first. A plan ladder is a ranked sequence of tiers; an organization holds one tier per ladder at a time. A grant is an operator's record that gives an organization a product without payment. An operator's grant over a tier the organization pays for supersedes the subscription's tier and holds the ladder; the subscription keeps billing and delivers nothing there (
docs/stripe.md:214).While that lasts, the console reads the ladder's position as the grant's. The offer decision, which says what move the Products page and Checkout allow, treats a tier a grant holds as one no subscription pays for (
internal/server/plan_offer.go:142-145) and offers every tier above it through Checkout (rule 13 ofplans.Offer,internal/plans/offer.go:181-182, code at:280). Checkout asks the same decision and sells it (checkoutOffer,internal/server/billing.go:263-291).A member who buys a tier above the grant therefore starts a second subscription on the ladder. The new subscription supersedes the grant and delivers. The first one keeps billing and delivers nothing, since its reconcile, the console's reading of it back from Stripe, leaves alone a ladder another plan took from it and still holds (
docs/models/plan-ladders-transitions.md:80). Stripe bills both, and Cancel plan reaches the new subscription only (internal/fulfillment/plan_change.go:770-850).The billing model says an organization holds at most one subscription per ladder and that Checkout cannot sell a second concurrent subscription on a ladder (
docs/models/payments-billing.md:13,:65). The offer decision cannot see a subscription that pays on a ladder without holding its tier.#257 reaches two subscriptions on one ladder through a Checkout page opened before the first purchase; this is a separate path. #269 covers cancelling the first subscription.
What should happen
While a subscription pays on a ladder, whoever holds the ladder's tier, the Products page offers no Checkout there and Checkout refuses one, so a ladder never carries two subscriptions. Whether the member's move above the grant then changes the subscription that already pays, or is not offered, belongs to the same decision as cancelling that subscription.
Where
internal/server/plan_offer.go:133-156(onLadder);internal/plans/offer.go:181-182;internal/server/billing.go:263-291.Steps
Why it matters
A member pays two subscriptions for one ladder and receives one tier, a state the console's own billing model says cannot happen.
The Products page no longer offers, and Checkout refuses, any tier of a ladder that one of the organization's subscriptions pays for while a grant holds that ladder. Buying there would have started a second subscription on the ladder while the first kept existing. The tiers at or above the grant and above the paid plan now offer a switch of the existing subscription instead, and when the grant is of a lower tier than the paid plan, the paid plan's own card offers to resume it. Checkout above a grant with no subscription behind it is unchanged.
Commits:
ec6cf1e4,23e5689d,688e3622