A plan switch is confirmed in a panel above the plan cards, before the button that opened it #291
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: wiki-cafe/member-console#291
Reference in New Issue
Block a user
What a person cannot do today
On the Products page, pressing Upgrade or Downgrade on a plan card opens the switch's confirmation as a panel at the top of the Plans section, above the cards, not where the member clicked. On a long page the panel appears before the button that opened it, and the member has to look back up the page to find what to confirm. Every other action on the same cards (Cancel plan, Keep plan, Pay invoice) confirms in the shared dialog that the page anatomy prescribes for acts that need a deliberate confirmation. The switch is the one that does not, because it needs the price preview from the server before it can ask.
What they should be able to do
Confirm a switch in the same shared dialog as the card's other actions: the button opens the dialog, the dialog's body is the switch's confirmation with the preview's figures loaded from the server, and Confirm switch and Keep current plan are its two buttons.
Why it matters
The confirmation of a charge appears away from the act that asked for it, and the page confirms one action in a different place and form from the others.
Where
The switch preview (
GetSwitchPreview,internal/server/member_plan_moves.go), the preview banner ininternal/embeds/templates/partials/member_plans.html, and the shared confirm dialog (#confirmActionModal,static/confirm-action-modal.js)Done when
Every plan switch on the Products page, upgrades and downgrades, the switch of a paused plan included, confirms in the shared dialog with the same sentences it reads today; no confirmation panel renders above the cards; the walkthroughs and screens that open a switch's confirmation drive the dialog.
On the Products page, a plan switch now confirms in the same dialog as Cancel plan and Resume plan, instead of in a panel at the top of the Plans section. A plan switch moves an organization's paid subscription from one plan to another on the same ladder (the ordered set of plans an organization moves up and down): Upgrade or Downgrade on a plan's card, or Pay for this plan on the card of a plan an operator has granted while the organization still pays for a lower one. Pressing the button opens the dialog at once, titled with the question the panel opened with, such as "Switch to Pro?" or "Pay for Pro?". The dialog's body then loads from the server, because the charge it states comes from Stripe at that moment: the same sentences as before, Confirm switch, and Keep current plan, which closes the dialog and sends nothing. When the card is declined, when the payment needs the bank's approval, or when the figures are more than an hour old, the answer replaces the dialog's body and the dialog stays open. When the switch is made or refused, the dialog closes and the Plans section shows the result, as before; a plan withdrawn after the page loaded closes the dialog the same way, with the sentence that the plan is no longer available. Keep plan still applies at once, since it charges nothing, and Pay invoice still opens the invoice's page at Stripe.
Commit:
f3fa8e74