Syncing a new product to Stripe logs an ERROR when its price waits a moment for the product #304

New Issue

2026-10-30T22:51:34Z

cgalo5758 commented

2026-10-30 22:51:34 +00:00

What happens

An operator's Sync to Stripe on a product that Stripe does not have yet writes two entries to the outbox, the table of changes the console sends to Stripe: one that creates the product and one that creates its price (internal/integrations/stripe/catalogsync/catalogsync.go:268-277). The outbox relay starts each entry as its own Temporal workflow (Temporal is the console's workflow engine), so the two run side by side (internal/integrations/stripe/workflows/outbox.go:96-113). The price needs the product's Stripe id. When its attempt runs before the product's create has returned, it fails with product … not yet synced (retriable) (outbox.go:490-496), and Temporal retries it a second later (retry_budget.go:22-23), when it succeeds.

The Temporal worker logs every error an activity returns at ERROR, as "Activity error.", unless the error is marked benign (go.temporal.io/sdk v1.38.0, internal/internal_task_handlers.go:2326-2337). The console passes the worker's log into its own at the same level (internal/workflows/client.go:54-56, :88-89). So the ordinary first sync of a product often leaves an ERROR line naming its price, though nothing went wrong.

What should happen

A price waiting for its product logs nothing at ERROR. An ERROR line appears only when the wait outlasts the entry's retries, which already logs at ERROR when the entry is dead-lettered (retry_budget.go:43-44). Returning the wait as a Temporal application error in the benign category is one way: the worker then logs it at DEBUG.

Where

internal/integrations/stripe/workflows/outbox.go:480-496

Steps

With a Stripe test key set, create a product with a price on the operator's Products page and press Sync to Stripe.
Both appear in Stripe within seconds. The console's log often shows "Activity error." at ERROR with product … not yet synced (retriable) before the price's success line.

Why it matters

An operator setting up a catalog sees an error for every new product that in fact synced, and learns to ignore the line that would report a sync that really failed.

### What happens An operator's Sync to Stripe on a product that Stripe does not have yet writes two entries to the outbox, the table of changes the console sends to Stripe: one that creates the product and one that creates its price (`internal/integrations/stripe/catalogsync/catalogsync.go:268-277`). The outbox relay starts each entry as its own Temporal workflow (Temporal is the console's workflow engine), so the two run side by side (`internal/integrations/stripe/workflows/outbox.go:96-113`). The price needs the product's Stripe id. When its attempt runs before the product's create has returned, it fails with `product … not yet synced (retriable)` (`outbox.go:490-496`), and Temporal retries it a second later (`retry_budget.go:22-23`), when it succeeds. The Temporal worker logs every error an activity returns at ERROR, as "Activity error.", unless the error is marked benign (`go.temporal.io/sdk` v1.38.0, `internal/internal_task_handlers.go:2326-2337`). The console passes the worker's log into its own at the same level (`internal/workflows/client.go:54-56`, `:88-89`). So the ordinary first sync of a product often leaves an ERROR line naming its price, though nothing went wrong. ### What should happen A price waiting for its product logs nothing at ERROR. An ERROR line appears only when the wait outlasts the entry's retries, which already logs at ERROR when the entry is dead-lettered (`retry_budget.go:43-44`). Returning the wait as a Temporal application error in the benign category is one way: the worker then logs it at DEBUG. ### Where `internal/integrations/stripe/workflows/outbox.go:480-496` ### Steps 1. With a Stripe test key set, create a product with a price on the operator's Products page and press Sync to Stripe. 2. Both appear in Stripe within seconds. The console's log often shows "Activity error." at ERROR with `product … not yet synced (retriable)` before the price's success line. ### Why it matters An operator setting up a catalog sees an error for every new product that in fact synced, and learns to ignore the line that would report a sync that really failed.

cgalo5758 added the

kind

bug

area/billing area/integrations labels 2026-10-30 22:51:34 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: wiki-cafe/member-console#304