A change of the active FedWiki site that never takes effect still starts the wait before the next change #328
Closed
opened 2026-11-10 08:25:58 +00:00 by cgalo5758
·
1 comment
Labels
Clear labels
accessibility
area/billing
area/catalog
area/discourse
area/domains
area/entitlements
area/fedwiki
area/identity
area/integrations
area/licensing
area/member-ui
area/meta
area/operator-ui
area/ops
area/testing
duplicate
good-first-issue
invalid
privacy
security
upstream
wontfix
A barrier for people using assistive technology or a keyboard alone.
The Stripe mirror, checkout, subscriptions, invoices, fulfillment.
Products, prices, plan ladders, purchasability.
The Discourse integration.
The domains registry, claims, placements, the certificate ask.
Entitlement sets, rules, grants, pools, provisioning.
The Federated Wiki integration and farm sync.
Sign-in, sessions, persons, organizations, workspaces, roles.
The provider registry, outbox and webhooks in general.
Licenses, the contributor agreement, SPDX headers.
Member pages.
The repository itself, its contributing guide, CI, the tracker and the workflow.
Operator pages, forms, lists, the design system.
Deployment, configuration, migrations, workflows, instance settings.
The test stack, screens, lint, walkthroughs.
Closed because another issue already covers it.
Small, self-contained, and explained enough to be a first contribution.
Closed because it is not a ticket for this repository.
Touches what a person's data reveals.
Touches authentication, authorization, secrets or data exposure.
Waits on another repository or project before it can move.
Closed because it will not be done, with the reason in the last comment.
kind
bug
The software does something other than what it promises; closed when it again does what it promises.
kind
debt
Code, tests or tooling to clean up with nothing visible changing; closed when they are cleaner.
kind
design
A question to settle before work can be defined; closed when the decision is written down.
kind
docs
Documentation that is wrong or missing; closed when it says the right thing.
kind
enhancement
Something the software does not do yet; closed when it does.
priority
critical
Blocks the active milestone or harms members now.
priority
high
Next in line inside the active milestone.
priority
low
Inside the active milestone, when nothing else is left.
priority
medium
Inside the active milestone, after the high ones.
Milestone
No items
No Milestone
Projects
Clear projects
No projects
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: wiki-cafe/member-console#328
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
What happens
An organization with more FedWiki sites than its plan keeps active can change which site is active: activating a parked site parks another one in its place. After a change, the organization waits a set period before it can change again (
fedwiki-swap-cooldown, 30 days by default). The console starts that wait in the transaction that records the change, before the change's workflow runs, and nothing ever takes it back. A change that never takes effect starts the wait all the same:Bringing back a site that a plan downgrade parked starts the same wait the same way.
What should happen
Only a change that took effect starts the wait. A change that never started, failed or was declined leaves the wait where it was, so a retry can follow "Try again."
Where
internal/integrations/fedwiki/web/site_actions.go:swapActiveSiteandchangeStatusboth callUpsertSiteSwapPolicyin the recording transaction.fedwiki.site_swap_policyholds one time per organization, and the store has no query that clears or restores it.Why it matters
A member who follows the console's own "Try again" is shut out of changing their active site for a month, for a change that never happened.
Related: #298, where a failed read of the same time is treated as no earlier change.
Fixed in
153b2812.The wait between changes of the active site now starts only when a change succeeds. The step that records the success writes it, in the same transaction as the sites' new statuses. A change that cannot start, fails or is declined leaves the wait as it was, so a member can follow "Try again." at once.
Recording a change no longer starts the wait; it only reads it. While another change of the organization's active site is in progress, a change is refused with "A change to your active site is already in progress", whether or not a wait is configured.
Bringing back a site that a downgrade parked follows the same rule: it starts the wait only when it succeeds.