A FedWiki site a downgrade parked keeps its mark when the farm sync finds it archived or active #329

Closed
opened 2026-11-10 21:03:54 +00:00 by cgalo5758 · 1 comment
Owner

What happens

When a downgrade parks a FedWiki site read-only, the console marks the site so a later upgrade can bring it back. If the farm sync then finds that site archived or active at the farm, it writes the farm's status onto the console's row and keeps the mark. The console's own status changes drop the mark whenever the new status is not read-only.

A marked archived site is then treated as a parked site coming back. While the wait between changes of the active site runs, Restore on that site is disabled, and a Restore starts the wait again.

What should happen

The farm sync drops the mark whenever the status it writes is not read-only, as every other status change does.

Where

internal/integrations/fedwiki/store/queries/sites.sql, UpsertSiteFromFarm. The rule is in openspec/specs/fedwiki-sites/spec.md: "A site's force-reduced mark SHALL be kept only while the site is readonly".

Why it matters

Restoring a site from the trash is held to the wait between changes of the active site, and starts that wait, only because of what the farm reported.

## What happens When a downgrade parks a FedWiki site read-only, the console marks the site so a later upgrade can bring it back. If the farm sync then finds that site archived or active at the farm, it writes the farm's status onto the console's row and keeps the mark. The console's own status changes drop the mark whenever the new status is not read-only. A marked archived site is then treated as a parked site coming back. While the wait between changes of the active site runs, Restore on that site is disabled, and a Restore starts the wait again. ## What should happen The farm sync drops the mark whenever the status it writes is not read-only, as every other status change does. ## Where `internal/integrations/fedwiki/store/queries/sites.sql`, `UpsertSiteFromFarm`. The rule is in `openspec/specs/fedwiki-sites/spec.md`: "A site's force-reduced mark SHALL be kept only while the site is `readonly`". ## Why it matters Restoring a site from the trash is held to the wait between changes of the active site, and starts that wait, only because of what the farm reported.
cgalo5758 added the
kind
bug
area/fedwikiarea/member-ui
labels 2026-11-10 21:03:54 +00:00
Author
Owner

Fixed in 153b2812.

The farm sync now keeps a site's mark only when the status it writes is read-only, as every other status change does.

The sync leaves a site alone while a member's request on it is still open. So when a member is bringing back a parked site (Keep active on it), the site keeps its mark until that request's own success clears it. To make that hold when the sync and the member act at the same moment, recording such a request now locks the site's row. Under the lock it checks again that the site is still read-only and marked.

Restore of an archived site never counts as a change of the active site. The sites card shows Restore on every archived row, during the wait or not, and a Restore never starts the wait.

An upgrading deployment may already have rows that are archived or active and still carry the mark. Those are cleared by hand during the upgrade, as the commit message's upgrade steps describe.

Fixed in 153b2812. The farm sync now keeps a site's mark only when the status it writes is read-only, as every other status change does. The sync leaves a site alone while a member's request on it is still open. So when a member is bringing back a parked site (Keep active on it), the site keeps its mark until that request's own success clears it. To make that hold when the sync and the member act at the same moment, recording such a request now locks the site's row. Under the lock it checks again that the site is still read-only and marked. Restore of an archived site never counts as a change of the active site. The sites card shows Restore on every archived row, during the wait or not, and a Restore never starts the wait. An upgrading deployment may already have rows that are archived or active and still carry the mark. Those are cleared by hand during the upgrade, as the commit message's upgrade steps describe.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: wiki-cafe/member-console#329