A FedWiki site a downgrade parked keeps its mark when the farm sync finds it archived or active #329
Closed
opened 2026-11-10 21:03:54 +00:00 by cgalo5758
·
1 comment
Labels
Clear labels
accessibility
area/billing
area/catalog
area/discourse
area/domains
area/entitlements
area/fedwiki
area/identity
area/integrations
area/licensing
area/member-ui
area/meta
area/operator-ui
area/ops
area/testing
duplicate
good-first-issue
invalid
privacy
security
upstream
wontfix
A barrier for people using assistive technology or a keyboard alone.
The Stripe mirror, checkout, subscriptions, invoices, fulfillment.
Products, prices, plan ladders, purchasability.
The Discourse integration.
The domains registry, claims, placements, the certificate ask.
Entitlement sets, rules, grants, pools, provisioning.
The Federated Wiki integration and farm sync.
Sign-in, sessions, persons, organizations, workspaces, roles.
The provider registry, outbox and webhooks in general.
Licenses, the contributor agreement, SPDX headers.
Member pages.
The repository itself, its contributing guide, CI, the tracker and the workflow.
Operator pages, forms, lists, the design system.
Deployment, configuration, migrations, workflows, instance settings.
The test stack, screens, lint, walkthroughs.
Closed because another issue already covers it.
Small, self-contained, and explained enough to be a first contribution.
Closed because it is not a ticket for this repository.
Touches what a person's data reveals.
Touches authentication, authorization, secrets or data exposure.
Waits on another repository or project before it can move.
Closed because it will not be done, with the reason in the last comment.
kind
bug
The software does something other than what it promises; closed when it again does what it promises.
kind
debt
Code, tests or tooling to clean up with nothing visible changing; closed when they are cleaner.
kind
design
A question to settle before work can be defined; closed when the decision is written down.
kind
docs
Documentation that is wrong or missing; closed when it says the right thing.
kind
enhancement
Something the software does not do yet; closed when it does.
priority
critical
Blocks the active milestone or harms members now.
priority
high
Next in line inside the active milestone.
priority
low
Inside the active milestone, when nothing else is left.
priority
medium
Inside the active milestone, after the high ones.
Milestone
No items
No Milestone
Projects
Clear projects
No projects
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: wiki-cafe/member-console#329
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
What happens
When a downgrade parks a FedWiki site read-only, the console marks the site so a later upgrade can bring it back. If the farm sync then finds that site archived or active at the farm, it writes the farm's status onto the console's row and keeps the mark. The console's own status changes drop the mark whenever the new status is not read-only.
A marked archived site is then treated as a parked site coming back. While the wait between changes of the active site runs, Restore on that site is disabled, and a Restore starts the wait again.
What should happen
The farm sync drops the mark whenever the status it writes is not read-only, as every other status change does.
Where
internal/integrations/fedwiki/store/queries/sites.sql,UpsertSiteFromFarm. The rule is inopenspec/specs/fedwiki-sites/spec.md: "A site's force-reduced mark SHALL be kept only while the site isreadonly".Why it matters
Restoring a site from the trash is held to the wait between changes of the active site, and starts that wait, only because of what the farm reported.
Fixed in
153b2812.The farm sync now keeps a site's mark only when the status it writes is read-only, as every other status change does.
The sync leaves a site alone while a member's request on it is still open. So when a member is bringing back a parked site (Keep active on it), the site keeps its mark until that request's own success clears it. To make that hold when the sync and the member act at the same moment, recording such a request now locks the site's row. Under the lock it checks again that the site is still read-only and marked.
Restore of an archived site never counts as a change of the active site. The sites card shows Restore on every archived row, during the wait or not, and a Restore never starts the wait.
An upgrading deployment may already have rows that are archived or active and still carry the mark. Those are cleared by hand during the upgrade, as the commit message's upgrade steps describe.