Compare commits

...

6 Commits

Author SHA1 Message Date
e996b5c057 chore: publish 2.1.4+24.0.6-fpm release 2022-10-13 17:12:29 +02:00
0aabef8f7b let app container wait for db init 2022-10-13 16:58:10 +02:00
2be42d0a84 fix frame ancestors 2022-10-11 16:12:04 +02:00
e76454c4fd .env.sample template domain 2022-09-13 16:37:55 +02:00
ec39fd5fed chore: publish 2.1.3+24.0.5-fpm release 2022-09-13 15:44:24 +02:00
16ad6c22ea add headers to embed nextcloud in frame on external site (#28)
This introduces new env variables to configure nextloud to be embedded via
iframe on an external site.
Setting X_FRAME_OPTIONS_ENABLED=1 will configure nginx and nextcloud to
set X-Frame-Options and CSP headers to allow the domain configured in
X_FRAME_OPTIONS_ALLOW_FROM.

I created a PR because I'm not sure if this is helpful for other people or just a custom hack that bloats the recipe :D

Co-authored-by: Philipp Rothmann <philipprothmann@posteo.de>
Reviewed-on: coop-cloud/nextcloud#28
2022-09-02 14:32:04 +00:00
6 changed files with 43 additions and 9 deletions

View File

@ -1,6 +1,6 @@
TYPE=nextcloud TYPE=nextcloud
DOMAIN=nextcloud.example.com DOMAIN={{ .Domain }}
## Domain aliases ## Domain aliases
#EXTRA_DOMAINS=', `www.nextcloud.example.com`' #EXTRA_DOMAINS=', `www.nextcloud.example.com`'
LETS_ENCRYPT_ENV=production LETS_ENCRYPT_ENV=production
@ -16,3 +16,6 @@ SECRET_DB_PASSWORD_VERSION=v1
SECRET_ADMIN_PASSWORD_VERSION=v1 SECRET_ADMIN_PASSWORD_VERSION=v1
EXTRA_VOLUME=/dev/null:/tmp/.dummy EXTRA_VOLUME=/dev/null:/tmp/.dummy
# X_FRAME_OPTIONS_ENABLED=1
# X_FRAME_OPTIONS_ALLOW_FROM=embedding-site.example.org

View File

@ -1,6 +1,7 @@
export FPM_TUNE_VERSION=v4 export FPM_TUNE_VERSION=v4
export NGINX_CONF_VERSION=v2 export NGINX_CONF_VERSION=v4
export MY_CNF_VERSION=v4 export MY_CNF_VERSION=v4
export ENTRYPOINT_VERSION=v2
NC_APP_DIR="app:/var/www/html" NC_APP_DIR="app:/var/www/html"

View File

@ -2,7 +2,6 @@ version: '3.8'
services: services:
app: app:
entrypoint: "sh -c 'sleep 10 && /entrypoint.sh php-fpm'" # tries to mitigate this error with postgres https://github.com/nextcloud/docker/issues/1204
environment: environment:
- POSTGRES_HOST=db - POSTGRES_HOST=db
- POSTGRES_DB=nextcloud - POSTGRES_DB=nextcloud

View File

@ -6,6 +6,8 @@ services:
- source: nginx_conf - source: nginx_conf
target: /etc/nginx/nginx.conf target: /etc/nginx/nginx.conf
environment: environment:
- X_FRAME_OPTIONS_ALLOW_FROM
- X_FRAME_OPTIONS_ENABLED
- DOMAIN - DOMAIN
- STACK_NAME - STACK_NAME
volumes: volumes:
@ -33,16 +35,22 @@ services:
- "traefik.http.middlewares.${STACK_NAME}-redirect.headers.SSLHost=${DOMAIN}" - "traefik.http.middlewares.${STACK_NAME}-redirect.headers.SSLHost=${DOMAIN}"
app: app:
image: nextcloud:24.0.3-fpm image: nextcloud:24.0.6-fpm
depends_on: depends_on:
- db - db
configs: configs:
- source: fpm_tune - source: fpm_tune
target: /usr/local/etc/php-fpm.d/fpm-tune.conf target: /usr/local/etc/php-fpm.d/fpm-tune.conf
- source: entrypoint
target: /custom-entrypoint.sh
mode: 555
entrypoint: /custom-entrypoint.sh
secrets: secrets:
- db_password - db_password
- admin_password - admin_password
environment: environment:
- X_FRAME_OPTIONS_ALLOW_FROM
- X_FRAME_OPTIONS_ENABLED
- DOMAIN - DOMAIN
- STACK_NAME - STACK_NAME
- NEXTCLOUD_ADMIN_USER=${ADMIN_USER} - NEXTCLOUD_ADMIN_USER=${ADMIN_USER}
@ -69,13 +77,12 @@ services:
failure_action: rollback failure_action: rollback
order: start-first order: start-first
labels: labels:
- "coop-cloud.${STACK_NAME}.version=2.1.2+24.0.3-fpm" - "coop-cloud.${STACK_NAME}.version=2.1.4+24.0.6-fpm"
- "backupbot.backup=true" - "backupbot.backup=true"
- "backupbot.backup.path=/var/www/html/config/,/var/www/html/data/,/var/www/html/custom_apps/" - "backupbot.backup.path=/var/www/html/config/,/var/www/html/data/,/var/www/html/custom_apps/"
cron: cron:
image: nextcloud:24.0.3-fpm image: nextcloud:24.0.6-fpm
volumes: volumes:
- nextcloud:/var/www/html/ - nextcloud:/var/www/html/
- nextapps:/var/www/html/custom_apps:cached - nextapps:/var/www/html/custom_apps:cached
@ -87,7 +94,7 @@ services:
entrypoint: /cron.sh entrypoint: /cron.sh
cache: cache:
image: redis:7.0.4-alpine image: redis:7.0.5-alpine
networks: networks:
- internal - internal
volumes: volumes:
@ -111,6 +118,7 @@ volumes:
nextconfig: nextconfig:
redis: redis:
configs: configs:
nginx_conf: nginx_conf:
name: ${STACK_NAME}_nginx_${NGINX_CONF_VERSION} name: ${STACK_NAME}_nginx_${NGINX_CONF_VERSION}
@ -119,6 +127,10 @@ configs:
fpm_tune: fpm_tune:
name: ${STACK_NAME}_fpm_tune_${FPM_TUNE_VERSION} name: ${STACK_NAME}_fpm_tune_${FPM_TUNE_VERSION}
file: fpm-tune.ini file: fpm-tune.ini
entrypoint:
name: ${STACK_NAME}_entrypoint_${ENTRYPOINT_VERSION}
file: entrypoint.sh.tmpl
template_driver: golang
networks: networks:
proxy: proxy:

12
entrypoint.sh.tmpl Normal file
View File

@ -0,0 +1,12 @@
#!/bin/bash
echo "Giving the db container some time to come up"; sleep 20
# see this issue with postgres db https://github.com/nextcloud/docker/issues/1204
{{ if eq (env "X_FRAME_OPTIONS_ENABLED") "1" }}
if ! [[ $(grep {{ env "X_FRAME_OPTIONS_ALLOW_FROM" }} lib/public/AppFramework/Http/ContentSecurityPolicy.php) ]]; then
sed -i "91 a\\\t\t'{{ env "X_FRAME_OPTIONS_ALLOW_FROM" }}', " lib/public/AppFramework/Http/ContentSecurityPolicy.php
fi
{{ end }}
/entrypoint.sh php-fpm

View File

@ -41,6 +41,7 @@ http {
# could take several months. # could take several months.
#add_header Strict-Transport-Security "max-age=15768000; includeSubDomains; preload;" always; #add_header Strict-Transport-Security "max-age=15768000; includeSubDomains; preload;" always;
# set max upload size # set max upload size
client_max_body_size 512M; client_max_body_size 512M;
fastcgi_buffers 64 4K; fastcgi_buffers 64 4K;
@ -61,11 +62,17 @@ http {
add_header Referrer-Policy "no-referrer" always; add_header Referrer-Policy "no-referrer" always;
add_header X-Content-Type-Options "nosniff" always; add_header X-Content-Type-Options "nosniff" always;
add_header X-Download-Options "noopen" always; add_header X-Download-Options "noopen" always;
add_header X-Frame-Options "SAMEORIGIN" always;
add_header X-Permitted-Cross-Domain-Policies "none" always; add_header X-Permitted-Cross-Domain-Policies "none" always;
add_header X-Robots-Tag "none" always; add_header X-Robots-Tag "none" always;
add_header X-XSS-Protection "1; mode=block" always; add_header X-XSS-Protection "1; mode=block" always;
{{ if eq (env "X_FRAME_OPTIONS_ENABLED") "1" }}
add_header Content-Security-Policy "frame-ancestors {{ env "X_FRAME_OPTIONS_ALLOW_FROM" }} {{ env "DOMAIN" }}";
{{ else }}
add_header X-Frame-Options "SAMEORIGIN" always;
{{ end }}
# Remove X-Powered-By, which is an information leak # Remove X-Powered-By, which is an information leak
fastcgi_hide_header X-Powered-By; fastcgi_hide_header X-Powered-By;