wiki-cafe/node-oauth
0
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

it looks like non oauth_ parameters where being included within the authorization headers

Browse Source 
I believe this to be incorrect.
This commit is contained in:
ciaranj 2010-07-19 00:25:00 +01:00
parent ebcf1c2950
commit 1c93463189
3 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
Readme.md
View File

@ -8,7 +8,8 @@ Also provides rudimentary OAuth2 support, tested against facebook connect and gi
at express-auth (http://github.com/ciaranj/express-auth) at express-auth (http://github.com/ciaranj/express-auth)
Change History Change History
============== ==============
* 0.7.7 - Looks like non oauth_ parameters where appearing within the Authorization headers, which I believe to be inccorrect.
* 0.7.6 - Added in oauth_verifier property to getAccessToken required for 1.0A * 0.7.6 - Added in oauth_verifier property to getAccessToken required for 1.0A
* 0.7.5 - Added in a main.js to simplify the require'ing of OAuth * 0.7.5 - Added in a main.js to simplify the require'ing of OAuth
* 0.7.4 - Minor change to add an error listener to the OAuth client (thanks troyk) * 0.7.4 - Minor change to add an error listener to the OAuth client (thanks troyk)

6
lib/oauth.js
View File

@ -193,8 +193,12 @@ exports.OAuth.prototype._performSecureRequest= function( oauth_token, oauth_toke
// build request authorization header // build request authorization header
var authHeader="OAuth "; var authHeader="OAuth ";
for( var i= 0 ; i < orderedParameters.length; i++) { for( var i= 0 ; i < orderedParameters.length; i++) {
// Whilst the all the parameters should be included within the signature, only the oauth_ arguments
// should appear within the authorization header.
if( orderedParameters[i][0].match('^oauth_') != "oauth_") {
authHeader+= this._encodeData(orderedParameters[i][0])+"=\""+ this._encodeData(orderedParameters[i][1])+"\","; authHeader+= this._encodeData(orderedParameters[i][0])+"=\""+ this._encodeData(orderedParameters[i][1])+"\",";
}
} }
authHeader= authHeader.substring(0, authHeader.length-1); authHeader= authHeader.substring(0, authHeader.length-1);

2
package.json
View File

@ -1,5 +1,5 @@
{ "name" : "oauth" { "name" : "oauth"
, "version" : "0.7.6" , "version" : "0.7.7"
, "directories" : { "lib" : "./lib" } , "directories" : { "lib" : "./lib" }
, "main" : "main.js" , "main" : "main.js"
, "author" : "Ciaran Jessup" , "author" : "Ciaran Jessup"