wiki-cafe/node-oauth
0
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

refactor code from oauth.signUrl and oauth._performSecureRequest

Browse Source
This commit is contained in:
François de Metz 2010-11-10 00:49:00 +01:00
parent b6f7e03061
commit 6d01536d66
1 changed files with 13 additions and 40 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

53
lib/oauth.js
View File

@ -169,7 +169,7 @@ exports.OAuth.prototype._createClient= function( port, hostname, sshEnabled, cre
return http.createClient(port, hostname, sshEnabled, credentials); return http.createClient(port, hostname, sshEnabled, credentials);
} }
exports.OAuth.prototype._performSecureRequest= function( oauth_token, oauth_token_secret, method, url, extra_params, post_body, post_content_type, callback ) { exports.OAuth.prototype._prepareParameters= function( oauth_token, oauth_token_secret, method, url, extra_params ) {
var oauthParameters= { var oauthParameters= {
"oauth_timestamp": this._getTimestamp(), "oauth_timestamp": this._getTimestamp(),
"oauth_nonce": this._getNonce(this._nonceSize), "oauth_nonce": this._getNonce(this._nonceSize),
@ -186,13 +186,7 @@ exports.OAuth.prototype._performSecureRequest= function( oauth_token, oauth_toke
oauthParameters[key]= extra_params[key]; oauthParameters[key]= extra_params[key];
} }
} }
if( !post_content_type ) {
post_content_type= "application/x-www-form-urlencoded";
}
var parsedUrl= URL.parse( url, false ); var parsedUrl= URL.parse( url, false );
if( parsedUrl.protocol == "http:" && !parsedUrl.port ) parsedUrl.port= 80;
if( parsedUrl.protocol == "https:" && !parsedUrl.port ) parsedUrl.port= 443;
if( parsedUrl.query ) { if( parsedUrl.query ) {
var extraParameters= querystring.parse(parsedUrl.query); var extraParameters= querystring.parse(parsedUrl.query);
@ -204,13 +198,18 @@ exports.OAuth.prototype._performSecureRequest= function( oauth_token, oauth_toke
var sig= this._getSignature( method, url, this._normaliseRequestParams(oauthParameters), oauth_token_secret); var sig= this._getSignature( method, url, this._normaliseRequestParams(oauthParameters), oauth_token_secret);
var orderedParameters= this._sortRequestParams( oauthParameters ); var orderedParameters= this._sortRequestParams( oauthParameters );
orderedParameters[orderedParameters.length]= ["oauth_signature", sig]; orderedParameters[orderedParameters.length]= ["oauth_signature", sig];
return orderedParameters;
var query=""; }
for( var i= 0 ; i < orderedParameters.length; i++) {
query+= this._encodeData(orderedParameters[i][0])+"="+ this._encodeData(orderedParameters[i][1]) + "&";
}
query= query.substring(0, query.length-1);
exports.OAuth.prototype._performSecureRequest= function( oauth_token, oauth_token_secret, method, url, extra_params, post_body, post_content_type, callback ) {
var orderedParameters= this._prepareParameters(oauth_token, oauth_token_secret, method, url, extra_params);
if( !post_content_type ) {
post_content_type= "application/x-www-form-urlencoded";
}
var parsedUrl= URL.parse( url, false );
if( parsedUrl.protocol == "http:" && !parsedUrl.port ) parsedUrl.port= 80;
if( parsedUrl.protocol == "https:" && !parsedUrl.port ) parsedUrl.port= 443;
var oauthProvider; var oauthProvider;
if( parsedUrl.protocol == "https:" ) { if( parsedUrl.protocol == "https:" ) {
@ -352,35 +351,13 @@ exports.OAuth.prototype.getOAuthRequestToken= function(extraParams, callback) {
} }
exports.OAuth.prototype.signUrl= function(url, oauth_token, oauth_token_secret, method) { exports.OAuth.prototype.signUrl= function(url, oauth_token, oauth_token_secret, method) {
var collectedParameters= {
"oauth_timestamp": this._getTimestamp(),
"oauth_nonce": this._getNonce(this._nonceSize),
"oauth_version": this._version,
"oauth_signature_method": this._signatureMethod,
"oauth_consumer_key": this._consumerKey
};
if( oauth_token ) {
collectedParameters["oauth_token"]= oauth_token;
}
if( method === undefined ) { if( method === undefined ) {
var method= "GET"; var method= "GET";
} }
var orderedParameters= this._prepareParameters(oauth_token, oauth_token_secret, method, url, {});
var parsedUrl= URL.parse( url, false ); var parsedUrl= URL.parse( url, false );
if( parsedUrl.protocol == "http:" && !parsedUrl.port ) parsedUrl.port= 80;
if( parsedUrl.protocol == "https:" && !parsedUrl.port ) parsedUrl.port= 443;
if( parsedUrl.query ) {
var queryParams= querystring.parse(parsedUrl.query);
for(var key in queryParams ) {
collectedParameters[key]= queryParams[key];
}
}
var sig= this._getSignature( method, url, this._normaliseRequestParams(collectedParameters), oauth_token_secret);
var orderedParameters= this._sortRequestParams( collectedParameters );
orderedParameters[orderedParameters.length]= ["oauth_signature", sig];
var query=""; var query="";
for( var i= 0 ; i < orderedParameters.length; i++) { for( var i= 0 ; i < orderedParameters.length; i++) {
@ -390,7 +367,3 @@ exports.OAuth.prototype.signUrl= function(url, oauth_token, oauth_token_secret,
return parsedUrl.protocol + "//"+ parsedUrl.host + parsedUrl.pathname + "?" + query; return parsedUrl.protocol + "//"+ parsedUrl.host + parsedUrl.pathname + "?" + query;
}; };