From bc8204c9d30772932b33eb651ecf79a0ff7747c0 Mon Sep 17 00:00:00 2001 From: Eric Dobbs Date: Mon, 4 Sep 2017 21:45:32 -0600 Subject: [PATCH] use build arg for wiki version & for container tag There is a new version of wiki available. Want to tag this version and enable building and tagging the next version. --- Dockerfile | 3 ++- README.md | 8 ++++++++ 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/Dockerfile b/Dockerfile index ec2225f..df27be4 100644 --- a/Dockerfile +++ b/Dockerfile @@ -5,7 +5,8 @@ RUN useradd --create-home app \ && apt-get install -y --no-install-recommends \ jq WORKDIR /home/app -RUN su app -c "npm install -g --prefix . wiki@0.11.4" +ARG VERSION=0.11.4 +RUN su app -c "npm install -g --prefix . wiki@$VERSION" RUN su app -c "mkdir .wiki" COPY configure-and-launch-wiki set-owner-name ./ RUN chown app configure-and-launch-wiki set-owner-name diff --git a/README.md b/README.md index f1177cb..7c552d8 100644 --- a/README.md +++ b/README.md @@ -49,3 +49,11 @@ docker run -p 3000:3000 -it --rm \ Open http://this.localtest.me:3000 in one tab. Open http://that.localtest.me:3000 in another. + +# Development + +``` bash +VERSION=0.11.4 +docker build --build-arg VERSION=$VERSION -t dobbs/farm:$VERSION . +git tag $VERSION +```