Update ExchangeLocator method names

This commit is contained in:
2024-11-26 13:54:08 +01:00
parent 5785f59bd2
commit 5396752ceb
2 changed files with 7 additions and 7 deletions
@@ -7,7 +7,7 @@ use Brick\Money\Exception\CurrencyConversionException;
class ExchangeLocator
{
/**
* @var ExchangeInterface[]
* @var array<string, ExchangeInterface>
*/
private array $exchanges;
@@ -33,9 +33,9 @@ class ExchangeLocator
}
/**
* @return ExchangeInterface[]
* @return array<string, ExchangeInterface>
*/
public function getExchanges(): array
public function getAll(): array
{
return $this->exchanges;
}
@@ -45,10 +45,10 @@ class ExchangeLocator
*
* @throws \Exception When the $name does not match to that of an implemented Exchange
*/
public function getExchange(string $name): ExchangeInterface
public function getByName(string $name): ExchangeInterface
{
if (!\array_key_exists($name, $this->exchanges)) {
throw new \Exception("No such Exchange with the name $name");
throw new \Exception("No such Exchange with the name '$name'");
}
return $this->exchanges[$name];
@@ -60,7 +60,7 @@ class ExchangeLocator
*
* @throws CurrencyConversionException If the exchange rate is not available
*/
public function getExchangeFor(string $source, string $target): ExchangeInterface
public function get(string $source, string $target): ExchangeInterface
{
foreach ($this->exchanges as $exchange) {
try {
+1 -1
View File
@@ -78,7 +78,7 @@ class MoneyService
return self::toBrick($money);
}
$exchange = $this->exchangeLocator->getExchangeFor($fromCurrency, $toCurrency);
$exchange = $this->exchangeLocator->get($fromCurrency, $toCurrency);
return self::toBrick($exchange->convert(self::toBrick($money), $toCurrency));
}