DemocraticTech.Fund/crowd-fund-api
0
1
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Improve order of data checks on paypal redirect handling

Browse Source
This commit is contained in:
daniel.subiabre
2024-10-01 12:20:23 +02:00
parent 47041aada9
commit 6932bbff95
1 changed files with 12 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/Library/Economy/Payment/PaypalGateway.php
+12 -6
View File
@@ -112,22 +112,28 @@ class PaypalGateway implements GatewayInterface
public function handleRedirect(Request $request): RedirectResponse
{
$orderId = $request->query->get('token');
if (!$orderId || $request->query->get('type') !== GatewayCheckoutService::RESPONSE_TYPE_SUCCESS) {
throw new \Exception(sprintf("PayPal checkout '%s' was not completed successfully.", $orderId));
if ($request->query->get('type') !== GatewayCheckoutService::RESPONSE_TYPE_SUCCESS) {
throw new \Exception(sprintf("Checkout was not completed successfully."));
}
$checkout = $this->checkoutRepository->find($request->query->get('checkoutId'));
$checkoutId = $request->query->get('checkoutId');
$checkout = $this->checkoutRepository->find($checkoutId);
if ($checkout === null) {
throw new \Exception(sprintf("PayPal checkout '%s' exists but no GatewayCheckout with that reference was found.", $orderId));
throw new \Exception(sprintf("GatewayCheckout '%s' could not be found.", $checkoutId));
}
if ($checkout->getStatus() === GatewayCheckoutStatus::Charged) {
return new RedirectResponse($this->iriConverter->getIriFromResource($checkout));
}
$orderId = $request->query->get('token');
if (!$orderId) {
throw new \Exception(sprintf("PayPal checkout order ID not provided by the gateway."));
}
$order = $this->fetchPaypalOrder($orderId);
if ($order['status'] !== self::PAYPAL_STATUS_APPROVED) {