Add python script for publishing image #8

2021-03-16T11:34:32Z

mhfowler commented

2021-03-16 11:34:32 +00:00

(Migrated from github.com)

This PR includes

add publish_img.py script for publishing the image to releases.peachcloud.org and updating the version numbers and links for the microservices appropriately
updates the image build to use the latest interface for peach-config
includes a manifest file as part of the release as created by peach-config manifest

This PR includes - add publish_img.py script for publishing the image to releases.peachcloud.org and updating the version numbers and links for the microservices appropriately - updates the image build to use the latest interface for peach-config - includes a manifest file as part of the release as created by peach-config manifest

👍 1

mhfowler commented

2021-03-16 11:36:29 +00:00

(Migrated from github.com)

@mycognosist I removed the if statement you made for the compression about copying the uncompressed image if compression didn't work,
as it was easier to reason about the publishing if I assumed all previous steps worked and the image would definitley have the name raspi_3.img.xz

I think with releases/publishing its often a good practice to just fail if anything doesn't go to plan, since this is the stage we're hoping for a polished output

@mycognosist I removed the if statement you made for the compression about copying the uncompressed image if compression didn't work, as it was easier to reason about the publishing if I assumed all previous steps worked and the image would definitley have the name raspi_3.img.xz I think with releases/publishing its often a good practice to just fail if anything doesn't go to plan, since this is the stage we're hoping for a polished output

mycognosist commented

2021-03-16 13:14:00 +00:00

(Migrated from github.com)

@mhfowler

I think with releases/publishing its often a good practice to just fail if anything doesn't go to plan, since this is the stage we're hoping for a polished output

Thanks for the explanation. That makes a lot of sense to me and sounds like a good practice.

@mhfowler > I think with releases/publishing its often a good practice to just fail if anything doesn't go to plan, since this is the stage we're hoping for a polished output Thanks for the explanation. That makes a lot of sense to me and sounds like a good practice.

mycognosist (Migrated from github.com) approved these changes 2021-03-16 13:14:11 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: PeachCloud/peach-img-builder#8