Add -d option for build_packages to ensure default branch #7
No reviewers
Labels
No Label
bug
documentation
duplicate
enhancement
help wanted
invalid
maintenance
peach-lib
peach-network
peach-oled
peach-stats
peach-web
question
refactor
wontfix
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: PeachCloud/peach-package-builder#7
Loading…
Reference in New Issue
No description provided.
Delete Branch "default-branch"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
While working on building the peach-image, I took advantage of the fact that on the VPS we can build packages with code that is not from the main/master/default branch (useful for building stuff which is not yet merged).
However, this leads to repos on the vps potentially being in the wrong branch, and this causing a headache in the future.
So, here I've added a -d flag to build_packages.py which ensures that all repos are in the correct default branch (main or master) before building the packages
I'm really glad you thought of this. I can imagine a lot of confusion being caused by packages from non-default branches.
That command for determining the default branch is neat. Nice work :)
This also reminds me that we should rename all default branches to
main
. Would that break the new flag feature you're adding here?@mycognosist nope that wouldn't break it. If all our repos were default branch main, then I might have skipped that git command, and just checked out main as its simpler.. but using git to look up which is the the name of the default branch doesn't hurt in any event.