Add -d option for build_packages to ensure default branch #7

2021-02-19T15:29:08Z

mhfowler commented

2021-02-19 15:29:08 +00:00

(Migrated from github.com)

While working on building the peach-image, I took advantage of the fact that on the VPS we can build packages with code that is not from the main/master/default branch (useful for building stuff which is not yet merged).

However, this leads to repos on the vps potentially being in the wrong branch, and this causing a headache in the future.

So, here I've added a -d flag to build_packages.py which ensures that all repos are in the correct default branch (main or master) before building the packages

While working on building the peach-image, I took advantage of the fact that on the VPS we can build packages with code that is not from the main/master/default branch (useful for building stuff which is not yet merged). However, this leads to repos on the vps potentially being in the wrong branch, and this causing a headache in the future. So, here I've added a -d flag to build_packages.py which ensures that all repos are in the correct default branch (main or master) before building the packages

mycognosist (Migrated from github.com) approved these changes 2021-02-22 09:55:33 +00:00

mycognosist (Migrated from github.com) left a comment

I'm really glad you thought of this. I can imagine a lot of confusion being caused by packages from non-default branches.

That command for determining the default branch is neat. Nice work :)

I'm really glad you thought of this. I can imagine a lot of confusion being caused by packages from non-default branches. That command for determining the default branch is neat. Nice work :)

mycognosist commented

2021-02-22 09:56:21 +00:00

(Migrated from github.com)

This also reminds me that we should rename all default branches to main. Would that break the new flag feature you're adding here?

This also reminds me that we should rename all default branches to `main`. Would that break the new flag feature you're adding here?

mhfowler commented

2021-02-22 10:24:03 +00:00

(Migrated from github.com)

@mycognosist nope that wouldn't break it. If all our repos were default branch main, then I might have skipped that git command, and just checked out main as its simpler.. but using git to look up which is the the name of the default branch doesn't hurt in any event.

👍 1

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: PeachCloud/peach-package-builder#7