Split setup script #5

2020-12-18T09:32:48Z

mycognosist commented

2020-12-18 09:32:48 +00:00

(Migrated from github.com)

Addresses: https://github.com/peachcloud/peach-vps/pull/3#issuecomment-747918761

Split the previous build & deploy script (scripts/setup_debian_repo.py) into two scripts: one for initial environment setup and compiler updates (scripts/setup_build_env.py) and one for package building and archive updates (scripts/build_packages.py).

Usage is described in the README.

This aims to provide a neat separation of concerns and make the updating of the Debian package archive more efficient.

Addresses: https://github.com/peachcloud/peach-vps/pull/3#issuecomment-747918761 Split the previous build & deploy script (`scripts/setup_debian_repo.py`) into two scripts: one for initial environment setup and compiler updates (`scripts/setup_build_env.py`) and one for package building and archive updates (`scripts/build_packages.py`). Usage is described in the README. This aims to provide a neat separation of concerns and make the updating of the Debian package archive more efficient.

mhfowler commented

2020-12-18 17:31:59 +00:00

(Migrated from github.com)

👍

:+1:

mhfowler (Migrated from github.com) approved these changes 2020-12-18 17:32:48 +00:00

mhfowler commented

2020-12-21 17:42:33 +00:00

(Migrated from github.com)

At first when I tested this on the pi it didn't work, but then I looked onto the VPS and saw the url structure was slightly changed. I added a commit to this PR with those changes.

After making those changes, it now works! successully apt-installed :)

Also in /var/www/apt.peachcloud.org on the vps, there are a few extra files now:
keyring.gpg, peach.gpg and peach_pub.gpg
should we delete them?

pubkey.gpg is the one I downloaded which appears to be work

Whatever we decide to call the key, we should also update line 127 of setup_build_env.py to include the right key name.

@mycognosist (also wondering, when I make comments and PRs do you get notifications? or do I need to tag you?)

At first when I tested this on the pi it didn't work, but then I looked onto the VPS and saw the url structure was slightly changed. I added a commit to this PR with those changes. After making those changes, it now works! successully apt-installed :) Also in /var/www/apt.peachcloud.org on the vps, there are a few extra files now: keyring.gpg, peach.gpg and peach_pub.gpg should we delete them? pubkey.gpg is the one I downloaded which appears to be work Whatever we decide to call the key, we should also update line 127 of setup_build_env.py to include the right key name. @mycognosist (also wondering, when I make comments and PRs do you get notifications? or do I need to tag you?)

👍 1

mycognosist commented

2020-12-28 09:04:12 +00:00

(Migrated from github.com)

@mhfowler

Thanks for the review and additional testing. I'm not completely sure if it's necessary to @-mention me in these comments but I don't think it is. I receive email notifications for all activity on the PeachCloud repos.

Good catch regarding the updated URL structure and key. I can confirm that the changes you committed are working on my Pi. We can delete the other keys to remove any confusion in the future. I'll make the change to line 127 of the script.

I'm sharing a couple of commands here which I found helpful while updating apt and testing on my Pi:

List all keys (the PeachCloud key appears under /etc/apt/trusted.gpg):
sudo apt-key list

Delete a key (key id is the last 8 letters of the key - in other words, the last two blocks of 4 characters):
sudo apt-key del <KEYID>

@mhfowler Thanks for the review and additional testing. I'm not completely sure if it's necessary to @-mention me in these comments but I don't think it is. I receive email notifications for all activity on the PeachCloud repos. Good catch regarding the updated URL structure and key. I can confirm that the changes you committed are working on my Pi. We can delete the other keys to remove any confusion in the future. I'll make the change to line 127 of the script. I'm sharing a couple of commands here which I found helpful while updating `apt` and testing on my Pi: List all keys (the PeachCloud key appears under `/etc/apt/trusted.gpg`): `sudo apt-key list` Delete a key (key id is the last 8 letters of the key - in other words, the last two blocks of 4 characters): `sudo apt-key del <KEYID>`

Sign in to join this conversation.

No reviewers

mhfowler