Insert domain into generated invites #124

New Issue

notplants · 2022-06-27T20:42:15Z

notplants commented

2022-06-27 20:42:15 +00:00

Invites currently take this form:
[::]:8009:@fxKem3e9v0VyU2+Nv/DiGC5RvdLA9HfmjJmT02Zw75k=.ed25519~R6F/TT6Xo6HdUcsdR+xXm8hH20gGkReBtOMNpeLyCYs=

We should look for the configured domain, and find and replace [::] with the configured domain, if it is configured.

Then in a yunohost install, we should also be able to configure the domain through environental variables, so yunohost can provide a domain to peachpub during install.

Invites currently take this form: [::]:8009:@fxKem3e9v0VyU2+Nv/DiGC5RvdLA9HfmjJmT02Zw75k=.ed25519~R6F/TT6Xo6HdUcsdR+xXm8hH20gGkReBtOMNpeLyCYs= We should look for the configured domain, and find and replace [::] with the configured domain, if it is configured. Then in a yunohost install, we should also be able to configure the domain through environental variables, so yunohost can provide a domain to peachpub during install.

👍 1

glyph commented

2022-06-28 10:31:51 +00:00

@notplants

Nice, this would be a great addition! Would it be as simple as calling the domainname Linux command, parsing the return value and replacing [::] with the value if it's not (none)?

@notplants Nice, this would be a great addition! Would it be as simple as calling the `domainname` Linux command, parsing the return value and replacing `[::]` with the value if it's not `(none)`?

notplants commented

2022-06-29 20:58:45 +00:00

when I run domainname on my yunohost instance it returns (none). Additionally, on yunohost, you can configure many different apps with different domains, so I don't think domainname could work in that context.

In this PR (#125) I used a configured variable that I created while working on dynamic DNS. It appears to be working, and is easy for me to configure as required during the yunohost install script.

when I run domainname on my yunohost instance it returns (none). Additionally, on yunohost, you can configure many different apps with different domains, so I don't think domainname could work in that context. In this PR (https://git.coopcloud.tech/PeachCloud/peach-workspace/pulls/125) I used a configured variable that I created while working on dynamic DNS. It appears to be working, and is easy for me to configure as required during the yunohost install script.

👍 1

notplants commented

2022-06-30 13:01:58 +00:00

closed via this issue #125

closed via this issue https://git.coopcloud.tech/PeachCloud/peach-workspace/pulls/125

🎉 1

notplants closed this issue

2022-06-30 13:01:58 +00:00

Sign in to join this conversation.