Insert domain into invite #125
No reviewers
Labels
No Label
bug
documentation
duplicate
enhancement
help wanted
invalid
maintenance
peach-lib
peach-network
peach-oled
peach-stats
peach-web
question
refactor
wontfix
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: PeachCloud/peach-workspace#125
Loading…
Reference in New Issue
No description provided.
Delete Branch "insert-invite"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
If a domain is configured, it replaces [::] in the invite with the domain, and if not it leaves it.
A config variable for configuring a domain was already created earlier as part of dynamic dns route. The config variable was named EXTERNAL_DOMAIN to differentiate it from DYN_DOMAIN (another configurable variable).
Great, looks good to me.
It would be good to document all of the config variables in the
peach-lib
README at some point and link to it from thepeach-web
README.@glyph agreed, made an issue for that here #126