PeachCloud/peach-workspace
3
2
Fork 1
Code Issues 17 Pull Requests 1 Projects Releases Wiki Activity

Fix peach-config manifest #103

Merged
notplants merged 5 commits from fix-manifest into main 2022-04-20 18:27:47 +00:00
Conversation 1 Commits 5 Files Changed 3 +18 -26
notplants commented 2022-04-20 16:21:54 +00:00
Owner
Copy Link

This PR fixes peach-config manifest (which is also used by peach-img-builder to generate the package version list on releases.peachcloud.org)

Before I was using a hacky command which searches for all packages beginning with peach- using dpkg and a regex.

After changing peach-go-sbot to go-sbot, this command no longer worked.

I changed the manifest code to use dpkg-query and actually query with the package names, which works for go-sbot, and is also more reliable code.

Also had some fun with concise rust transforms.

This PR fixes `peach-config manifest` (which is also used by peach-img-builder to generate the package version list on releases.peachcloud.org) Before I was using a hacky command which searches for all packages beginning with peach- using dpkg and a regex. After changing peach-go-sbot to go-sbot, this command no longer worked. I changed the manifest code to use dpkg-query and actually query with the package names, which works for go-sbot, and is also more reliable code. Also had some fun with concise rust transforms.
notplants added 4 commits 2022-04-20 16:21:55 +00:00
Fix manifest a347e4726d
More concise transforms f764acc2df
Add doc comment cf9c0c7eca
Remove unused import
All checks were successful
continuous-integration/drone/pr Build is passing
Details
03720a7338
notplants requested review from glyph 2022-04-20 16:22:03 +00:00
notplants added 1 commit 2022-04-20 17:56:03 +00:00
Remove extraneous quote
All checks were successful
continuous-integration/drone/pr Build is passing
Details
d03de8cf5d
glyph approved these changes 2022-04-20 18:25:03 +00:00
glyph left a comment
Owner
Copy Link

Nice! 🟢

Nice! 🟢
notplants merged commit e2ac5de6e4 into main 2022-04-20 18:27:47 +00:00
notplants deleted branch fix-manifest 2022-04-20 18:27:48 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
glyph
Labels
Clear labels
bug
Something is not working
documentation
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
maintenance
Pruning and weeding
peach-lib
peach-network
peach-oled
peach-stats
peach-web
question
More information is needed
refactor
Code rewrite
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
cblgh glyph notplants
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: PeachCloud/peach-workspace#103
No description provided.
Delete Branch "fix-manifest"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?