Change go-sbot.service name to be configurable #113

notplants · 2022-05-20T11:38:39Z

notplants commented

2022-05-20 11:38:39 +00:00

This PR changes the name of go-sbot.service to be configurable, using go-sbot.service as the default.

This is possibly unnecessary but is the only thing to my knowledge which would prevent a yunohost installation with multiple instances installed on the same machine (admittedly I mightly partly succumbing to yunohost gamification here, where if you pass all the criteria, including multi-install, your applications gets a higher level... I am a sucker for points... but maybe this is a small change...)

This PR changes the name of go-sbot.service to be configurable, using go-sbot.service as the default. This is possibly unnecessary but is the only thing to my knowledge which would prevent a yunohost installation with multiple instances installed on the same machine (admittedly I mightly partly succumbing to yunohost gamification here, where if you pass all the criteria, including multi-install, your applications gets a higher level... I am a sucker for points... but maybe this is a small change...)

👍 1

notplants added 2 commits 2022-05-20 11:38:49 +00:00

continuous-integration/drone/pr Build is passing Details

7deaa00d6e Fix hardcoded path

continuous-integration/drone/pr Build is passing Details

56c142a387 Make go-sbot.service name configurable

notplants requested review from glyph 2022-05-20 11:39:00 +00:00

notplants added 1 commit 2022-05-20 11:57:35 +00:00

continuous-integration/drone/pr Build is passing Details

6434471599 Bump version numbers

notplants added 2 commits 2022-05-20 14:33:22 +00:00

continuous-integration/drone/pr Build was killed Details

543470b949 Fix lockfile

continuous-integration/drone/pr Build was killed Details

92f516b161 Merge pull request 'Fix lockfile' (#114 ) from fix-lock into go-sbot-service

Reviewed-on: #114

notplants added 2 commits 2022-05-25 10:27:22 +00:00

3adb226969 Bump version number

continuous-integration/drone/pr Build is passing Details

6c9e5fd3fd Merge branch 'go-sbot-service' of https://git.coopcloud.tech/PeachCloud/peach-workspace into change-paths

notplants added 2 commits 2022-05-26 21:19:43 +00:00

3493e5adb9 Change sbot.rs to use configurable go-sbot service name

continuous-integration/drone/pr Build is failing Details

16e6d42f87 Cargo clippy

glyph requested changes 2022-06-08 07:37:24 +00:00

glyph left a comment

Looks good! I just left a single comment about module / function imports.

Seems like there's a small merge conflict to resolve and then you're good to go.

Looks good! I just left a single comment about module / function imports. Seems like there's a small merge conflict to resolve and then you're good to go.

peach-lib/src/sbot.rs Outdated

						
				@ -68,3 +68,3 @@

				        let info_output = Command::new("systemctl")

				            .arg("show")

				            .arg("go-sbot.service")

				            .arg(get_config_value("GO_SBOT_SERVICE")?)

glyph commented

2022-06-08 07:36:33 +00:00

One suggestion I have is to reference the module when calling the function (ie. to not import all the way down to the function level):

use crate::config_manager;

let info_output = Command::new("systemctl")
	.arg("show")
	.arg(config_manager::get_config_value("GO_SBOT_SERVICE")?)

The result is more verbose and not as pretty and clean, but it helps to communicate where this get_config_value function is defined. This has saved me a lot of time in the past when I'm trying to follow the code and find functions: "Does this function live in this file or somewhere else?". It's also the idiomatic way for Rust.

One suggestion I have is to reference the module when calling the function (ie. to not import all the way down to the function level): ```rust use crate::config_manager; let info_output = Command::new("systemctl") .arg("show") .arg(config_manager::get_config_value("GO_SBOT_SERVICE")?) ``` The result is more verbose and not as pretty and clean, but it helps to communicate where this `get_config_value` function is defined. This has saved me a lot of time in the past when I'm trying to follow the code and find functions: "Does this function live in this file or somewhere else?". It's also the idiomatic way for Rust.

notplants commented

2022-06-15 11:36:49 +00:00

cool I updated all the get_config_value I could find to use this form