URL encode SSB public keys on profile page #116

Merged

glyph merged 5 commits from fix_encoding_decoding into main 2022-06-16 10:38:19 +00:00

Conversation 2 Commits 5 Files Changed 3 +152 -156

glyph commented 2022-06-15 07:42:15 +00:00

Owner

Copy Link

Replaces / with %2F for all SSB public keys on the /scuttlebutt/profile route.

This addresses #91 and #96.

Replaces `/` with `%2F` for all SSB public keys on the `/scuttlebutt/profile` route. This addresses https://git.coopcloud.tech/PeachCloud/peach-workspace/issues/91 and https://git.coopcloud.tech/PeachCloud/peach-workspace/issues/96.

glyph added 2 commits 2022-06-15 07:42:16 +00:00

url-encode the ssb id for profile buttons f3d4ba9fe5

update lockfile 0923c24693

glyph requested review from notplants 2022-06-15 07:42:26 +00:00

glyph added the

bug

peach-web

labels 2022-06-15 08:05:14 +00:00

notplants commented 2022-06-15 12:07:27 +00:00

Owner

Copy Link

is there some type of encoding that we could use that would be more general than just replacing / with %2F , or is the only possible character that needs to be changed?

Otherwise looks good!

is there some type of encoding that we could use that would be more general than just replacing / with %2F , or is the only possible character that needs to be changed? Otherwise looks good!

glyph commented 2022-06-16 08:13:47 +00:00

Author

Owner

Copy Link

@notplants

The / seemed to be the only character causing issues for the route handler so I went with the simplest solution.

A more general approach would be to URL-encode the entire key. Here's an example:

@Sur8RwcDh6kBjub8pLZpHNWDfuuRpYVyCHrVo+TdA/4=.ed25519

becomes...

%40Sur8RwcDh6kBjub8pLZpHNWDfuuRpYVyCHrVo%2BTdA%2F4%3D%2Eed25519

One thing I like about the /-only solution is that the key remains fairly readable and recognisable as an SSB ID. I'm tempted to stick with that solution and only implement the more complete encoding if we run into another issue.

@notplants The `/` seemed to be the only character causing issues for the route handler so I went with the simplest solution. A more general approach would be to URL-encode the entire key. Here's an example: `@Sur8RwcDh6kBjub8pLZpHNWDfuuRpYVyCHrVo+TdA/4=.ed25519` becomes... `%40Sur8RwcDh6kBjub8pLZpHNWDfuuRpYVyCHrVo%2BTdA%2F4%3D%2Eed25519` One thing I like about the `/`-only solution is that the key remains fairly readable and recognisable as an SSB ID. I'm tempted to stick with that solution and only implement the more complete encoding if we run into another issue.

glyph added 2 commits 2022-06-16 10:10:41 +00:00

bump version in manifest 216b60b86a

merge changes from main 11e94fa421

glyph added 1 commit 2022-06-16 10:19:15 +00:00

fix probes version 76d5e6a355

glyph merged commit 6ad5c620c1 into main 2022-06-16 10:38:19 +00:00

glyph referenced this issue from a commit 2022-06-16 10:38:20 +00:00

Merge pull request 'URL encode SSB public keys on profile page' (#116) from fix_encoding_decoding into main

glyph deleted branch fix_encoding_decoding 2022-06-16 10:38:20 +00:00

glyph referenced this pull request 2022-06-16 10:42:36 +00:00

[BUG] URL (en|de)coding for SSB keys #91

glyph referenced this pull request 2022-06-16 10:43:00 +00:00

[BUG] Sending private message fails with 404 #96

Sign in to join this conversation.

Reviewers

No Reviewers

notplants

Labels

Clear labels

bug

Something is not working

documentation

duplicate

This issue or pull request already exists

enhancement

New feature

help wanted

Need some help

invalid

Something is wrong

maintenance

Pruning and weeding

peach-lib

peach-network

peach-oled

peach-stats

peach-web

question

More information is needed

refactor

Code rewrite

wontfix

This won't be fixed

No Label

bug

peach-web

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

cblgh glyph notplants

No Assignees

2 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: PeachCloud/peach-workspace#116

No description provided.