PeachCloud/peach-workspace
3
2
Fork 1
Code Issues 17 Pull Requests 1 Projects Releases Wiki Activity

Introduce JS for improved back button behaviour #121

Merged
glyph merged 3 commits from js_back_button into main 2022-06-28 08:14:43 +00:00
Conversation 2 Commits 3 Files Changed 4 +25 -4
glyph commented 2022-06-23 11:07:41 +00:00
Owner
Copy Link

As discussed in #120, this PR adds JavaScript to override the default, hardcoded back button URL for every page of the UI.

If JavaScript is disabled in the browser, the underlying back button functionality continues to work in its usual slightly-quirky fashion :)

I wanted to encapsulate the JS in a separate file (/static/back.js) but I ran into a strange issue where the HTML beyond the <script src="/static/back.js"></script> tag would not render (even though it was present in the source). Since the JS is simple and brief, I went with the fallback option of rendering it in a <script> tag with Maud.

As discussed in https://git.coopcloud.tech/PeachCloud/peach-workspace/pulls/120, this PR adds JavaScript to override the default, hardcoded back button URL for every page of the UI. If JavaScript is disabled in the browser, the underlying back button functionality continues to work in its usual slightly-quirky fashion :) I wanted to encapsulate the JS in a separate file (`/static/back.js`) but I ran into a strange issue where the HTML beyond the `<script src="/static/back.js"></script>` tag would not render (even though it was present in the source). Since the JS is simple and brief, I went with the fallback option of rendering it in a `<script>` tag with Maud.
glyph added 2 commits 2022-06-23 11:07:42 +00:00
add js to overlay back button functionality 4568577f81
bump patch version and update lockfile
All checks were successful
continuous-integration/drone/pr Build is passing
Details
d1a55e29d7
glyph requested review from notplants 2022-06-23 11:08:11 +00:00
glyph added the
enhancement
peach-web
 labels 2022-06-23 11:08:18 +00:00
notplants commented 2022-06-27 19:27:56 +00:00
Owner
Copy Link

hmm strange about the html bug. something about html syntax?

would also prefer separate js files to js within script tags in general, but also doesn't matter much since its a small amount of code

hmm strange about the html bug. something about html syntax? would also prefer separate js files to js within script tags in general, but also doesn't matter much since its a small amount of code
glyph commented 2022-06-28 08:11:19 +00:00
Author
Owner
Copy Link

hmm strange about the html bug. something about html syntax?

I tried tinkering with it for an hour and couldn't figure it out. Very weird.

> hmm strange about the html bug. something about html syntax? I tried tinkering with it for an hour and couldn't figure it out. Very weird.
👍 1
glyph added 1 commit 2022-06-28 08:14:05 +00:00
merge main
All checks were successful
continuous-integration/drone/pr Build is passing
Details
9ce27d17c5
glyph merged commit 123ebc06cc into main 2022-06-28 08:14:43 +00:00
glyph deleted branch js_back_button 2022-06-28 08:14:45 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
notplants
Labels
Clear labels
bug
Something is not working
documentation
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
maintenance
Pruning and weeding
peach-lib
peach-network
peach-oled
peach-stats
peach-web
question
More information is needed
refactor
Code rewrite
wontfix
This won't be fixed
No Label
enhancement
peach-web
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
cblgh glyph notplants
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: PeachCloud/peach-workspace#121
No description provided.
Delete Branch "js_back_button"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?