Introduce JS for improved back button behaviour #121

glyph · 2022-06-23T11:07:41Z

glyph commented

2022-06-23 11:07:41 +00:00

As discussed in #120, this PR adds JavaScript to override the default, hardcoded back button URL for every page of the UI.

If JavaScript is disabled in the browser, the underlying back button functionality continues to work in its usual slightly-quirky fashion :)

I wanted to encapsulate the JS in a separate file (/static/back.js) but I ran into a strange issue where the HTML beyond the <script src="/static/back.js"></script> tag would not render (even though it was present in the source). Since the JS is simple and brief, I went with the fallback option of rendering it in a <script> tag with Maud.

As discussed in https://git.coopcloud.tech/PeachCloud/peach-workspace/pulls/120, this PR adds JavaScript to override the default, hardcoded back button URL for every page of the UI. If JavaScript is disabled in the browser, the underlying back button functionality continues to work in its usual slightly-quirky fashion :) I wanted to encapsulate the JS in a separate file (`/static/back.js`) but I ran into a strange issue where the HTML beyond the `<script src="/static/back.js"></script>` tag would not render (even though it was present in the source). Since the JS is simple and brief, I went with the fallback option of rendering it in a `<script>` tag with Maud.

glyph added 2 commits 2022-06-23 11:07:42 +00:00

4568577f81 add js to overlay back button functionality

continuous-integration/drone/pr Build is passing Details

d1a55e29d7 bump patch version and update lockfile

glyph requested review from notplants 2022-06-23 11:08:11 +00:00

glyph added the

enhancement

peach-web

labels 2022-06-23 11:08:18 +00:00

glyph referenced this pull request

2022-06-27 07:31:45 +00:00

[BUG] Back button does not always behave accurately (redirects to incorrect page) #92

glyph referenced this pull request

2022-06-27 08:03:13 +00:00

Update configuration sections of README #122

notplants commented

2022-06-27 19:27:56 +00:00

hmm strange about the html bug. something about html syntax?

would also prefer separate js files to js within script tags in general, but also doesn't matter much since its a small amount of code

hmm strange about the html bug. something about html syntax? would also prefer separate js files to js within script tags in general, but also doesn't matter much since its a small amount of code

glyph referenced this pull request

2022-06-28 08:10:14 +00:00

Improve back button behaviour #120

glyph commented

2022-06-28 08:11:19 +00:00